All Activity
Saturday 01 Nov
7:26 pm

mischa

Fix double click prevention by fetching nextval before export_vars

Options
    • -5
    • +3
    /openacs-4/packages/acs-subsite/www/admin/site-map/index.tcl
6:50 pm

mischa

Add missing parameter value

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/site-map/auto-mount.tcl
6:26 pm

mischa

fix application-delete loop to keep package_ids intact

Options
    • -4
    • +4
    /openacs-4/packages/acs-subsite/www/admin/applications/application-delete.tcl
4:49 pm

mischa

bind make-member query to loop variable when demoting admins

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/members/make-member.xql
4:14 pm

mischa

the code in member-state-change actually expects a single rel_id

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/members/member-state-change.tcl
3:55 pm

mischa

fix member-remove loop to handle multiple user_ids correctly

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/members/member-remove.tcl
Wednesday 29 Oct
11:46 am

mischa

Fix name of form - avoid swallowed form error messages

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/www/admin/edit-localized-message.tcl
Monday 27 Oct
2:12 pm

gustafn

changed infinite loop into a fixed number (5) of retries

Options
    • -1
    • +6
    /openacs-4/packages/assessment/tcl/as-item-data-procs.tcl
    • -1
    • +6
    /openacs-4/packages/assessment/tcl/as-session-procs.tcl
Sunday 26 Oct
10:10 am

mischa

Dont try to substitute variables here

Options
    • -1
    • +1
    /openacs-4/packages/acs-lang/www/admin/lookup.tcl
Wednesday 22 Oct
11:56 am

gustafn

backport from HEAD.

Bumped version number to 0.67d1, leaving room for further backports

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/xotcl-request-monitor.info
    • -11
    • +2
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
11:50 am

gustafn

removed duplicated definition.

Many thanks to Franz Penz for noting it

Options
    • -11
    • +2
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
Tuesday 21 Oct
6:17 pm

gustafn

added an additinal has function scrypt-16384-1-8 to deal with argument flipping in NaviSever 4.99

Between 4.99.20 and 4.99.31 (inclusive) there is a argument flipping bug for

::ns_crypto::scrypt (the parameters "r" and "p" were interpreted with flipped

semantics). In case you are using SCRYPT for your password hashes with an

affected version, you have to change the hash argorithm from scrypt-16384-8-1

to scrypt-16384-1-8 to check the previouly hashed passwords correctly.

NaviServer 5 is not affected by this.

Options
    • -1
    • +16
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Tuesday 14 Oct
3:29 pm

gustafn

backport from HEAD

Options
    • -5
    • +25
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
3:28 pm

gustafn

improved robustness against certain installations:

- added exception handler for failed open command

- added sensible defaults in case the ns/parameter serverlog is not defined

Options
    • -3
    • +20
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
Sunday 12 Oct
12:38 pm

mischa

Use noi18n instead of literal to avoid localization of eventually nested messages at this point

Options
    • -5
    • +5
    /openacs-4/packages/acs-lang/www/admin/message-list.tcl
12:30 pm

mischa

Dont localize eventually nested messages at this point

Options
    • -5
    • +5
    /openacs-4/packages/acs-lang/www/admin/message-list.tcl
Friday 10 Oct
3:07 pm

mischa

Fix anchor by prepending form name

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/shared/parameters.tcl
Wednesday 08 Oct
6:44 pm

gustafn

backported change from HEAD. Fixes #3479

See also https://github.com/openacs/openacs-core/commit/91bc59a427e2d2d5c45b243285ad4c4cf8b290c9

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/member-state-change.tcl
Thursday 25 Sep
7:03 pm

gustafn

improved robstness when raw IP-V6 addresses are configured (rather than domain names)

backport from head

Options
    • -2
    • +5
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
1:28 pm

gustafn

improved robstness when raw IP-V6 addresses are configured (rather than domain names)

Options
    • -3
    • +6
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Wednesday 24 Sep
5:39 pm

gustafn

bugfix(util_driver_info): reduce dependency on hardcoded driver names

- Avoid reliance on specific driver names (nsssl, nsudp, nsunix,

nsopenssl, nssocket) by falling back to generic "ns_driver info"

when available.

- Added explicit error message when "hostname" is missing on a network

driver module to prevent silent misconfiguration. This fixes a

potential infinite loop when OpenACS attempts to resolve the

"hostname" value.

This is a backport from the HEAD branch

Options
    • -3
    • +38
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
5:37 pm

gustafn

bugfix(util_driver_info): reduce dependency on hardcoded driver names

- Avoid reliance on specific driver names (nsssl, nsudp, nsunix,

nsopenssl, nssocket) by falling back to generic "ns_driver info"

when available.

- Added explicit error message when "hostname" is missing on a network

driver module to prevent silent misconfiguration. This fixes a

potential infinite loop when OpenACS attempts to resolve the

"hostname" value.

Options
    • -6
    • +41
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
5:23 pm

gustafn

added debugging hooks

Options
    • -1
    • +9
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Tuesday 29 Jul
11:36 am

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
11:32 am

antoniop

Bump tinyMCE default version number to 8.0.1

This is a major release upgrade, with a couple breaking changes (see https://www.tiny.cloud/docs/tinymce/latest/migration-from-7x/).

As language pack for version 8 do not exist yet, we currently keep using those from 7 for any version >= 7. This should go away as soon as an own language pack is released for 8.

Options
    • -2
    • +2
    /openacs-4/packages/richtext-tinymce/richtext-tinymce.info
    • -4
    • +13
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
Monday 21 Jul
11:36 am

gustafn

bumped version number

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/acs-subsite.info
11:23 am

gustafn

Fix accidental removal of root site‑node read permissions (#3477)

Submitting the “/” site‑map permissions form without any changes inadvertently

omitted direct (read‑only) permissions, causing not-logged-in users to see

“The page isn’t redirecting properly” when accessing the root node.

This change ensures that existing direct permissions are preserved when

the form is submitted, even if no changes were made.

Thanks to Khy H for reporting this!

Backport from main branch

Options
    • -1
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl
11:21 am

gustafn

Fix accidental removal of root site‑node read permissions (#3477)

Submitting the “/” site‑map permissions form without any changes inadvertently

omitted direct (read‑only) permissions, causing not-logged-in users to see

“The page isn’t redirecting properly” when accessing the root node.

This change ensures that existing direct permissions are preserved when

the form is submitted, even if no changes were made.

Thanks to Khy H for reporting this!

Options
    • -1
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl
Sunday 20 Jul
12:48 pm

gustafn

fix for bug #3476: ilike is not supported on Oracle

Many thanks to Sung Hong for the report and fix.

backport from HEAD

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/perm-user-add-include.tcl
12:46 pm

gustafn

fix for bug #3476: ilike is not supported on Oracle

Many thanks to Sung Hong for the report and fix

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/perm-user-add-include.tcl