• last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
deactivate automated theme setting for now

keep theme-stetting for dotlrn themes in dotlrn, since it requires a dotlrn instance

but when the dotlrn is installed, it requires the dotlrn-theme package to be installed

    • -0
    • +2
    ./packages/acs-tcl/tcl/site-nodes-procs.tcl
    • -2
    • +3
    ./packages/dotlrn/tcl/apm-callback-procs.tcl
Continue working on the install.xml issue.

    • -8
    • +9
    ./packages/acs-tcl/tcl/site-nodes-procs.tcl
added more debugging info

    • -2
    • +7
    ./packages/acs-tcl/tcl/install-procs.tcl
    • -2
    • +2
    ./packages/acs-tcl/tcl/site-nodes-procs.tcl
undo one more recent change

    • -3
    • +3
    ./packages/acs-tcl/tcl/install-procs.tcl
undo recent change. This was not the problem

    • -5
    • +1
    ./packages/acs-tcl/tcl/install-procs.tcl
added debug statement

    • -0
    • +1
    ./packages/acs-tcl/tcl/site-nodes-procs.tcl
try to get a non-empty context id

    • -3
    • +7
    ./packages/acs-tcl/tcl/install-procs.tcl
added debugging line

    • -1
    • +8
    ./packages/acs-tcl/tcl/install-procs.tcl
Fixed incorrect result handling from ::acs::site_node get_node_id

When

::acs::site_node get_node_id -url /$mount_point

is executed with a non-existing mount point, the node info of the

parent_id is returned. The code assumed that for such cases, the

resulting "object_id" member is empty. Since this affects only the

two action procs

install::xml::action::mount

install::xml::action::mount-existing

i have adjusted the behavior there.

Furthermore, some tests are now less mind-twisted.

    • -13
    • +11
    ./packages/acs-tcl/tcl/install-procs.tcl
strangely, parameter CommDefaultSiteTemplate_p was set on wrong package_id

Before this change, the install from repo on dotlrn led to error below.

this change makes sure, that the used "package_id" is the package_id from dotlrn.

: ERROR: -20000: The specified package 702 AND/OR parameter CommDefaultSiteTemplate_p do not exist in the system

: CONTEXT: PL/pgSQL function apm__id_for_name(integer,character varying) line 13 at RAISE

: PL/pgSQL function apm__set_value(integer,character varying,character varying) line 6 at assignment

oacs-5-10=# select * from apm_packages where package_key like '%dotlrn%';

package_id | package_key | instance_name | default_locale

------------+-------------------------+----------------------------+----------------

1843 | dotlrn-bm | dotLRN Bulk Mail Applet |

1850 | dotlrn-faq | dotLRN FAQ Applet |

1868 | dotlrn-forums | dotLRN Forums Applet |

1886 | dotlrn-fs | dotLRN File Storage Applet |

1933 | dotlrn-news | dotLRN News Applet |

1981 | dotlrn-portlet | dotLRN Portlet |

1998 | dotlrn-assessment | dotLRN Assessment Applet |

2040 | dotlrn-bootstrap3-theme | dotLRN Bootstrap 3 Theme |

oacs-5-10=# select * from apm_packages where package_id = 702;

package_id | package_key | instance_name | default_locale

------------+-------------+------------------------+----------------

702 | acs-subsite | #acs-kernel.Main_Site# |

moved theme setting to theme package (dotlrn-bootstrap3-theme)

This make sure that in the loading sequence, the theme is available when one

tries to switch to it.

added "dotlrn-bootstrap3-theme" to dependencies to make it installable via "install.xml" for install-from-repository

fixed dependencies

improved log messages

    • -2
    • +3
    ./packages/acs-tcl/tcl/apm-install-procs.tcl
bump maturity from 1 to 2

fixed typo in filename of image

    • binary
    ./packages/acs-subsite/www/shared/images/recycle16.png
    • -1
    • +1
    ./packages/acs-templating/tcl/style-procs.tcl
Cleanup stale sse connections

    • -1
    • +6
    ./packages/notifications/tcl/sweep-init.tcl
    • -1
    • +16
    ./packages/notifications/tcl/sweep-procs.tcl
Introduce a new delivery method for notifications based on Server Sent events

By subscribing to /notifications/sse/subscribe one will receive notifications as JSON messages. This can be used e.g. to update a UI in real time based on events on the system.

    • -0
    • +10
    ./packages/notifications/www/sse/subscribe.tcl
Retrieving the datasource should not depend on the fact that a driver is configured

    • -8
    • +6
    ./packages/search/tcl/search-procs.tcl
bump upstream version number from 7.5.1 to 7.6.0

bump upstream version number from 11.4.8 to 12.0.2

    • -2
    • +2
    ./packages/highcharts/tcl/resource-procs.tcl
avoid triggering exception, when provided host header field cannot be resolved.

    • -2
    • +8
    ./packages/acs-tcl/tcl/security-procs.tcl
avoid error, when page_contract is called without an ns_set and without an open connection

fixed typo

    • -4
    • +4
    ./packages/xotcl-core/tcl/03-doc-procs.tcl
Compute the columns as weel when creating a multirow from a list

    • -2
    • +6
    ./packages/acs-templating/tcl/util-procs.tcl
Test converting to and from a multirow and a list

The test reveals that when converting a list into a multirow, the columns will not be set correctly

title always exists now, ensure it is not empty instead

    • -2
    • +2
    ./packages/xowiki/tcl/xowiki-sc-procs.tcl
Introduce the toolbar parameter at the richtext superclass level, so

that formpages created with editors expecting this spec, like ckeditor4,

will not fail to load using other editors that do not expect it

    • -1
    • +2
    ./packages/xowiki/tcl/form-field-procs.tcl