• last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Harden page contract

    • -4
    • +4
    ./notifications/lib/notification-widget.tcl
Whitespace changes

    • -5
    • +14
    ./notifications/lib/notification-widget.tcl
Cleanup obsolete variable

    • -2
    • +0
    ./notifications/lib/notification-widget.tcl
Use adp:icon feature to generate a style-aware icon on every theme

    • -4
    • +6
    ./notifications/lib/notification-widget.adp
    • -2
    • +0
    ./notifications/lib/notification-widget.tcl
Don't customize the notification widget in the Boostrap 5 theme: modern adp:icon functionality makes this obsolete

Don't customize the notification widget in the Boostrap 3 theme: modern adp:icon functionality makes this obsolete

more fixups fr bootstrap5

update bootstrap version number to 5.3.1

    • -2
    • +2
    ./openacs-bootstrap5-theme/openacs-bootstrap5-theme.info
    • -1
    • +1
    ./openacs-bootstrap5-theme/tcl/resource-procs.tcl
Reimplement the news admin index page to use the template system and behave consistently with the rest of the graphics

One reason to have custom markup here was the bulk-actions pointing to the same URL differentiated only via URL parameters. This limitation has been overcome in the previous commit.

template::list bulk-actions feature:

allow to have URL parameters specified in the bulk-action URL, so that the same URL can be used to serve multiple bulk actions differentiated via different flags. The URL parameters override completely every attribute with the same name specified on the form.

    • -5
    • +51
    ./acs-subsite/www/resources/core.js
Be Bootstrap 5 friendly

    • -1
    • +1
    ./proctoring-support/www/proctored-index.adp
bootstrap5 bulkactions: move "ul" element to one level higher

Many thanks to Monika Andergassen for the change

    • -20
    • +23
    ./xowiki/tcl/bootstrap-procs.tcl
bootstrap5 dropt down menu item: add "disabled" class to the anchor element as well

Many thanks to Monika Andergassen for the suggestion

use for bootstrap5 for select input form-select instead of form-control

Many thanks to Monika Andergassen for noting

fix indentation

Space the save button a bit

    • -0
    • +1
    ./proctoring-support/lib/proctoring-display.adp
Truncate timestamp to the seconds

    • -0
    • +2
    ./proctoring-support/lib/proctoring-display.tcl
Apply the Boostrap classes also to the other buttons for consistency

    • -2
    • +2
    ./proctoring-support/lib/proctoring-display.adp
Be Bootstrap5 friendly on the buttons formerly known as "default"

    • -4
    • +4
    ./proctoring-support/lib/proctoring-display.adp
Fix typo

    • -1
    • +1
    ./proctoring-support/lib/proctoring-display.adp
Modernize JavaScript:

- Be specific about the scope and lifetime of variables via const and let

- Always prefer "for" loops to iterators

- Cleanup obsolete wrappers

- Use single and double quotes consistently

- Use the equals operator consistently

    • -197
    • +190
    ./proctoring-support/lib/proctoring-display.adp
Prefer modal implementation from acs-templating to the various approaches used so far

    • -7
    • +8
    ./proctoring-support/lib/proctored-page.adp
    • -44
    • +11
    ./proctoring-support/lib/proctoring-display.adp
Add acknowledgment

    • -0
    • +2
    ./acs-templating/www/resources/tooltip.css
Fix navigation

    • -1
    • +1
    ./acs-templating/www/doc/gadgets/tooltip.adp
Provide a zero-dependency Modal implementation

This uses CSS and little JavaScript. The goal is to provide a Modal implementation that is independend from frameworks such as Boostrap. This is actually very possible in modern CSS and JavaScript.

Documentation with examples is included.

    • -3
    • +6
    ./acs-templating/www/doc/gadgets/index.adp
    • -0
    • +172
    ./acs-templating/www/doc/gadgets/modal.adp
    • -0
    • +31
    ./acs-templating/www/resources/modal.css
    • -0
    • +65
    ./acs-templating/www/resources/modal.js
file modal.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./acs-templating/www/doc/gadgets/modal.adp
file modal.js was initially added on branch oacs-5-10.

    • -0
    • +0
    ./acs-templating/www/resources/modal.js
file modal.css was initially added on branch oacs-5-10.

    • -0
    • +0
    ./acs-templating/www/resources/modal.css
replaced complex and error-prone test with a more sane version

Actually, this test should be in acs-tcl, since all kernel behavior is already

there, and the directory "tcl" was left intentionally empty.

    • -45
    • +4
    ./acs-kernel/tcl/test/acs-kernel-procs.tcl
don't send messages to other threads during shutdown

The threads might be gone already, causing error log entries

    • -3
    • +4
    ./xotcl-core/tcl/40-thread-mod-procs.tcl