Activity OpenACS/openacs-4/packages/xotcl-core/www/show-object.tcl

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	8
Last Commit:	14 Nov
Commits this week:	0
Total Lines of Code (LoC):	457
Net change in LoC this week:	0

Commit Activity

last updated 17 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Thursday 17 Oct

3:01 pm

antoniop

More
MAIN:antoniop:20241017130152
changed 1 file
MAIN

Fix typo

- -2
- +1
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl

Wednesday 16 Oct

11:21 am

gustafn

More
MAIN:gustafn:20241016092121
changed 7 files
MAIN

Added code to skip suspicious looking query variables

On openacs.org, we are experiencing numerous requests with

multiply very long and strange query variables like in the example

below. So far, it is not clear, whether these requests are the

consequence of a double encoding or a deliberate attack. Many (most)

of the requests contain the query variable names containing the

(decoded) pattern "*amp;*".

This is a relatively new phenomenon. I cannot exclude that this is a

bug introduced lately in OpenACS, or a bug in an external bot, or

whatever. The problem with these query variables is that OpenACS

propagates these further, e.g., when updating query variables in

ad_dimensional, via export_vars, or return_urls.

Since OpenACS never uses these query-variables, these can be safely

skipped, without loosing functionality in OpenACS. It is possible to

construct examples, where skipping such variables can change the

semantics. Therefore, the change introduces a single function

util::suspicious_query_variable where in case of problems, the

skipping feature can be deactivated.

GET /api-doc/proc-browse?amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&type=All&amp%3btype=All&amp%3bamp%3btype=All&amp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=Private&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All HTTP/1.1" 200 62378 "" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/605.1.15 (KHTML, like Gecko; compatible; FriendlyCrawler/1.0) Chrome/120.0.6099.216 Safari/605.1.15" "1729029614.331581 0.109805 0.000434 0.004026 0.215927

- -1
- +11
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl
… 6 more files in changeset.

Tuesday 08 Oct

5:04 pm

antoniop

More
MAIN:antoniop:20241008150436
changed 8 files
MAIN

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

- -2
- +2
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl
… 7 more files in changeset.

Wednesday 11 Sep

8:11 am

gustafn

More
MAIN:gustafn:20240911061152
changed 1465 files
MAIN

merge with missing files

- -0
- +0
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl
… 1464 more files in changeset.

Tuesday 03 Sep

5:37 pm

gustafn

More
MAIN:gustafn:20240903153723
changed 8100 files
MAIN

merge from oacs-5-10

- -43
- +23
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl
… 8099 more files in changeset.

Saturday 26 Feb 2022

3:37 pm

gustafn

pass "hide methods" to svg generation

- -5
- +3
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl
… 1 more file in changeset.

Thursday 07 Oct 2021

1:06 pm

gustafn

reuse util::inline_svg_from_dot in show-object page

- -36
- +6
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl

Monday 04 Oct 2021

7:18 pm

gustafn

provide a for-free implementation of dot rendering

On sites with a large footprint, the fork might take a while, binging eveything to a hold

- -9
- +19
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl
… 1 more file in changeset.

4:22 pm

trenner

don't produce unused images

- -2
- +2
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl

Monday 02 Aug 2021

11:16 pm

gustafn

Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

- -9
- +7
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl
… 2 more files in changeset.

Saturday 08 Aug 2020

10:08 am

gustafn

improve spelling

- -2
- +2
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl
… 10 more files in changeset.

Wednesday 16 Oct 2019

12:24 pm

gustafn

impreve robustness of ad_doc parsing

- -2
- +6
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl

Friday 09 Aug 2019

9:45 pm

gustafn

improve spelling

- -2
- +2
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl
… 15 more files in changeset.

Sunday 10 Mar 2019

10:01 pm

gustafn

improve spelling

- -2
- +2
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl
… 8 more files in changeset.

Friday 01 Mar 2019

11:00 am

antoniop

Replace ad_decode idiom

- -2
- +2
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl
… 4 more files in changeset.

Sunday 09 Sep 2018

3:11 pm

gustafn

More
MAIN:gustafn:20180909131139
changed 1 file
MAIN

white-space cleanup

- -12
- +12
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl

3:10 pm

gustafn

More
MAIN:gustafn:20180909131055
changed 1 file
MAIN

improve robustness of output, when dot fails to produce output

- -2
- +7
./show-object.tcl
- History
- Source
- Diff
./show-object.tcl

Wednesday 09 May 2018

5:33 pm

hectorr

More
MAIN:hectorr:20180509153328
changed 476 files
MAIN

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).