• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reduce duplication:

index and update_index were in fact implementing a upsert logic. Modern sql allows to write this in a single query and merge the two apis into one. Replace reference in the service contracts as well.

    • -18
    • +17
    ./tsearch2-driver-procs-postgresql.xql
  1. … 2 more files in changeset.
reduce public footprint

Add 'index_unindex' test case, covering 'tsearch2::index', 'tsearch2::unindex' and 'tsearch2::update_index' procs

Test explicitely 'tsearch2::build_query_tcl', now that 'tsearch2::build_query' uses different methods yielding different results, and slight refactoring of the test, using 'aa_equals' instead of 'aa_true' for string comparison

    • -36
    • +31
    ./test/tsearch2-driver-procs.tcl
Add simple test case for 'tsearch2::summary'

Add trivial test case for 'tsearch2::driver_info'

Whitespace changes

    • -70
    • +69
    ./test/tsearch2-driver-procs.tcl
Add categories to build_query test case

do not rely on xo::dc in packages not depending on xotcl-core

Add PostgreSQL integrated websearch_to_tsquery builder, which can be activated via PackageParameter UseWebSearch

  1. … 1 more file in changeset.
file tsearch2-driver-init.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tsearch2-driver-init.tcl
remove spurious parens

    • -1
    • +1
    ./tsearch2-driver-procs-postgresql.xql
improve SQL quoting

  1. … 4 more files in changeset.
Make sure object_id is still a valid acs_object by the time it gets to the indexer: it can happen that objects meant to be indexed are in fact short-lived (e.g. xowiki-based objects created, scheduled for indexing and deleted shortly after)

    • -4
    • +5
    ./tsearch2-driver-procs-postgresql.xql
added editor hints and white-space cleanup

  1. … 50 more files in changeset.
support 'AND' and 'OR' at the end of the search string + extend automated tests

Support uninstall/reinstall use case by implementing a uninstall callback getting rid of service contract implementations

    • -1
    • +10
    ./tsearch2-driver-install-procs.tcl
  1. … 1 more file in changeset.
prefer spelling "SQL" over "sql" in sentences

improve spelling

  1. … 3 more files in changeset.
Use "package defined" stored procedure instead of legacy nomenclature

    • -1
    • +1
    ./tsearch2-driver-procs-postgresql.xql
Relax cleanup of parenthesis: remove them only when they don't match, like it used to be in older versions of the code

Fixes automated tests (that were refreshed to latest syntax and labelled with the proc they are testing)

    • -44
    • +53
    ./test/tsearch2-driver-procs.tcl
remove obsolte comments

probably it was meant that packages can be passed in via "package_ids" parameter

whitespace cleanup

align callback implementation with definition

Removed obsolete @arch-tag

  1. … 24 more files in changeset.
Rework variable assigning loops (set -> lassign)

Whitesepace cleanup

    • -72
    • +76
    ./tsearch2-driver-install-procs.tcl
- make sure that length timitation of tsearch vector does not raise errors

- refactor code to avoid redundant logic

- bump version number to 5.10.0d2

  1. … 1 more file in changeset.
Since PostgreSQL 10 does not support the tsearch2 backword compatibility package anymore, make sure that OpenACS does not use the old names requiring this package.

    • -43
    • +0
    ./tsearch2-driver-procs-postgresql.xql