• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reduce duplication:

index and update_index were in fact implementing a upsert logic. Modern sql allows to write this in a single query and merge the two apis into one. Replace reference in the service contracts as well.

    • -2
    • +2
    ./tcl/tsearch2-driver-install-procs.tcl
    • -18
    • +17
    ./tcl/tsearch2-driver-procs-postgresql.xql
file upgrade-5.10.0d5-5.10.0d6.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d5-5.10.0d6.sql
reduce public footprint

    • -3
    • +3
    ./tcl/tsearch2-driver-install-procs.tcl
Add 'index_unindex' test case, covering 'tsearch2::index', 'tsearch2::unindex' and 'tsearch2::update_index' procs

    • -1
    • +92
    ./tcl/test/tsearch2-driver-procs.tcl
Test explicitely 'tsearch2::build_query_tcl', now that 'tsearch2::build_query' uses different methods yielding different results, and slight refactoring of the test, using 'aa_equals' instead of 'aa_true' for string comparison

    • -36
    • +31
    ./tcl/test/tsearch2-driver-procs.tcl
Add simple test case for 'tsearch2::summary'

    • -1
    • +16
    ./tcl/test/tsearch2-driver-procs.tcl
Add trivial test case for 'tsearch2::driver_info'

    • -1
    • +16
    ./tcl/test/tsearch2-driver-procs.tcl
Whitespace changes

    • -70
    • +69
    ./tcl/test/tsearch2-driver-procs.tcl
Add categories to build_query test case

do not rely on xo::dc in packages not depending on xotcl-core

Add PostgreSQL integrated websearch_to_tsquery builder, which can be activated via PackageParameter UseWebSearch

file tsearch2-driver-init.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/tsearch2-driver-init.tcl
remove spurious parens

    • -1
    • +1
    ./tcl/tsearch2-driver-procs-postgresql.xql
improve SQL quoting

  1. … 3 more files in changeset.
Make sure object_id is still a valid acs_object by the time it gets to the indexer: it can happen that objects meant to be indexed are in fact short-lived (e.g. xowiki-based objects created, scheduled for indexing and deleted shortly after)

    • -4
    • +5
    ./tcl/tsearch2-driver-procs-postgresql.xql
added editor hints and white-space cleanup

  1. … 50 more files in changeset.
support 'AND' and 'OR' at the end of the search string + extend automated tests

    • -1
    • +17
    ./tcl/test/tsearch2-driver-procs.tcl
Support uninstall/reinstall use case by implementing a uninstall callback getting rid of service contract implementations

    • -1
    • +10
    ./tcl/tsearch2-driver-install-procs.tcl
prefer spelling "SQL" over "sql" in sentences

    • -2
    • +2
    ./tcl/tsearch2-driver-install-procs.tcl
improve spelling

  1. … 3 more files in changeset.
Use "package defined" stored procedure instead of legacy nomenclature

    • -1
    • +1
    ./tcl/tsearch2-driver-procs-postgresql.xql
Relax cleanup of parenthesis: remove them only when they don't match, like it used to be in older versions of the code

Fixes automated tests (that were refreshed to latest syntax and labelled with the proc they are testing)

    • -44
    • +53
    ./tcl/test/tsearch2-driver-procs.tcl
remove obsolte comments

probably it was meant that packages can be passed in via "package_ids" parameter

whitespace cleanup

align callback implementation with definition

Removed obsolete @arch-tag

    • -2
    • +1
    ./sql/postgresql/tsearch2-driver-drop.sql
  1. … 24 more files in changeset.
Removed obsolete @arch-tag

    • -2
    • +1
    ./tcl/tsearch2-driver-install-procs.tcl
  1. … 23 more files in changeset.
improve spelling

  1. … 8 more files in changeset.
Rework variable assigning loops (set -> lassign)