OpenACS / openacs-4 / packages

notifications

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 44
Last Commit: 13:32
Commits this week: 0
Total Lines of Code (LoC): 10,059
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 52 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 08 Oct
4:59 pm

antoniop

Prefer unset to array unset when we do not need a pattern match

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -5
    • +3
    ./tcl/notification-procs.tcl
Wednesday 11 Sep
8:11 am

gustafn

merge with missing files

Options
    • -0
    • +0
    ./sql/oracle/notifications-core-create.sql
    • -0
    • +0
    ./sql/postgresql/notifications-core-create.sql
    • -0
    • +0
    ./tcl/apm-callback-procs.tcl
    • -0
    • +0
    ./tcl/delivery-method-procs.tcl
    • -0
    • +0
    ./tcl/notification-callback-procs.tcl
    • -0
    • +0
    ./tcl/notification-display-procs.tcl
    • -0
    • +0
    ./tcl/notification-email-procs.tcl
    • -0
    • +0
    ./tcl/notification-procs.tcl
    • -0
    • +0
    ./tcl/notification-reply-procs.tcl
    • -0
    • +0
    ./tcl/notification-request-procs.tcl
    • -0
    • +0
    ./tcl/notification-type-procs.tcl
    • -0
    • +0
    ./tcl/notifications-security-procs.tcl
    • -0
    • +0
    ./tcl/reply-sweep-init.tcl
    • -0
    • +0
    ./tcl/reply-sweep-procs.tcl
    • -0
    • +0
    ./tcl/sweep-init.tcl
  16. … 1450 more files in changeset.
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -6
    • +7
    ./notifications.info
    • -4
    • +6
    ./lib/notification-widget.adp
    • -14
    • +20
    ./lib/notification-widget.tcl
    • -2
    • +3
    ./sql/oracle/notifications-core-create.sql
    • -0
    • +5
    ./sql/oracle/upgrade/upgrade-5.10.0d4-5.10.0d5.sql
    • -1
    • +3
    ./sql/postgresql/notifications-core-create.sql
    • -0
    • +5
    ./sql/postgresql/upgrade/upgrade-5.10.0d4-5.10.0d5.sql
    • -0
    • +8
    ./sql/postgresql/upgrade/upgrade-5.10.0d6-5.10.0d7.sql
    • -25
    • +25
    ./tcl/apm-callback-procs.tcl
    • -9
    • +10
    ./tcl/delivery-method-procs.tcl
    • -12
    • +26
    ./tcl/notification-callback-procs.tcl
    • -10
    • +0
    ./tcl/notification-callback-procs.xql
    • -13
    • +16
    ./tcl/notification-display-procs.tcl
    • -12
    • +25
    ./tcl/notification-email-procs.tcl
    • -15
    • +30
    ./tcl/notification-procs.tcl
  16. … 8085 more files in changeset.
Monday 02 Sep
2:54 pm

gustafn

bumped version number from development version to release version

Options
    • -6
    • +6
    ./notifications.info
  2. … 93 more files in changeset.
Wednesday 28 Aug
11:22 am

gustafn

silence regression test warning

Provide a script name for ad_proc

Options
    • -0
    • +13
    ./tcl/test/notifications-test-procs.tcl
8:34 am

gustafn

simplified exception handling by factoring out redundant code

make use of "ad_unless_script_abort"

Options
    • -1
    • +1
    ./notifications.info
    • -9
    • +13
    ./tcl/notifications-security-procs.tcl
    • -18
    • +15
    ./tcl/test/notifications-test-procs.tcl
Tuesday 27 Aug
8:08 pm

gustafn

handle script abort in proc handler

Options
    • -8
    • +19
    ./tcl/test/notifications-test-procs.tcl
Monday 15 Jul
2:04 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./tcl/notification-email-procs.tcl
  2. … 14 more files in changeset.
Wednesday 09 Aug 2023
2:03 pm

antoniop

Harden page contract

Options
    • -4
    • +4
    ./lib/notification-widget.tcl
1:50 pm

antoniop

Whitespace changes

Options
    • -5
    • +14
    ./lib/notification-widget.tcl
1:34 pm

antoniop

Cleanup obsolete variable

Options
    • -2
    • +0
    ./lib/notification-widget.tcl
1:03 pm

antoniop

Use adp:icon feature to generate a style-aware icon on every theme

Options
    • -4
    • +6
    ./lib/notification-widget.adp
    • -2
    • +0
    ./lib/notification-widget.tcl
Thursday 13 Jul 2023
3:09 pm

gustafn

bumped version numbers to 5.10.1b1

Options
    • -6
    • +6
    ./notifications.info
  2. … 85 more files in changeset.
Monday 10 Jul 2023
11:38 am

gustafn

improved spelling

Options
    • -2
    • +2
    ./tcl/notification-callback-procs.tcl
  2. … 7 more files in changeset.
Monday 27 Mar 2023
2:20 pm

trenner

put the notification creation in a db_transaction to ensure same subscription is created only once (e.g. double-clicks)

Options
    • -8
    • +10
    ./www/request-new.tcl
Friday 24 Feb 2023
10:56 am

antoniop

Harden page contract

Options
    • -2
    • +2
    ./www/request-delete.tcl
Thursday 23 Feb 2023
5:24 pm

antoniop

Harden page contract

Options
    • -3
    • +3
    ./www/object-goto.tcl
Sunday 27 Nov 2022
7:18 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./tcl/notification-email-procs.tcl
  2. … 5 more files in changeset.
Tuesday 01 Nov 2022
5:15 pm

gustafn

prefer usage of parameter::get_from_package_key over plain parameter::get

Options
    • -4
    • +5
    ./tcl/reply-sweep-init.tcl
    • -4
    • +5
    ./tcl/sweep-init.tcl
Thursday 13 Oct 2022
12:54 pm

gustafn

Fix incorrect HTTP status code on result page

The command "ad_return_error" returns HTTP status code 500 (internal server error).

In this script, this status code was returned in cases, where no notifications

were found for an object. "ad_return_exception_page" is better suited for such

cases.

Options
    • -2
    • +2
    ./www/subscribers.tcl
Tuesday 23 Aug 2022
8:44 pm

gustafn

Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

Options
    • -10
    • +18
    ./tcl/notification-callback-procs.tcl
  2. … 13 more files in changeset.
Tuesday 12 Jul 2022
4:16 pm

antoniop

Whitespace cleanup

Options
    • -11
    • +11
    ./tcl/notification-type-procs.tcl
4:15 pm

antoniop

Use quicker idiom to check for existance

Options
    • -2
    • +7
    ./tcl/notification-request-procs.tcl
    • -9
    • +0
    ./tcl/notification-request-procs.xql
4:05 pm

antoniop

Whitespace cleanup

Options
    • -3
    • +3
    ./tcl/notification-display-procs.tcl
    • -3
    • +3
    ./tcl/notification-reply-procs.tcl
4:02 pm

antoniop

Whitespace changes

Options
    • -3
    • +3
    ./tcl/delivery-method-procs.tcl
1:30 pm

antoniop

Prefer api to retrieve the approval state of a user

Options
    • -2
    • +2
    ./tcl/notifications-security-procs.tcl
    • -14
    • +0
    ./tcl/notifications-security-procs.xql
Monday 11 Jul 2022
5:50 pm

antoniop

Complete coverage for the notification package

Options
    • -0
    • +247
    ./tcl/test/notifications-test-procs.tcl
5:09 pm

antoniop

Brutally delete the notification requests before deleting the delivery method (it's fine because it will be rolled back)

Options
    • -0
    • +1
    ./tcl/test/notifications-test-procs.tcl
2:56 pm

antoniop

Fix issue in the query logics: we actually want to check the owner of the request, there might be multiple requests associated to the same object

Options
    • -6
    • +6
    ./tcl/notifications-security-procs.tcl
    • -1
    • +10
    ./tcl/test/notifications-test-procs.tcl
2:49 pm

antoniop

Extend coverage, this will expose an api bug

Options
    • -0
    • +179
    ./tcl/test/notifications-test-procs.tcl