• last updated 22 hours ago
Constraints: committers
Constraints: files
Constraints: dates
put the notification creation in a db_transaction to ensure same subscription is created only once (e.g. double-clicks)

Harden page contract

Harden page contract

Fix incorrect HTTP status code on result page

The command "ad_return_error" returns HTTP status code 500 (internal server error).

In this script, this status code was returned in cases, where no notifications

were found for an object. "ad_return_exception_page" is better suited for such


Whitespace changes

Fix proc signature

  1. … 7 more files in changeset.
Replace leftover occurrences

  1. … 1 more file in changeset.
Deprecate notification::get_delivery_method_id, same as notification::delivery::get_id and looking more established

  1. … 7 more files in changeset.
Deprecate notification::get_interval_id, duplicated by notification::interval::get_id_from_name which appears to be more established

  1. … 5 more files in changeset.
improve input validation

Reduce divergency between oracle and postgres codebase

Cleanup leftover file

Remove attack surface

Check permissions when one accesses the script and also when one performs the actual unsubscribing operation

Harden safety: require login, do not let people outside the requester fiddle with the frequency

make clear from the user-interface that admin is managing the notifications of someone else

Use already existing message-key.

Reduce divergency between oracle and postgres

  1. … 3 more files in changeset.
improve spelling

  1. … 10 more files in changeset.
Add ad_page_contract to pages (fixes automated tests)

whitespace changes

Whitespace changes

  1. … 1 more file in changeset.
Localize notification subscribers and bump version number

  1. … 4 more files in changeset.
allow passing of pretty_names that contain content including less and greater sign

  1. … 2 more files in changeset.
Undeprecate and reimplement: require_admin_request, can_admin_request_p, require_notify_object and can_notify_object_p. Fixes in two templates (request-delete, request-change-frequency). (Many thanks to Felix Mödritscher for the patch!)

  1. … 2 more files in changeset.
Port a few downstream modifications to the main codebase

When changing notification frequency, show also name and creation date for the object

Driver is making easier to merge this script

Trim whitespace

Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

  1. … 368 more files in changeset.
Prefer 'person::name' to 'acs_user::get_element ... -name'

  1. … 8 more files in changeset.
Prefer again 'person::name', as the proc has been reimplemented using 'person::get_person_info', which uses the new 'person_info_cache' cache.

  1. … 13 more files in changeset.