OpenACS / openacs-4 / packages

forums

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 61
Last Commit: 25 Nov
Commits this week: 0
Total Lines of Code (LoC): 22,611
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 Jul 2019
4:49 pm

hectorr

Remove form debug code

Options
    • -15
    • +1
    ./lib/message/post.tcl
4:48 pm

hectorr

Forum attachments reform.

- Add new style of attachments to the forums, allowing multiple attachments to a single message directly from the message post page, using the multiple file input widget.

- Retain compatibility with old style attachments, using the new 'AttachmentStyle' package instance parameter. Currently, this supports two values: 'simple' (new behavior) and 'complex' previous behavior.

- Both attachment styles can coexist, and attachments added by any of such methods will be shown.

- Improve the contract on 'forums/lib/message/post.tcl'.

- Show attachments on message preview.

- Bump version number.

Options
    • -2
    • +3
    ./forums.info
    • -2
    • +1
    ./lib/message/post-confirm.adp
    • -26
    • +196
    ./lib/message/post.tcl
    • -1
    • +10
    ./lib/message/row.adp
    • -2
    • +3
    ./lib/message/row.tcl
Friday 12 Jul 2019
6:00 pm

hectorr

Add 'alt_template' to include contract

Options
    • -2
    • +3
    ./lib/message/attachment-list.tcl
5:57 pm

hectorr

Add include contract and 'preview' view to the attachment list

Options
    • -3
    • +8
    ./lib/message/attachment-list.adp
    • -11
    • +7
    ./lib/message/attachment-list.tcl
5:29 pm

hectorr

Require admin privileges for attachment deletion in the forum, the same as for message editing

Options
    • -2
    • +4
    ./lib/message/attachment-list.tcl
4:37 pm

hectorr

Put the delete link to the right of the attachment

Options
    • -1
    • +1
    ./lib/message/attachment-list.adp
3:00 pm

hectorr

Add the 'detach' option on the attachment list, for users with write permissions on the message

Options
    • -1
    • +6
    ./lib/message/attachment-list.adp
    • -4
    • +15
    ./lib/message/attachment-list.tcl
2:59 pm

hectorr

Center icons on attachment list

Options
    • -0
    • +4
    ./www/resources/forums.css
Thursday 11 Jul 2019
7:01 pm

hectorr

Generalize attachment size logic in forum posts, so different object types, such as 'content_item', 'content_revision', and their subtypes, are supported

Options
    • -15
    • +33
    ./lib/message/attachment-list.tcl
Monday 01 Jul 2019
4:47 pm

hectorr

Move 'util::content_size_pretty' into 'acs-lang' and rename it to 'lc_content_size_pretty', localicing 'bytes' and adapting automated tests. Bump 'acs-lang' version.

Options
    • -2
    • +2
    ./lib/message/attachment-list.tcl
  2. … 41 more files in changeset.
Tuesday 25 Jun 2019
4:33 pm

hectorr

Improve content_type detection on forum attachments, and avoid redirecting to external hosts on URLs

Options
    • -4
    • +12
    ./lib/message/attachment-list.tcl
4:15 pm

hectorr

Url attachments in forums: use URL icon and avoid showing the size

Options
    • -1
    • +1
    ./lib/message/attachment-list.adp
    • -4
    • +15
    ./lib/message/attachment-list.tcl
3:06 pm

hectorr

Show attachment size in forum messages

Options
    • -1
    • +1
    ./lib/message/attachment-list.adp
    • -3
    • +7
    ./lib/message/attachment-list.tcl
Friday 21 Jun 2019
7:16 pm

hectorr

Whitespace changes

Options
    • -14
    • +14
    ./www/resources/forums.css
6:36 pm

hectorr

Use the attachment icon, available since 10+ years, for forums attachments.

Options
    • -1
    • +1
    ./lib/message/attachment-list.adp
    • -1
    • +0
    ./lib/message/row.adp
    • -0
    • +5
    ./www/resources/forums.css
Wednesday 19 Jun 2019
7:30 pm

hectorr

Use same capitalization policy as other message keys in the same form. Bump version to reload message keys.

Options
    • -2
    • +2
    ./forums.info
    • -1
    • +1
    ./catalog/forums.en_US.ISO-8859-1.xml
7:26 pm

hectorr

Only show the possibility to allow/disallow attachments in the forum new/edit pages if the attachments package is already mounted under the forums package instance

Options
    • -4
    • +17
    ./lib/forums/edit.tcl
    • -3
    • +16
    ./lib/forums/new.tcl
    • -5
    • +7
    ./tcl/form-procs.tcl
6:52 pm

antoniop

Update italian localization

Options
    • -1
    • +2
    ./catalog/forums.it_IT.ISO-8859-1.xml
  2. … 1 more file in changeset.
6:43 pm

hectorr

Whitespace changes

Options
    • -3
    • +3
    ./lib/forums/edit.tcl
    • -3
    • +3
    ./lib/forums/new.tcl
    • -12
    • +12
    ./tcl/form-procs.tcl
    • -2
    • +2
    ./tcl/forums-procs.xql
6:41 pm

hectorr

Modify user interface to allow/disallow attachments per forum, on forum creation and editing. Added message keys and bumped version as well.

Options
    • -2
    • +2
    ./forums.info
    • -1
    • +2
    ./catalog/forums.de_DE.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/forums.en_US.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/forums.es_ES.ISO-8859-1.xml
    • -3
    • +6
    ./lib/forums/edit.tcl
    • -3
    • +5
    ./lib/forums/new.tcl
    • -0
    • +6
    ./tcl/form-procs.tcl
    • -3
    • +6
    ./tcl/forums-procs.tcl
    • -2
    • +3
    ./tcl/forums-procs.xql
6:00 pm

hectorr

Cleanup trailing whitespace

Options
    • -5
    • +5
    ./lib/message/thread-chunk.tcl
5:59 pm

hectorr

Extend 'forum::attachments_enabled_p' with 'forum_id', so attachments ca be enabled per forum (see previous commit), and update underliying logic to make use of it.

Options
    • -2
    • +2
    ./lib/message/thread-chunk.tcl
    • -2
    • +19
    ./tcl/forums-procs.tcl
    • -3
    • +5
    ./www/message-post.tcl
Tuesday 18 Jun 2019
8:38 pm

hectorr

Add column 'attachments_allowed_p' to 'forums_forums', to be used to allow/disallow attachments on a per forum basis. Currently, the attachment logic is package instance wise, so if the forums instance has an attachment instance mounted below, then attachments are assumed to be enabled for all forums in that package instance. The idea with this change is to check for both the attachments instance mounted under a particular forum instance, and the 'attachments_allowed_p' column on 'forums_forums', to decide if attachments are enabled or not (both should be true). Next step would be to rewrite the logic to achieve that.

Options
    • -5
    • +5
    ./forums.info
    • -0
    • +6
    ./sql/oracle/forums-forums-create.sql
    • -0
    • +15
    ./sql/oracle/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
    • -1
    • +4
    ./sql/postgresql/forums-forums-create.sql
    • -0
    • +10
    ./sql/postgresql/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
8:38 pm

hectorr

file upgrade-1.3.1d12-1.3.1d13.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
Wednesday 10 Apr 2019
10:50 am

antoniop

Initialize d variable

Options
    • -1
    • +3
    ./tcl/test/webtest-procs.tcl
10:50 am

antoniop

Fix call parameters

Options
    • -3
    • +1
    ./tcl/test/forums-procs.tcl
Tuesday 09 Apr 2019
4:33 pm

gustafn

- prefer "last_request" over "user_id" in automated tests

- make web test more robust against local language dependencies

Options
    • -3
    • +3
    ./forums.info
    • -7
    • +13
    ./tcl/test/forums-procs.tcl
    • -30
    • +30
    ./tcl/test/webtest-procs.tcl
Saturday 30 Mar 2019
8:46 pm

gustafn

avoid double substitutions

Options
    • -5
    • +4
    ./tcl/messages-procs.tcl
  2. … 2 more files in changeset.
Friday 22 Mar 2019
1:56 pm

antoniop

Sign url vars when deleting forum message in the test

Options
    • -1
    • +2
    ./tcl/test/webtest-procs.tcl
Thursday 21 Mar 2019
4:58 pm

antoniop

Export message keys from the UI to make is easier to apply changes without creating big diffs

Options
    • -2
    • +2
    ./forums.info
    • -4
    • +4
    ./catalog/forums.de_DE.ISO-8859-1.xml
    • -9
    • +9
    ./catalog/forums.en_US.ISO-8859-1.xml