OpenACS / openacs-4 / packages / forums

www

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 34
Last Commit:
Commits this week: 0
Total Lines of Code (LoC): 4,161
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 30 Aug
3:08 pm

antoniop

Reinstate the notnull validation constraint where missing

Options
    • -1
    • +1
    ./forum-view-statistic.tcl
    • -2
    • +2
    ./forum-view.tcl
    • -1
    • +1
    ./load-message-content.tcl
    • -1
    • +1
    ./mark-all-read.tcl
    • -2
    • +2
    ./message-email.tcl
    • -2
    • +2
    ./user-history.tcl
    • -2
    • +2
    ./admin/forum-disable.tcl
    • -2
    • +2
    ./admin/forum-edit.tcl
    • -2
    • +2
    ./admin/forum-enable.tcl
    • -2
    • +2
    ./admin/permissions-user-add.tcl
    • -5
    • +5
    ./admin/subscribe-others-2.tcl
    • -2
    • +2
    ./admin/subscribe-others.tcl
    • -2
    • +2
    ./moderate/forum.tcl
    • -2
    • +2
    ./moderate/message-approve.tcl
    • -2
    • +2
    ./moderate/message-delete.tcl
  16. … 10 more files in changeset.
2:22 pm

gustafn

re-add notnull value constraint on message_id

This constraint was removed about 14 days ago. Without this constraint,

errors like the following will show up....

[30/Aug/2022:14:07:29.820625][3102633.7f152c28d700][-conn:openacs.org:default:0:196214-] Error: rp_handler no-script-abort: errorMsg can't read "message(forum_id)": no such variable while serving GE

T /forums/message-view?message_id HTTP/1.1

: ad_url </forums/message-view> maps to file </var/www/openacs.org/packages/forums/www/message-view.adp>

: TCL LOOKUP VARNAME message

: can't read "message(forum_id)": no such variable

: while executing

: "forum::get -forum_id $message(forum_id) -array forum"

Probably, in many more cases, the incorrect removal of the notnull constrain performed by [1]

requires the same fix.

[1] https://github.com/openacs/forums/commit/c403e3134ce4e73ba94a80540a8b0f3cb1651ed0#diff-d35c736495ede0174fb39791ab660c5cd1a4ca467db2c4741cfc935167d7e5a8

Options
    • -2
    • +2
    ./message-view.tcl
Friday 15 Jul
6:19 pm

antoniop

Harden page and include contracts using new acs-tcl feature

Options
    • -1
    • +1
    ./forum-view-statistic.tcl
    • -15
    • +6
    ./forum-view.tcl
    • -5
    • +1
    ./load-message-content.tcl
    • -1
    • +1
    ./mark-all-read.tcl
    • -10
    • +4
    ./message-email.tcl
    • -12
    • +7
    ./message-post.tcl
    • -10
    • +4
    ./message-view.tcl
    • -1
    • +1
    ./messages-get.tcl
    • -2
    • +2
    ./search.tcl
    • -8
    • +2
    ./user-history.tcl
    • -2
    • +2
    ./admin/forum-disable.tcl
    • -2
    • +2
    ./admin/forum-edit.tcl
    • -2
    • +2
    ./admin/forum-enable.tcl
    • -2
    • +2
    ./admin/permissions-user-add.tcl
    • -2
    • +2
    ./admin/permissions.tcl
  16. … 21 more files in changeset.
Wednesday 27 Apr
6:41 pm

gustafn

passing properties consistently with @....;literal@

Options
    • -1
    • +1
    ./message-email.adp
  2. … 12 more files in changeset.
6:30 pm

gustafn

passing properties consistently with @....;literal@

Options
    • -1
    • +1
    ./forum-view-statistic.adp
    • -1
    • +1
    ./message-email.adp
    • -1
    • +1
    ./message-post-confirm.adp
    • -1
    • +1
    ./message-post.adp
    • -1
    • +1
    ./admin/forum-edit.adp
    • -1
    • +1
    ./admin/subscribe-others.adp
    • -1
    • +1
    ./moderate/forum.adp
    • -1
    • +1
    ./moderate/message-delete.adp
    • -1
    • +1
    ./moderate/message-edit.adp
    • -1
    • +1
    ./moderate/message-move.adp
    • -1
    • +1
    ./moderate/thread-move-thread.adp
  12. … 43 more files in changeset.
2:22 pm

gustafn

passing properties consistently with @....;literal@ and not "noquote", since noquote content is already parsed

Options
    • -1
    • +1
    ./moderate/move-thread.adp
  2. … 14 more files in changeset.
Tuesday 12 Apr
2:27 pm

trenner

add validation for message_id

Options
    • -2
    • +10
    ./message-email.tcl
2:14 pm

trenner

add minimal permission check

Options
    • -0
    • +1
    ./messages-get.tcl
Tuesday 15 Mar
1:29 pm

trenner

harden page contract

Options
    • -2
    • +2
    ./user-history.tcl
Wednesday 29 Dec 2021
5:56 pm

antoniop

Trap the attempt to retrieve a non-existing forum and return a 404 in this case

this might need to happen in other places and/or be refined

Options
    • -2
    • +7
    ./admin/forum-edit.tcl
Sunday 14 Feb 2021
10:08 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./message-view.tcl
  2. … 4 more files in changeset.
Monday 08 Feb 2021
1:27 pm

antoniop

Reduce divergency between Oracle and Postgres codebase

Options
    • -16
    • +0
    ./mark-all-read-oracle.xql
    • -16
    • +0
    ./mark-all-read-postgresql.xql
    • -2
    • +16
    ./mark-all-read.tcl
Friday 23 Oct 2020
7:03 pm

gustafn

use bind variables instead of tcl variable substition in xql fullqueries

Options
    • -2
    • +2
    ./moderate/move-thread-oracle.xql
    • -2
    • +2
    ./moderate/move-thread-postgresql.xql
    • -2
    • +2
    ./moderate/move-thread.xql
  4. … 14 more files in changeset.
Saturday 26 Sep 2020
2:10 pm

gustafn

show notification controls only, when the request is not from a bot

Options
    • -17
    • +21
    ./forum-view.adp
    • -2
    • +4
    ./forum-view.tcl
    • -6
    • +9
    ./message-view.adp
    • -3
    • +6
    ./message-view.tcl
  5. … 1 more file in changeset.
Tuesday 01 Sep 2020
7:24 pm

antoniop

Improve sql portability

Options
    • -2
    • +4
    ./admin/subscribe-others-2.tcl
  2. … 6 more files in changeset.
5:19 pm

antoniop

Improve sql portability

Options
    • -4
    • +7
    ./admin/subscribe-others-2.tcl
Saturday 08 Aug 2020
1:19 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./user-history.tcl
  2. … 16 more files in changeset.
Wednesday 13 May 2020
4:31 pm

antoniop

Implement a new type of "Moderator" notification type for forums

This notification will be triggered also by unapproved messages. The UI will show the subscription link only to forum moderators, using a different color (customizable via css, vanilla color is red). Message content will always be hidden for such notifications, so user will need to have access to new message.

Options
    • -0
    • +7
    ./forum-view.adp
    • -1
    • +8
    ./forum-view.tcl
    • -1
    • +8
    ./message-view.adp
    • -1
    • +8
    ./message-view.tcl
    • -0
    • +8
    ./resources/forums.css
  6. … 3 more files in changeset.
10:00 am

antoniop

Make clear where paragraph ends

Options
    • -1
    • +1
    ./forum-view.adp
Sunday 09 Feb 2020
4:09 pm

gustafn

whitespace changes

Options
    • -5
    • +5
    ./forum-view.tcl
  2. … 2 more files in changeset.
9:11 am

gustafn

remove print.css and include its content in forums.css

Options
    • -2
    • +1
    ./forum-view.tcl
    • -2
    • +1
    ./message-view.tcl
    • -0
    • +34
    ./resources/forums.css
    • -28
    • +0
    ./resources/print.css
Saturday 05 Oct 2019
3:11 pm

gustafn

improve comments

Options
    • -4
    • +5
    ./message-post.tcl
  2. … 2 more files in changeset.
Friday 09 Aug 2019
10:19 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./resources/message-effects.js
  2. … 14 more files in changeset.
Friday 12 Jul 2019
2:59 pm

hectorr

Center icons on attachment list

Options
    • -0
    • +4
    ./resources/forums.css
Friday 21 Jun 2019
7:16 pm

hectorr

Whitespace changes

Options
    • -14
    • +14
    ./resources/forums.css
6:36 pm

hectorr

Use the attachment icon, available since 10+ years, for forums attachments.

Options
    • -0
    • +5
    ./resources/forums.css
  2. … 2 more files in changeset.
Wednesday 19 Jun 2019
5:59 pm

hectorr

Extend 'forum::attachments_enabled_p' with 'forum_id', so attachments ca be enabled per forum (see previous commit), and update underliying logic to make use of it.

Options
    • -3
    • +5
    ./message-post.tcl
  2. … 2 more files in changeset.
Sunday 10 Mar 2019
11:06 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./load-message-content.tcl
  2. … 8 more files in changeset.
Thursday 14 Feb 2019
4:00 pm

gustafn

Secure forums delete button by protecting the message_id with a timed signature

Options
    • -5
    • +6
    ./moderate/message-delete.tcl
  2. … 5 more files in changeset.
Monday 10 Dec 2018
9:55 am

gustafn

fix overquoting in notification-widget

Options
    • -1
    • +1
    ./forum-view.adp
    • -1
    • +1
    ./message-view.adp
  3. … 5 more files in changeset.