• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reinstate the notnull validation constraint where missing

  1. … 10 more files in changeset.
re-add notnull value constraint on message_id

This constraint was removed about 14 days ago. Without this constraint,

errors like the following will show up....

[30/Aug/2022:14:07:29.820625][3102633.7f152c28d700][-conn:openacs.org:default:0:196214-] Error: rp_handler no-script-abort: errorMsg can't read "message(forum_id)": no such variable while serving GE

T /forums/message-view?message_id HTTP/1.1

: ad_url </forums/message-view> maps to file </var/www/openacs.org/packages/forums/www/message-view.adp>

: TCL LOOKUP VARNAME message

: can't read "message(forum_id)": no such variable

: while executing

: "forum::get -forum_id $message(forum_id) -array forum"

Probably, in many more cases, the incorrect removal of the notnull constrain performed by [1]

requires the same fix.

[1] https://github.com/openacs/forums/commit/c403e3134ce4e73ba94a80540a8b0f3cb1651ed0#diff-d35c736495ede0174fb39791ab660c5cd1a4ca467db2c4741cfc935167d7e5a8

Harden page and include contracts using new acs-tcl feature

  1. … 21 more files in changeset.
passing properties consistently with @....;literal@

  1. … 12 more files in changeset.
passing properties consistently with @....;literal@

  1. … 43 more files in changeset.
passing properties consistently with @....;literal@ and not "noquote", since noquote content is already parsed

  1. … 14 more files in changeset.
add validation for message_id

add minimal permission check

harden page contract

Trap the attempt to retrieve a non-existing forum and return a 404 in this case

this might need to happen in other places and/or be refined

improve spelling

  1. … 4 more files in changeset.
Reduce divergency between Oracle and Postgres codebase

use bind variables instead of tcl variable substition in xql fullqueries

  1. … 14 more files in changeset.
show notification controls only, when the request is not from a bot

  1. … 1 more file in changeset.
Improve sql portability

  1. … 6 more files in changeset.
Improve sql portability

improve spelling

  1. … 16 more files in changeset.
Implement a new type of "Moderator" notification type for forums

This notification will be triggered also by unapproved messages. The UI will show the subscription link only to forum moderators, using a different color (customizable via css, vanilla color is red). Message content will always be hidden for such notifications, so user will need to have access to new message.

  1. … 3 more files in changeset.
Make clear where paragraph ends

whitespace changes

  1. … 2 more files in changeset.
remove print.css and include its content in forums.css

improve comments

  1. … 2 more files in changeset.
improve spelling

  1. … 14 more files in changeset.
Center icons on attachment list

Whitespace changes

Use the attachment icon, available since 10+ years, for forums attachments.

  1. … 2 more files in changeset.
Extend 'forum::attachments_enabled_p' with 'forum_id', so attachments ca be enabled per forum (see previous commit), and update underliying logic to make use of it.

  1. … 2 more files in changeset.
improve spelling

  1. … 8 more files in changeset.
Secure forums delete button by protecting the message_id with a timed signature

  1. … 5 more files in changeset.
fix overquoting in notification-widget

  1. … 5 more files in changeset.