OpenACS / openacs-4 / packages / forums

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 39
Last Commit: 25 Nov
Commits this week: 0
Total Lines of Code (LoC): 3,775
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 10 Jul 2018
1:34 pm

antoniop

Add documentation for public proc (fixes automated tests), feed user_id from arguments to permission api, explicitly default to current user (as called procs would do anyway)

Options
    • -3
    • +15
    ./forums-security-procs.tcl
12:36 pm

antoniop

Uniform documentation style, add documentation for public proc (fixes automated tests)

Options
    • -3
    • +5
    ./forum-reply-procs.tcl
12:32 pm

antoniop

Deprecate (former) service contract implementations

Their body was always empty according to the cvs history and there is no mention of them in the code.

Their counterpart in the forum::notification namespace takes care of both forums and messages, therefore supersedes them.

Options
    • -5
    • +15
    ./forum-message-reply-procs.tcl
12:20 pm

antoniop

Clearly separate callback hooks from callback implementations, uniform documentation style, remove duplicated callback implementation definitions, uniform indentation, add documentation to public procs (fixes automated tests)

Options
    • -155
    • +111
    ./forums-callback-procs.tcl
12:03 pm

antoniop

Add documentation to public procs (fixes automated tests)

Options
    • -9
    • +5
    ./forum-message-reply-procs.tcl
11:54 am

antoniop

Uniform documentation style

Options
    • -16
    • +16
    ./messages-procs.tcl
Monday 09 Jul 2018
2:31 pm

antoniop

Set package_id explicitly as the main subsite package, as ad_conn package_id could not be properly initialized for tests when a system was freshly restarted

Options
    • -5
    • +11
    ./test/forums-procs.tcl
11:20 am

antoniop

Put cache flushing logics into procs and use them when forum info needs to be updated (fixes automated tests)

Options
    • -2
    • +19
    ./forums-procs.tcl
    • -6
    • +16
    ./messages-procs.tcl
10:56 am

antoniop

Add documentation and a fallback body for this deprecated proc

Options
    • -2
    • +11
    ./forums-procs.tcl
Thursday 28 Jun 2018
5:27 pm

hectorr

Provide a minimal documentation to public procs

Options
    • -4
    • +18
    ./forums-procs.tcl
    • -1
    • +9
    ./forums-security-procs.tcl
    • -4
    • +6
    ./messages-procs.tcl
11:44 am

antoniop

Remove hotfix and exploit new api, that won't fail on the guest user

Options
    • -11
    • +5
    ./messages-procs.tcl
Monday 25 Jun 2018
11:26 am

antoniop

Fix regression when checking if user can anonimously post

Options
    • -2
    • +2
    ./forums-security-procs.tcl
11:15 am

antoniop

Fix regressions in forums when user is not logged in

Options
    • -5
    • +11
    ./messages-procs.tcl
  2. … 5 more files in changeset.
Monday 18 Jun 2018
4:22 pm

antoniop

Disambiguate table reference in subquery

Options
    • -13
    • +13
    ./messages-procs-oracle.xql
    • -13
    • +13
    ./messages-procs-postgresql.xql
Friday 15 Jun 2018
6:46 pm

antoniop

Use more api to streamline queries and reduce divergency between oracle and postgres codebase

Options
    • -22
    • +4
    ./messages-procs-oracle.xql
    • -28
    • +6
    ./messages-procs-postgresql.xql
    • -7
    • +22
    ./messages-procs.tcl
Tuesday 12 Jun 2018
12:04 am

gustafn

move template cacheing function "cache" into template namespace (resulting in template::cache)

Options
    • -2
    • +2
    ./forums-procs.tcl
  2. … 2 more files in changeset.
Monday 11 Jun 2018
4:04 pm

antoniop

Centralize templating cache "black magic"

Use the new proc into forum api

Options
    • -4
    • +21
    ./forums-procs.tcl
  2. … 1 more file in changeset.
Thursday 07 Jun 2018
8:08 pm

hectorr

Replace deprecated 'forum::security::can_moderate_forum_p' by 'permission::permission_p'

Options
    • -8
    • +16
    ./forums-security-procs.tcl
  2. … 2 more files in changeset.
7:53 pm

hectorr

Replace deprecated 'can_read_forum_p' by 'permission::permission_p'

Options
    • -3
    • +4
    ./forums-security-procs.tcl
6:52 pm

hectorr

Deprecate wrappers for 'permission::permission_p' and permission::require_permission.

Options
    • -11
    • +19
    ./forums-security-procs.tcl
  2. … 4 more files in changeset.
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -2
    • +2
    ./forums-sc-procs.tcl
  2. … 475 more files in changeset.
Monday 30 Apr 2018
11:07 am

gustafn

unify spelling of URL

Options
    • -3
    • +3
    ./forums-callback-procs.tcl
    • -2
    • +2
    ./forums-sc-procs.tcl
    • -1
    • +1
    ./test/tclwebtest-procs.tcl
  4. … 1 more file in changeset.
Wednesday 25 Apr 2018
9:47 pm

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -2
    • +2
    ./forums-sc-procs.tcl
  2. … 204 more files in changeset.
Thursday 19 Apr 2018
12:25 am

hectorr

Fix typos

Options
    • -7
    • +7
    ./messages-procs.tcl
  2. … 7 more files in changeset.
Wednesday 31 Jan 2018
9:25 pm

gustafn

fix typo

Options
    • -2
    • +2
    ./messages-procs.tcl
  2. … 1 more file in changeset.
Saturday 27 Jan 2018
6:01 pm

gustafn

delete unreferenced .xql queries

Options
    • -2
    • +2
    ./messages-procs.tcl
  2. … 1 more file in changeset.
Sunday 21 Jan 2018
12:16 am

gustafn

Make termination after connection closing commands explicit

Options
    • -2
    • +3
    ./messages-procs.tcl
  2. … 1 more file in changeset.
Thursday 16 Nov 2017
1:40 pm

antoniop

Make forum::use_ReadingInfo_p more robust when UseReadingInfo parameter in forums is not set

Options
    • -2
    • +2
    ./forums-procs.tcl
  2. … 3 more files in changeset.
Friday 10 Nov 2017
6:21 pm

antoniop

Maintenance of forum reading count feature

- removal of forums_reading_info_user (1Mio rows on Learn@WU).

This materialized view had to be constantly synced with

forums_reading_info table. Reimplemented as view.

- simplify logics in stored procedure due to new datamodel

- fix inconsistencies between oracle and postgres function definition

- re-enabled parameter to decide whether use these stats or not in

administration

TODO: consider further reform of this feature as stats grow very

large on busy sites for probably little value added

Options
    • -5
    • +2
    ./forums-procs.tcl
  2. … 8 more files in changeset.
Wednesday 08 Nov 2017
1:05 pm

antoniop

Implement post anonymously through explicit forum attribute in table

Now moderators can explicitly decide whether a forum will enable posting anonymously or not.

Forum must be in a policy different from closed and the anonymous flag must be set accordingly for this to happen.

Also:

- normalize api in a way it can accomodate all current attributes. In particular,

now edit api will now leave every unspecified attribute unchanged, instead of

setting it to some default.

- fix some usability issues when managing forum parameters (e.g. values not

retrieved in form when editing existing forum)

- introduce missing Oracle upgrade script for the whole forum reform

- fix oracle creation script

Options
    • -2
    • +8
    ./form-procs.tcl
    • -7
    • +27
    ./forums-procs.tcl
    • -8
    • +12
    ./forums-procs.xql
    • -9
    • +14
    ./forums-security-procs.tcl
  5. … 7 more files in changeset.