• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Uniform documentation style

Set package_id explicitly as the main subsite package, as ad_conn package_id could not be properly initialized for tests when a system was freshly restarted

Put cache flushing logics into procs and use them when forum info needs to be updated (fixes automated tests)

Add documentation and a fallback body for this deprecated proc

Provide a minimal documentation to public procs

Remove hotfix and exploit new api, that won't fail on the guest user

Fix regression when checking if user can anonimously post

Fix regressions in forums when user is not logged in

  1. … 5 more files in changeset.
Disambiguate table reference in subquery

Use more api to streamline queries and reduce divergency between oracle and postgres codebase

move template cacheing function "cache" into template namespace (resulting in template::cache)

  1. … 2 more files in changeset.
Centralize templating cache "black magic"

Use the new proc into forum api

  1. … 1 more file in changeset.
Replace deprecated 'forum::security::can_moderate_forum_p' by 'permission::permission_p'

  1. … 2 more files in changeset.
Replace deprecated 'can_read_forum_p' by 'permission::permission_p'

Deprecate wrappers for 'permission::permission_p' and permission::require_permission.

  1. … 4 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
unify spelling of URL

  1. … 1 more file in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 204 more files in changeset.
Fix typos

  1. … 7 more files in changeset.
fix typo

  1. … 1 more file in changeset.
delete unreferenced .xql queries

  1. … 1 more file in changeset.
Make termination after connection closing commands explicit

  1. … 1 more file in changeset.
Make forum::use_ReadingInfo_p more robust when UseReadingInfo parameter in forums is not set

  1. … 3 more files in changeset.
Maintenance of forum reading count feature

- removal of forums_reading_info_user (1Mio rows on Learn@WU).

This materialized view had to be constantly synced with

forums_reading_info table. Reimplemented as view.

- simplify logics in stored procedure due to new datamodel

- fix inconsistencies between oracle and postgres function definition

- re-enabled parameter to decide whether use these stats or not in

administration

TODO: consider further reform of this feature as stats grow very

large on busy sites for probably little value added

  1. … 8 more files in changeset.
Implement post anonymously through explicit forum attribute in table

Now moderators can explicitly decide whether a forum will enable posting anonymously or not.

Forum must be in a policy different from closed and the anonymous flag must be set accordingly for this to happen.

Also:

- normalize api in a way it can accomodate all current attributes. In particular,

now edit api will now leave every unspecified attribute unchanged, instead of

setting it to some default.

- fix some usability issues when managing forum parameters (e.g. values not

retrieved in form when editing existing forum)

- introduce missing Oracle upgrade script for the whole forum reform

- fix oracle creation script

  1. … 7 more files in changeset.
Assume moderators have always the right to post

Fix typo in deprecated proc (not used upstream anymore)

reuse forum properties

Forum reform

- remove hardcoded dependency with registered_users group. Target is to improve suitability in convoluted multi groups/multi subsites context

- in place of previous permission-based machinery, use plain table columns to detect whether user can or cannot post replies/new threads

- remove permission check at the message level in favor of that on forum level

  1. … 20 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7821 more files in changeset.