• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
add check before file moving to avoid violation of 'cr_items_unique_name' constraint

Fixed a seemingly 11 years old bug

- Introduce new proc ad_sanitize_filename implementing current best practices for ensuring a valid filename on most filesystems.

- Use it in every place where filename sanitization is performed in the code and deprecate fs::remove_special_file_system_characters.

TODO deprecate also util_text_to_html? Use case of sanitizing urls and filenames might have different requirements.

  1. … 4 more files in changeset.
Fix typo

Check if we have already a folder with same name before inserting, or we get error in the logs.

Remove small duplication

Prevent user from selecting source folder as destination folder when moving files. Localize feedback messages (thanks to Markus Moser for the germen translation)

  1. … 3 more files in changeset.
Remove debugging comment

Use name and title for the copy, rather than name as title and file_upload_name as name. This will make so copied files will have also the same title as the original when this was renamed.

Try conserving file extension in the name when adding the suffix

Localize untranslated messages in the copy file-storage script (thanks to Markus Moser for the german translation)

  1. … 3 more files in changeset.
Use a lazy but feasible check to decide if we have buttons for copy in the file storage

Fix hiding of delete and move buttons. For move I resolved using the

delete permission as a criteria, because otherwise one should ensure

also the availability of a suitable destination, which must be writable

and in none of the object's subtrees. Complicated and costly to execute everytime.

Fix spelling errors

  1. … 9 more files in changeset.
Allow copy of files/folders into the same folder of the original content. This is done by appending a numerical suffix to the name.

It required modifying copy stored procedures so they could accept a different name and title for the copy.

I have also removed redundant package definition in oracle code that was immediately overridden afterwards.

  1. … 10 more files in changeset.
Add move and copy buttons only when available folders for these actions exist

Hide file-storage actions that are not allowed for the user. (receives analogous modifications on Learn@WU)

Use standard file-storage delete api, as extlink one seems to require extra sql stored procedures (which don't seem necessary to me)

Improve robustness of "file delete" operations

  1. … 16 more files in changeset.
- replace "<include ... />" by "<include ... >", since adp parser in

AOLserver and NaviServer passes "/" as argument to the adp-include.

  1. … 14 more files in changeset.
- tighten page contracts

  1. … 2 more files in changeset.
- make boolean tests in .adp files more uniform

  1. … 1 more file in changeset.
Some more Tcl cleanup

- use curly brackes to enable byte code compilation

- don't use "[expr ...]" when not needed

- prefer "incr i -1" over "set i [expr {$i - 1}] "

  1. … 15 more files in changeset.
- remove dead code: form n_past_days_form is nowhere used, probably some legacy

- provide image dimensions

  1. … 2 more files in changeset.
- use confirm handler instead of "onclick=..." in all packages in oacs-5-9

  1. … 15 more files in changeset.
- use event listener instead of onclick handler

- hint based on "fs_title_msg" is probably not shown since many years.

- modernize HTML

  1. … 21 more files in changeset.
- modernize HTML of documentation

  1. … 10 more files in changeset.
- reduce dependencies on acs_object_party_privilege_map (for PostgreSQL)

- use entities for quotes

- updated version numbers, regenerated documentation

  1. … 297 more files in changeset.