• last updated 7 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Improve zip file download solution: instead of a link to be clicked, stay closer to previous implementation and trigger the download automatically by including an invisible iframe pointing to the file in the user message

  1. … 4 more files in changeset.
file download-zip-2.tcl was initially added on branch oacs-5-10.

Implement a simple "progress-bar" interaction when one downloads a zip file:

file is generated while the progress bar is running and the download link is generated and served to the user as part of a util_user_message

  1. … 4 more files in changeset.
Move operations so that they are closer to their computation's actual usage

We are only interested in the side effects of this computation

Break overlong line

Take more advantage of exception handling

Simplify determining outfile destination

Fix english of query name

Check objects ids all in one query, before any further action is taken

Do not localize the file name: it is not expected that message keys are expanded here as we do for the file title

Port sanitizing of upload file name from downstream

use util::unzip instead of plain "exec unzip" commands

  1. … 3 more files in changeset.
Make oacs-dav only a weak dependency for file-storage, if the package is not there, just treat it as if the parameter was disabled

  1. … 2 more files in changeset.
improve spelling

  1. … 3 more files in changeset.
whitespace changes

  1. … 2 more files in changeset.
extend regression test, add covered procs to webtest

  1. … 2 more files in changeset.
Whitespace changes

Use the new 'url' input type

Whitespace changes

Refactoring of the upload-size-limit admin page of the file-storage. Sets a default value of 2GB when no maxinput is found in the config file, and uses the new 'number' ad_form widget. Bump version for the widget dependency

  1. … 1 more file in changeset.
Fix typo

Do not allow backslashes in folders created via zipfile upload

As the folder name is used also for looking up for existing folders, the safest approach is to block the user: the risk with an automatic sanitization would be to overwrite existing folders without the user realizing

make end of options explicit

  1. … 16 more files in changeset.
improve robustness in case parameter is not (yet) set

  1. … 3 more files in changeset.
Whitespace changes

Disable RSS offering in file-storage if the RSS generation service is disabled in rss-support. Bump version numbers and fix dependencies, as the RssGenActiveP parameter is only available in latest rss-support.

  1. … 1 more file in changeset.
Improve sql portability

  1. … 6 more files in changeset.
use "ad_file" as a means to avoid unexpected tilde substitution in file names

  1. … 7 more files in changeset.
Deprecate with_finally and with_catch, superseded by e.g. try idioms in tcl 8.6

They would also not comply with OpenACS naming convention

  1. … 4 more files in changeset.