Activity OpenACS/openacs-4/packages/file-storage/tcl/test

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	11
Last Commit:	12:10
Commits this week:	0
Total Lines of Code (LoC):	1,636
Net change in LoC this week:	0

Commit Activity

last updated 5 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Tuesday 27 Aug

4:27 pm

gustafn

silence expected errors during regression test

- -10
- +16
./file-storage-procs.tcl
- History
- Source
- Diff
./file-storage-procs.tcl

Tuesday 20 Aug

3:10 pm

gustafn

made regression test more robust

The test was failing, when the preferred language in the browser

was not "en". The test is now slightly better, but one should

use CSS classes (or data attributes) to pick the bulk actions

- -5
- +26
./webtest-procs.tcl
- History
- Source
- Diff
./webtest-procs.tcl

Monday 22 Jul

4:00 pm

antoniop

Remove additional trapping of exception, which prevents the web agent to access the file-storage, if we had to mount it on the fly

- -30
- +30
./file-storage-procs.tcl
- History
- Source
- Diff
./file-storage-procs.tcl

Thursday 18 Jul

7:52 pm

gustafn

improved test coverage

- -2
- +5
./file-storage-procs.tcl
- History
- Source
- Diff
./file-storage-procs.tcl
… 1 more file in changeset.

Monday 26 Feb

4:05 pm

File-Storage used to generate downloaded archives in tgz format, to then switch to zip, more user-friendly, in particular outside the Linux world (See https://openacs.org/forums/message-view?message_id=557561). To ease the transition, a couple of parameters and relative API were introduced that would allow to choose the preferred command one should use. During this reform however, default parameter values in the tcl code became inconsistent with those in the info file. Furthermore, the chosen defaults were set as absolute paths to the executable, which is not friendly to non-linux environments, or other scenarios where the "typical" Linux filesystem structure cannot be assumed (e.g. containers, MacOS...).

The only usage of this parameters/api was in fact in the download-archive vuh. In upstream codebase, no package references this file, not even the file-storage itself. Upon review, one could see that the file would also allow to specify a custom download filename via the path, which could be considered questionable. It would also execute the command in a way that once again assumes some form of Linux environment (e.g. invoking bash).

Save for the ability to customize the archive format and the anti-feature of being able to manipulate the archive filename via the path, the script largely relplicates www/download-zip, in a better shape after a few reforms hinted by e.g. penetration tools.

Given the aformentioned considerations, I have decided to make download-archive a simple redirect to download-zip. Specifying the object_id via the path will keep working, while URLs out there expecting the name to change will not fail, but the name will not be modified. The archive format will from now on be assumed to be zip.

- -47
- +1
./file-storage-procs.tcl
- History
- Source
- Diff
./file-storage-procs.tcl
… 4 more files in changeset.

10:57 am

gustafn

Cleanup of external binaries: always use "util::which" to resolve binaries

- -3
- +3
./webtest-procs.tcl
- History
- Source
- Diff
./webtest-procs.tcl
… 5 more files in changeset.

Thursday 20 Apr 2023

4:47 pm

antoniop

Test external command dependency for the package

- -1
- +25
./file-storage-procs.tcl
- History
- Source
- Diff
./file-storage-procs.tcl

Friday 17 Mar 2023

3:43 pm

antoniop

Complete api coverage for the package

- -1
- +21
./file-storage-procs.tcl
- History
- Source
- Diff
./file-storage-procs.tcl

3:36 pm

antoniop

Cover remaining export api

- -15
- +129
./file-storage-procs.tcl
- History
- Source
- Diff
./file-storage-procs.tcl

2:25 pm

antoniop

Prevent usage of fs::get_archive_command outside a file-storage connection context, as in this case the parameter value will be uspecified

- -3
- +17
./file-storage-procs.tcl
- History
- Source
- Diff
./file-storage-procs.tcl
… 1 more file in changeset.

Thursday 16 Mar 2023

3:49 pm

antoniop

Increase proc coverage

- -1
- +33
./file-storage-procs.tcl
- History
- Source
- Diff
./file-storage-procs.tcl

Friday 24 Feb 2023

5:29 pm

antoniop

Declare api as tested

- -1
- +2
./file-storage-procs.tcl
- History
- Source
- Diff
./file-storage-procs.tcl

5:18 pm

antoniop

Increase proc coverage

- -1
- +169
./file-storage-procs.tcl
- History
- Source
- Diff
./file-storage-procs.tcl

Sunday 27 Nov 2022

11:52 am

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

- -5
- +3
./file-storage-procs.tcl
- History
- Source
- Diff
./file-storage-procs.tcl
- -2
- +1
./webtest-procs.tcl
- History
- Source
- Diff
./webtest-procs.tcl
… 5 more files in changeset.

Friday 09 Sep 2022

3:03 pm

antoniop

Deprecate twt::user::create and twt::user::delete, superseded by their acs::test::user:: counterparts

- -5
- +5
./file-storage-procs.tcl
- History
- Source
- Diff
./file-storage-procs.tcl
… 11 more files in changeset.

Thursday 01 Sep 2022

12:41 am

antoniop

Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

- -1
- +1
./webtest-procs.tcl
- History
- Source
- Diff
./webtest-procs.tcl
… 2 more files in changeset.

Wednesday 31 Aug 2022

2:55 pm

antoniop

Reimplement upload automated test using a real multipart request, as newer naviserver will reject handcrafted .tmpfile parameters

- -9
- +19
./webtest-procs.tcl
- History
- Source
- Diff
./webtest-procs.tcl

Thursday 25 Aug 2022

1:29 pm

antoniop

Bring test closer to reality

- -6
- +14
./webtest-procs.tcl
- History
- Source
- Diff
./webtest-procs.tcl

Wednesday 24 Aug 2022

10:58 am

antoniop

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.