• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Complete api coverage for the package

Cover remaining export api

Prevent usage of fs::get_archive_command outside a file-storage connection context, as in this case the parameter value will be uspecified

  1. … 1 more file in changeset.
Increase proc coverage

Declare api as tested

Increase proc coverage

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

  1. … 5 more files in changeset.
Deprecate twt::user::create and twt::user::delete, superseded by their acs::test::user:: counterparts

  1. … 11 more files in changeset.
Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

  1. … 2 more files in changeset.
Reimplement upload automated test using a real multipart request, as newer naviserver will reject handcrafted .tmpfile parameters

Bring test closer to reality

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

  1. … 2 more files in changeset.
Whitespace cleanup

acs::test::user::delete: added flag -delete_created_acs_objects and fix regression test for file-storage

  1. … 5 more files in changeset.
Fix typo, increase api coverage

  1. … 1 more file in changeset.
Fix test category, add tested api

Fix typo, write a basic test for the involved api

  1. … 1 more file in changeset.
perform proper cleanup after the test

Avoid rollback in web tests

Avoid rollback in 'fs_add_file_to_folder' test in particular

Rollback after tests

fix error message

improve spelling

  1. … 5 more files in changeset.
whitespace changes

  1. … 2 more files in changeset.
extend regression test, add covered procs to webtest

  1. … 1 more file in changeset.
Remove bogus proc name. Fixes 'naming__proc_naming' test case

extend tests by porting obsolete test fs_add_file_to_folder to new web testing framework

Add 'fs_create_folder_using_api' test case, covering the 'fs::get_root_folder', 'fs::new_folder', 'fs::get_folder', 'fs::folder_p', 'fs::delete_folder', 'fs::rename_folder' and 'fs_get_folder_name' procs

mark private functions as private

  1. … 9 more files in changeset.
improve listing of test coverage

  1. … 17 more files in changeset.