OpenACS / openacs-4 / packages / chat

www

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 2,465
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 17 May 2023
11:09 am

trenner

room_id is required

Options
    • -2
    • +2
    ./chat.tcl
Tuesday 02 May 2023
10:00 am

gustafn

Improved SQL query significantly by using "acs_permission.permission_p_recursive_array"

Before, a sample query used 300K buffers, now it is down to 2.6 buffers.

Under bad conditions, the old query used 2s or more.

Options
    • -0
    • +22
    ./index-oracle.xql
    • -0
    • +18
    ./index-postgresql.xql
    • -14
    • +2
    ./index.tcl
9:56 am

gustafn

Fixed broken oracle.xql file (broken since 5 years)

Options
    • -1
    • +0
    ./room-oracle.xql
Wednesday 29 Mar 2023
5:33 pm

antoniop

Cleanup the vestigial moderated_p flag

Options
    • -2
    • +1
    ./index.tcl
    • -6
    • +0
    ./room-edit.tcl
    • -4
    • +1
    ./room.tcl
  4. … 7 more files in changeset.
5:15 pm

antoniop

Get rid of the intermediate "room-enter" page and enforce all of the relevant permission in place in the "chat" page, cleanup variables and update automated tests

Options
    • -24
    • +9
    ./chat.tcl
    • -2
    • +2
    ./index.tcl
    • -36
    • +0
    ./room-enter.tcl
  4. … 3 more files in changeset.
Tuesday 14 Mar 2023
2:39 pm

antoniop

Use better message key

Options
    • -2
    • +2
    ./room.adp
Wednesday 08 Mar 2023
4:51 pm

antoniop

Don't hardcode login requirement (to be continued)

Options
    • -2
    • +1
    ./chat.tcl
Tuesday 06 Sep 2022
1:17 pm

antoniop

Deprecate export_entire_form_as_url_vars and replace occurrences, add a new -formvars flag to export vars to implement the behavior of the proc, that is, export a subset of the variables coming from the current request

Options
    • -1
    • +1
    ./search-2.tcl
  2. … 5 more files in changeset.
11:44 am

antoniop

Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

Options
    • -1
    • +1
    ./search-2.tcl
  2. … 11 more files in changeset.
9:40 am

antoniop

Deprecate util_commify_number, replace occurrences and translate automated tests

Options
    • -1
    • +1
    ./search.tcl
  2. … 9 more files in changeset.
Friday 15 Jul 2022
3:35 pm

antoniop

Harden page contracts using new features in acs-tcl

Options
    • -10
    • +7
    ./chat-transcript.tcl
    • -11
    • +3
    ./chat.tcl
    • -9
    • +4
    ./message-delete-2.tcl
    • -2
    • +2
    ./message-delete.tcl
    • -18
    • +4
    ./room-delete-2.tcl
    • -10
    • +2
    ./room-delete.tcl
    • -1
    • +1
    ./room-edit.tcl
    • -11
    • +5
    ./room-enter.tcl
    • -2
    • +2
    ./room-exit.tcl
    • -2
    • +2
    ./room.tcl
    • -2
    • +2
    ./search.tcl
    • -1
    • +1
    ./toggle-active.tcl
    • -10
    • +4
    ./transcript-delete-2.tcl
    • -3
    • +3
    ./transcript-delete.tcl
    • -3
    • +3
    ./transcript-edit.tcl
  16. … 8 more files in changeset.
Wednesday 27 Apr 2022
6:41 pm

gustafn

passing properties consistently with @....;literal@

Options
    • -1
    • +1
    ./chat-transcript.adp
    • -1
    • +1
    ./chat-transcripts.adp
  3. … 11 more files in changeset.
Saturday 15 Jan 2022
5:16 pm

gustafn

get rid of legacy message key "menu-Clipboard-Copy"; "menu-Clipboard-Use-Copy" is used since several years instead

Options
    • -2
    • +2
    ./room.adp
  2. … 6 more files in changeset.
Wednesday 29 Dec 2021
6:12 pm

antoniop

When deleting, make sure supplied id is actually a room id

Options
    • -1
    • +10
    ./room-delete-2.tcl
    • -1
    • +9
    ./room-delete.tcl
Tuesday 05 Oct 2021
11:53 am

antoniop

Cleanup unreferenced SQL

Options
    • -19
    • +0
    ./chat-oracle.xql
    • -19
    • +0
    ./chat-postgresql.xql
Wednesday 02 Jun 2021
2:23 pm

hectorr

Refactor display and edit modes to be based on ad_form. Many thanks to Monika Andergassen and Günter Ernst

Options
    • -5
    • +0
    ./chat-transcript.adp
    • -36
    • +0
    ./transcript-edit-2.tcl
    • -1
    • +1
    ./transcript-edit.adp
    • -20
    • +32
    ./transcript-edit.tcl
  5. … 3 more files in changeset.
Wednesday 12 May 2021
11:42 am

hectorr

Replace handcrafted form with 'ad_form'. Many thanks to Monika Andergassen.

Options
    • -72
    • +0
    ./transcript-entry.adp
    • -42
    • +0
    ./transcript-new-2.tcl
    • -0
    • +8
    ./transcript-new.adp
    • -2
    • +65
    ./transcript-new.tcl
11:42 am

hectorr

file transcript-new.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./transcript-new.adp
Wednesday 31 Mar 2021
12:43 pm

hectorr

Replace deprecated API. Fixes 'callgraph__bad_page_calls' test case

Options
    • -4
    • +5
    ./search-3.tcl
    • -2
    • +3
    ./user-unban-2.tcl
    • -2
    • +3
    ./user-ban-2.tcl
Friday 26 Mar 2021
4:37 pm

hectorr

Remove 'moderator-grant' and 'moderator-revoke' pages, linked nowhere and using obsolete API

Options
    • -24
    • +0
    ./moderator-grant-2.tcl
    • -40
    • +0
    ./moderator-grant.tcl
    • -24
    • +0
    ./moderator-revoke-2.tcl
    • -17
    • +0
    ./moderator-revoke.adp
    • -27
    • +0
    ./moderator-revoke.tcl
4:22 pm

hectorr

Remove 'chat-room-grant.tcl' page, linked nowhere and using obsolete API

Options
    • -46
    • +0
    ./chat-room-grant.tcl
Tuesday 02 Mar 2021
3:48 pm

hectorr

Change input widget to 'number' and use a maximum value for 'messages_time_window' that can be validated in the browser. Bump version number, and add dependency to the 'acs-templating' version providing with the new 'number' widget

Options
    • -1
    • +2
    ./room-edit.tcl
  2. … 1 more file in changeset.
Friday 03 Jul 2020
10:11 am

gustafn

improve spelling: move closer to the linux documentation recommendations

Options
    • -1
    • +1
    ./doc/requirements.html
  2. … 7 more files in changeset.
Friday 03 Apr 2020
9:07 am

hectorr

Show the "Enable notifications" button in the chat only if the user has not accepted, or explicitly denied, notifications yet

Options
    • -1
    • +1
    ./chat.adp
  2. … 1 more file in changeset.
Thursday 02 Apr 2020
8:09 pm

hectorr

Add "Web notifications" for new messages in the chat. See: https://www.w3.org/TR/notifications/

"You should only request consent to display notifications in response to a user gesture

(e.g. clicking a button). This is not only best practice — you should not be spamming

users with notifications they didn't agree to — but going forward browsers will explicitly

disallow notification permission requests not triggered in response to a user gesture.

Firefox is already doing this from version 72, for example, and Safari has done it for some time."

https://developer.mozilla.org/en-US/docs/Web/API/Notifications_API/Using_the_Notifications_API

Options
    • -0
    • +1
    ./chat.adp
  2. … 4 more files in changeset.
Wednesday 25 Mar 2020
2:12 pm

hectorr

Show number of active users in chat. Many thanks to Monika Andergassen

Options
    • -0
    • +3
    ./chat.adp
  2. … 3 more files in changeset.
Friday 20 Mar 2020
11:52 am

antoniop

Handle the case when one is trying to access a non-existing room

Options
    • -2
    • +10
    ./room-enter.tcl
Tuesday 17 Mar 2020
3:06 pm

antoniop

Uniform the quoting criteria when dealing with transcripts:

- transcripts are stored as they are, no quoting in the data we store (and therefore HTML should be avoided)

- transcripts are displayed quoted, therefore disabling any effect from HTML eventually present in the content

- bring the logics to build transcript content in the api to avoid duplication

- avoid sending the transcript content to transcript-new-2, as we can generate it server side

Note: storing transcripts as a pre-formatted chunk of text is probably not the best approach, as any changes to the formatting cannot be applied to pre-existing data without a delicate upgrade. This new approach will make <br> tags inside older transcripts visible...

Options
    • -3
    • +6
    ./transcript-entry.adp
    • -12
    • +7
    ./transcript-new-2.tcl
    • -5
    • +1
    ./transcript-new.tcl
  4. … 4 more files in changeset.
2:57 pm

antoniop

Remove lefrover files

Options
    • -23
    • +0
    ./transcript-view.adp
    • -34
    • +0
    ./transcript-view.tcl
Thursday 12 Mar 2020
11:10 am

antoniop

file toggle-active.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./toggle-active.tcl