OpenACS / openacs-4 / packages / chat

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 20 Dec
Commits this week: 0
Total Lines of Code (LoC): 1,460
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 13 May 2019
12:02 pm

antoniop

Chat reform:

- use consistently package_id to model belonging of a chat object to a particular package instead of the context_id

- set context_id to the package_id, as was already the case in practice, for permission checking

- make sure package_id exists and set it to the context_id in case it doesn't to handle legacy installations

Options
    • -0
    • +11
    ./apm-callback-procs.tcl
    • -2
    • +2
    ./chat-ajax-procs.tcl
    • -2
    • +2
    ./chat-procs.tcl
    • -3
    • +7
    ./xotcl-chat-procs.tcl
  5. … 4 more files in changeset.
Thursday 28 Mar 2019
3:04 pm

antoniop

Skip permission checks outside the connection context (in the sweeper)

Options
    • -9
    • +10
    ./chat-ajax-procs.tcl
2:47 pm

antoniop

Rework permission check

Options
    • -4
    • +6
    ./chat-ajax-procs.tcl
Wednesday 27 Mar 2019
6:27 pm

antoniop

Check permissions: chat_read always and chat_write whenever we post

Options
    • -2
    • +12
    ./chat-ajax-procs.tcl
Friday 15 Mar 2019
5:11 pm

antoniop

Pass the creation user to the transcript object, as this proc is often called via scheduled procedure and won't find one otherwise

Options
    • -0
    • +1
    ./xotcl-chat-procs.tcl
Thursday 07 Mar 2019
3:44 pm

antoniop

Improve formatting of messages

Options
    • -3
    • +3
    ./apm-callback-procs.tcl
3:16 pm

antoniop

Fix upgrade

Options
    • -2
    • +2
    ./apm-callback-procs.tcl
3:11 pm

antoniop

Add callback definition to the info file and define the contract properly as enforced by the UI

Options
    • -3
    • +3
    ./apm-callback-procs.tcl
  2. … 1 more file in changeset.
3:00 pm

antoniop

Maintenance upgrade to get rid of obsolete package parameters

Options
    • -0
    • +42
    ./apm-callback-procs.tcl
  2. … 1 more file in changeset.
3:00 pm

antoniop

file apm-callback-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./apm-callback-procs.tcl
Tuesday 05 Mar 2019
1:11 pm

antoniop

Rely on xotcl ORM machinery to handle acs_object metadata instead of doing it manually

Options
    • -51
    • +0
    ./xotcl-chat-procs.tcl
Monday 04 Mar 2019
4:12 pm

antoniop

Right way to override the fetching of an object is thorugh the fetch query

This would not be necessary once we add acs_object attributes to ::xo::db::Object slots, but as side-effects of this are not clear we leave it for some other time

Options
    • -8
    • +12
    ./xotcl-chat-procs.tcl
Saturday 02 Mar 2019
6:51 pm

antoniop

Replace old procedural api with OO idioms and deprecate it

Options
    • -11
    • +12
    ./chat-ajax-procs.tcl
    • -2
    • +2
    ./chat-init.tcl
    • -35
    • +25
    ./chat-procs.tcl
    • -100
    • +0
    ./chat-procs.xql
    • -0
    • +8
    ./xotcl-chat-procs.tcl
  6. … 22 more files in changeset.
Friday 01 Mar 2019
6:26 pm

antoniop

file xotcl-chat-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./xotcl-chat-procs.tcl
6:25 pm

antoniop

Major reform in the chat backend: use xotcl-core ORM to define all the relevant objects and data model

This greatly converges oracle and postgres codebase and will make easier to apply incremental updates to the data model in the future. It will also automatically update the acs_object_type metadata automatically

TODO: remove legacy procs, temporarly reimplemented using the new backend

Options
    • -212
    • +101
    ./chat-procs.tcl
    • -0
    • +336
    ./xotcl-chat-procs.tcl
  3. … 4 more files in changeset.
4:38 pm

antoniop

Remove old commented-out code

Options
    • -221
    • +1
    ./chat-procs.tcl
Thursday 28 Feb 2019
5:09 pm

antoniop

Chat data-model reform:

- introduce on delete cascade on foreign key constraints so package can be removed easily e.g. from the subsite UI

- remove remaining stored procedures (and function_args definitions) to relieve the burden on the development process and reduce divergency between oracle and postgres code

- converge oracle and postgres datamodels:

. oracle -> add missing messages_time_window column

. postgres -> remove creation_date from chat_transcripts, which was found to be still existing on old downstream installations

Options
    • -226
    • +0
    ./chat-procs-oracle.xql
    • -36
    • +0
    ./chat-procs-postgresql.xql
    • -6
    • +42
    ./chat-procs.tcl
  4. … 7 more files in changeset.
Tuesday 26 Feb 2019
7:26 pm

hectorr

Whitespace changes

Options
    • -13
    • +13
    ./chat-procs.xql
  2. … 4 more files in changeset.
7:06 pm

hectorr

Chat Redesign: enable/disable avatar pictures by room, using the new attribute 'avatar_p', instead of by package instance, using the 'ShowAvatar' parameter.

Options
    • -11
    • +10
    ./chat-ajax-procs.tcl
    • -1
    • +4
    ./chat-procs-oracle.xql
    • -1
    • +3
    ./chat-procs.tcl
    • -3
    • +6
    ./chat-procs.xql
  5. … 16 more files in changeset.
Thursday 14 Feb 2019
5:15 pm

gustafn

Bring files on oacs-5-10 in sync with HEAD

Options
    • -8
    • +45
    ./chat-ajax-procs.tcl
    • -3
    • +1
    ./chat-procs.tcl
  3. … 161 more files in changeset.
Friday 18 Jan 2019
5:39 pm

hectorr

Chat Redesign:

Options
    • -1
    • +3
    ./chat-ajax-procs.tcl
  2. … 4 more files in changeset.
Thursday 06 Dec 2018
8:05 pm

hectorr

Chat Redesign:

+ Add specific container for the chat includelet (xowiki-chat-includelet).

+ Set a sensible default for the 'xowiki-chat-includelet' size.

+ Move the 'my-user-id' hidden element in the chat adp to the chat procs.

+ Rename 'my-user-id' element to 'xowiki-my-user-id'.

+ Get the ChatSkin parameter inside the login proc.

+ Include the skin parameter in the chat includelet.

Options
    • -5
    • +11
    ./chat-ajax-procs.tcl
  2. … 8 more files in changeset.
6:08 pm

hectorr

Chat Redesign: cleanup of obsolete parameters ('AppletHeight','AppletWidth','DefaultClient','ServerHost','ServerPort').

Options
    • -3
    • +1
    ./chat-procs.tcl
  2. … 3 more files in changeset.
5:51 pm

hectorr

Chat Redesign:

+ Skin support.

+ New 'ChatSkin' instance parameter, with currently two possible values: 'classic' and 'bubbles'.

+ Skins are located in the new packages/xowiki/www/resources/chat-skins/ directory.

+ New 'bubbles' skin, default for the chat package.

+ Old skin renamed to 'classic', default for the xowiki includelet.

+ New skins can be created by just adding the css and js files in the skins directory, and naming them accordingly. For example, being '$skin' the name of the new skin, the files should be named chat-$skin-common.js and chat-$skin.css.

+ New '-skin' parameter to the Chat login proc, containing the name of the skin (i.e. 'classic' or 'bubbles').

+ Bump version number.

Options
    • -2
    • +3
    ./chat-ajax-procs.tcl
  2. … 9 more files in changeset.
Thursday 22 Nov 2018
10:08 am

antoniop

Provide a working way to configure the plain xowiki chat includelet:

at Chat class instantiation one can now specify a configuration dict that will be

persisted in an nsv and used to set option parameters (instance variables) such as login messages, logout messages

and the messages time window (and potentially other options in the future). This persistent configuration happpens whenever a client

logs in.

Options
    • -8
    • +8
    ./chat-ajax-procs.tcl
  2. … 2 more files in changeset.
Wednesday 21 Nov 2018
1:32 pm

antoniop

Retract configurability for plain xowiki includelet as, without some way of persisisting the conf over subsequent object instantiations, would really not work and also ignore chat room configs

Options
    • -9
    • +8
    ./chat-ajax-procs.tcl
  2. … 2 more files in changeset.
10:56 am

antoniop

Allow also plain xowiki includelet to specifiy if we want login and logout messages and the past messages time window through includelet parameters

Options
    • -9
    • +9
    ./chat-ajax-procs.tcl
  2. … 2 more files in changeset.
Tuesday 20 Nov 2018
6:46 pm

antoniop

Chat reform:

- reduce code duplication by determining the proper chat class dynamically and storing it in an nsv

- move static content in the resources path. Serving them is now independent from the mounted xowiki path

- get rid of the ajax url path

Options
    • -1
    • +6
    ./chat-ajax-procs.tcl
  2. … 12 more files in changeset.
Monday 19 Nov 2018
5:35 pm

antoniop

Give xowiki chat also some kind of nice skin and centralize css retrieval

TODO: something smarter can be done in order to retrieve the proper css, based e.g. on theme, chat skin (to be implemented) etc. To be discussed is some way to resolve resources based on the theme.

Options
    • -2
    • +1
    ./chat-ajax-procs.tcl
  2. … 3 more files in changeset.
3:32 pm

antoniop

New chat_room includelet, behaving as the existing chat one, but plugged with extra chat package's feature (transcript management...)

To avoid package_id to be overridden, we force it always to the one of the current chat

Options
    • -2
    • +27
    ./chat-ajax-procs.tcl
  2. … 2 more files in changeset.