• last updated 22 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Handle persisting messages from outside of a connection, e.g. in the chat sweeper

Also cleanup acs_attribute

  1. … 1 more file in changeset.
Cleanup the vestigial moderated_p flag

  1. … 6 more files in changeset.
Get rid of the intermediate "room-enter" page and enforce all of the relevant permission in place in the "chat" page, cleanup variables and update automated tests

  1. … 4 more files in changeset.
Basic webtest of chat room creation

file webtest-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
Follow-up for https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20230313120323

- make sure the anonymous users nsv is created when the chat is instantiated

- make sure xo::cc is available when the anonymous identifier is generated

- handle in the Chat package, that the uid may not be a user, but an IP address

- adapt other chat skins to the new anonymous user logics

  1. … 5 more files in changeset.
Do not add additional style around the chat includelet, regardless if this is a "chat_room" or a "chat"

  1. … 3 more files in changeset.
Allow to pass down the skin configuration to the chat_room includelet

Complete coverage for the package

Fix syntax for proc coverage

Expect arbitrary arguments on inherited methods, detect instance variables that should be passed to the object creation in save_new

Test chat room creation

This test now fails because certain acs_object metadata are not taken from instance variables, but from the context

file chat-test-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
improve Oracle compatibility

switch from xo::db::sql to acs::dc interface

  1. … 11 more files in changeset.
improve safety of SQL queries

  1. … 4 more files in changeset.
use acs::clusterwide instead of xo::clusterwide

  1. … 5 more files in changeset.
Fix typo affecting only a fresh installation of the chat package...

improve spelling

  1. … 42 more files in changeset.
New index on chat_transcripts(room_id)

  1. … 1 more file in changeset.
Fix typo

improve spelling: move closer to the linux documentation recommendations

  1. … 7 more files in changeset.
Fix var name

Allow passing chat skin to 'chat::Chat login'

Keep returning 0 when no transcript is created, as the code expects

Uniform the quoting criteria when dealing with transcripts:

- transcripts are stored as they are, no quoting in the data we store (and therefore HTML should be avoided)

- transcripts are displayed quoted, therefore disabling any effect from HTML eventually present in the content

- bring the logics to build transcript content in the api to avoid duplication

- avoid sending the transcript content to transcript-new-2, as we can generate it server side

Note: storing transcripts as a pre-formatted chunk of text is probably not the best approach, as any changes to the formatting cannot be applied to pre-existing data without a delicate upgrade. This new approach will make <br> tags inside older transcripts visible...

  1. … 6 more files in changeset.
Fix typo

Try to handle the case of a user accessing a non-existing chat without throwing a log error

added editor hints and white-space cleanup

  1. … 23 more files in changeset.