OpenACS / openacs-4 / packages

categories

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 31
Last Commit: 09:27
Commits this week: 0
Total Lines of Code (LoC): 15,908
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 16 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 16 Sep 2022
3:56 pm

antoniop

Make service contract implementations private, test them

Options
    • -2
    • +2
    ./tcl/category-trees-procs.tcl
    • -1
    • +44
    ./tcl/test/categories-procs.tcl
Monday 12 Sep 2022
6:12 pm

antoniop

Document public api, add library header

Options
    • -6
    • +12
    ./tcl/widget-procs.tcl
Thursday 08 Sep 2022
6:02 pm

antoniop

Increase coverage

Options
    • -1
    • +6
    ./tcl/test/categories-procs.tcl
5:59 pm

antoniop

Increase coverage

Options
    • -7
    • +31
    ./tcl/test/categories-procs.tcl
5:56 pm

antoniop

Make category::page_url private: it is meant to be used via the service contracts and not directly

Options
    • -2
    • +2
    ./tcl/categories-procs.tcl
5:42 pm

antoniop

Increase proc coverage

Options
    • -2
    • +43
    ./tcl/test/categories-procs.tcl
5:04 pm

antoniop

Pass the name down to the db_multirow api, just setting the multirow name is not sufficient to "rename" a multirow

Options
    • -3
    • +2
    ./tcl/categories-procs.tcl
5:00 pm

antoniop

Test api to map an object to a category, which exposes a bug in category::get_mapped_categories_multirow

Options
    • -1
    • +88
    ./tcl/test/categories-procs.tcl
12:25 pm

antoniop

Increase test coverage

Options
    • -4
    • +12
    ./tcl/test/categories-procs.tcl
Monday 29 Aug 2022
4:17 pm

antoniop

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

Options
    • -2
    • +2
    ./tcl/install-procs.tcl
    • -2
    • +2
    ./www/cadmin/tree-view.tcl
  3. … 32 more files in changeset.
Wednesday 17 Aug 2022
12:32 pm

antoniop

Add page contract, update dependencies

Options
    • -3
    • +3
    ./categories.info
    • -0
    • +7
    ./lib/tree-code.tcl
Thursday 14 Jul 2022
5:48 pm

antoniop

Add include contract

Options
    • -3
    • +8
    ./lib/list-categories.tcl
    • -11
    • +9
    ./www/include/widget.tcl
4:58 pm

antoniop

Add include contract

Options
    • -27
    • +17
    ./lib/contributions.tcl
  2. … 1 more file in changeset.
Wednesday 09 Mar 2022
6:09 pm

gustafn

whitespace changes

Options
    • -98
    • +97
    ./tcl/widget-procs.tcl
6:09 pm

gustafn

reduce verbosity

Options
    • -2
    • +7
    ./tcl/widget-procs.tcl
Thursday 16 Sep 2021
10:27 am

gustafn

fix release dates in .info files

Options
    • -1
    • +1
    ./categories.info
  2. … 82 more files in changeset.
Wednesday 15 Sep 2021
6:11 pm

gustafn

release work

Options
    • -2
    • +2
    ./categories.info
  2. … 204 more files in changeset.
Tuesday 07 Sep 2021
2:05 pm

antoniop

change_locale is actually a property of this master that is supplied by the slaves, not a part of the page contract

Options
    • -1
    • +4
    ./www/cadmin/master.tcl
1:47 pm

antoniop

Add page contract

Options
    • -6
    • +5
    ./lib/categorize.tcl
Friday 03 Sep 2021
11:14 am

gustafn

regenerated documentation

Options
    • -3
    • +2
    ./www/doc/design.adp
    • -1
    • +1
    ./www/doc/index.adp
    • -1
    • +1
    ./www/doc/install.adp
    • -8
    • +8
    ./www/doc/o.adp
    • -1
    • +1
    ./www/doc/requirements.adp
  6. … 464 more files in changeset.
Thursday 02 Sep 2021
7:22 pm

gustafn

bump version numbers of 5.9|5.10 packages to 5.10.0b1

adjust dependencies

Options
    • -2
    • +2
    ./categories.info
  2. … 87 more files in changeset.
6:40 pm

gustafn

improve spelling

Options
    • -3
    • +3
    ./www/cadmin/tree-order-update.tcl
  2. … 42 more files in changeset.
Thursday 24 Jun 2021
3:49 pm

hectorr

Extend 'category_tree_procs' test case with 'category::relation::add_meta_category' and 'category::relation::get_meta_categories'

Options
    • -1
    • +22
    ./tcl/test/categories-procs.tcl
3:07 pm

hectorr

Extend 'category_tree_procs' test case with 'category::change_parent'

Options
    • -1
    • +13
    ./tcl/test/categories-procs.tcl
2:38 pm

hectorr

Extend 'category_tree_procs' test case with 'category::count_children'

Options
    • -1
    • +4
    ./tcl/test/categories-procs.tcl
Wednesday 10 Mar 2021
4:18 pm

antoniop

Final phasing out of acs_named_objects

- remove table creation

- update documentation

- provide an optional upgrade script to delete the table and the object type (commented out by default, as people might have defined object subtypes downstream).

Context: this table and the related machinery were created at a time where acs_objects where not as mature as they are now and would not include the "title" information. To retrieve the object name, the only option was the stored procedure acs_object.name, which was not scalable.

From an excerpt of the Changelog file:

.....

2004-03-31 jeffd

......

* packages/categories/tcl/category-trees-procs-oracle.xql:

* packages/categories/tcl/category-trees-procs-postgresql.xql:

acs_named_objects superflous now that title is in

acs_objects. need to fix the rest of the occurances though

......

This tells us that the phasing out has already been decided back in 2004, but delayed. One technical reason, could be that the acs_named_objects table would also materialize the translation, while the title column would store sometimes a message key, that would need to be translated manually. This is helpful when e.g. sorting by name in sql. However, only the faq and categories package would seem to make any use of the table and only the faq package would seem to maintain its values... This would make some UIs in the categories package practically useless since a long time.

Options
    • -2
    • +2
    ./categories.info
    • -35
    • +0
    ./sql/oracle/categories-init.sql
    • -0
    • +12
    ./sql/oracle/upgrade/upgrade-1.1.5d3-1.1.5d4.sql
    • -2
    • +0
    ./sql/postgresql/categories-drop.sql
    • -37
    • +0
    ./sql/postgresql/categories-init.sql
    • -0
    • +10
    ./sql/postgresql/upgrade/upgrade-1.1.5d3-1.1.5d4.sql
    • -78
    • +6
    ./www/doc/o.adp
    • -88
    • +10
    ./www/doc/o.html
4:18 pm

antoniop

file upgrade-1.1.5d3-1.1.5d4.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-1.1.5d3-1.1.5d4.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-1.1.5d3-1.1.5d4.sql
2:21 pm

antoniop

Cleanup var, break overlong line

Options
    • -4
    • +8
    ./www/categories-browse.tcl
2:16 pm

antoniop

Rework of category UI:

- phase out usage of acs_named_objects, use object title instead

- rework pagination using builtin template::list features

- reduce hardcoded styling and markup

- rework strange database idioms

- remove divergency between oracle and postgres codebase

Options
    • -30
    • +0
    ./www/categories-browse-oracle.xql
    • -24
    • +0
    ./www/categories-browse-postgresql.xql
    • -35
    • +2
    ./www/categories-browse.adp
    • -104
    • +83
    ./www/categories-browse.tcl
    • -46
    • +8
    ./www/categories-browse.xql
Tuesday 09 Mar 2021
3:25 pm

antoniop

Formatting change

Options
    • -2
    • +30
    ./www/categories-browse.tcl