OpenACS / openacs-4 / packages

acs-templating

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 3
Total Committers: 61
Last Commit: 28 Dec
Commits this week: 3
Total Lines of Code (LoC): 319,359
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 01 Sep 2022
6:19 pm

antoniop

Test template::adp_level, fix test coverage declaration

Options
    • -3
    • +36
    ./tcl/test/parse-test-procs.tcl
6:10 pm

antoniop

Test template::adp_parse_string

Options
    • -1
    • +16
    ./tcl/test/parse-test-procs.tcl
6:04 pm

antoniop

Deprecate template::adp_levels, found nowhere in the upstream codebase and superseded by template::adp_level

Options
    • -2
    • +3
    ./tcl/parse-procs.tcl
5:52 pm

antoniop

Increase proc coverage

Options
    • -39
    • +62
    ./tcl/test/parse-test-procs.tcl
5:32 pm

antoniop

State additional proc coverage, improve documentation

Options
    • -2
    • +4
    ./tcl/parse-procs.tcl
    • -0
    • +1
    ./tcl/test/file-procs.tcl
    • -1
    • +2
    ./tcl/test/parse-test-procs.tcl
5:03 pm

antoniop

Make template::head::prepare_multirows a private interface: its stated purpose is to be used inside of the blank-master and it has no practical use otherwise

Options
    • -1
    • +1
    ./tcl/head-procs.tcl
4:50 pm

antoniop

Make adp_parse_ad_conn_file a private interface: its stated purpose is to be registered via rp_register_extension_handler in acs-templating/tcl/acs-integration-init.tcl and it has no practical use otherwise

Options
    • -3
    • +3
    ./tcl/acs-integration-procs.tcl
2:58 pm

antoniop

Test ad_return_template

Options
    • -5
    • +76
    ./tcl/test/acs-integration-procs.tcl
Wednesday 31 Aug 2022
12:18 pm

antoniop

Test ad_return_exception_template

Options
    • -0
    • +76
    ./tcl/test/acs-integration-procs.tcl
12:18 pm

antoniop

file acs-integration-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/acs-integration-procs.tcl
Tuesday 30 Aug 2022
6:07 pm

antoniop

Test ad_dimensional_sql

Options
    • -0
    • +45
    ./tcl/test/dimensional-procs.tcl
5:53 pm

antoniop

Test ad_dimensional

Options
    • -0
    • +69
    ./tcl/test/dimensional-procs.tcl
5:53 pm

antoniop

file dimensional-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/dimensional-procs.tcl
11:38 am

antoniop

Fix typo

Options
    • -2
    • +4
    ./tcl/element-procs.tcl
11:35 am

antoniop

template::element validation reform: do not run custom user-defined validation on fields that are not formally correct

Rationale: user-defined validation often assumes some basic consistency of the submitted value. When this is not formally correct, users might have to reimplement the whole formal validation in their custom fields in order to prevent exceptions. By preventing their custom blocks from being executed, users can rely on their custom fields to be run only against sane values.

Options
    • -20
    • +38
    ./tcl/element-procs.tcl
11:22 am

antoniop

Restore formatting in procs doc

Options
    • -79
    • +99
    ./tcl/element-procs.tcl
10:50 am

antoniop

Normalize indentation according to editor hints

Options
    • -366
    • +366
    ./tcl/element-procs.tcl
Monday 29 Aug 2022
4:50 pm

antoniop

Test template::util::list_to_lookup

Options
    • -1
    • +30
    ./tcl/test/util-procs.tcl
4:30 pm

antoniop

Deprecate template::util::nvl

Options
    • -2
    • +6
    ./tcl/util-procs.tcl
    • -29
    • +1
    ./tcl/test/util-procs.tcl
4:25 pm

antoniop

Deprecate template::util::list_to_array

Options
    • -2
    • +8
    ./tcl/util-procs.tcl
4:17 pm

antoniop

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

Options
    • -2
    • +2
    ./tcl/deprecated-procs.tcl
    • -3
    • +3
    ./tcl/form-procs.tcl
    • -6
    • +6
    ./tcl/list-procs.tcl
    • -1
    • +1
    ./tcl/richtext-procs.tcl
    • -2
    • +2
    ./tcl/tag-init.tcl
    • -4
    • +4
    ./tcl/tag-procs.tcl
    • -2
    • +8
    ./tcl/util-procs.tcl
  8. … 27 more files in changeset.
3:00 pm

antoniop

Shorten idiom

Options
    • -11
    • +2
    ./tcl/util-procs.tcl
2:54 pm

antoniop

Test template::util::is_nil

Options
    • -1
    • +24
    ./tcl/test/util-procs.tcl
1:00 pm

antoniop

Deprecate template::util::array_to_vars and template::util::vars_to_array: their functionality can be easily inlined by using the array command

Options
    • -3
    • +11
    ./tcl/util-procs.tcl
  2. … 3 more files in changeset.
Thursday 25 Aug 2022
3:12 pm

antoniop

Declare proc coverage

Options
    • -0
    • +1
    ./tcl/test/file-procs.tcl
  2. … 1 more file in changeset.
2:45 pm

antoniop

Make also sure the tmpfile from the widget exists beforehand, when validating: we don't want users to "explore" our tmpdir with bogus values that just look sane

Options
    • -3
    • +3
    ./acs-templating.info
    • -1
    • +1
    ./tcl/file-procs.tcl
    • -11
    • +24
    ./tcl/test/data-procs.tcl
1:37 pm

antoniop

Improve doc

Options
    • -3
    • +3
    ./tcl/file-procs.tcl
1:34 pm

antoniop

Revert to previous template::widget::file behavior of accepting input in a form of a list of 3 elements (e.g. without a .tmpfile in the request), but introduce validation so that we enforce all widget values to be in the proper format and the files to be "safe"

Options
    • -3
    • +3
    ./acs-templating.info
    • -0
    • +1
    ./catalog/acs-templating.en_US.ISO-8859-1.xml
    • -42
    • +83
    ./tcl/file-procs.tcl
    • -7
    • +14
    ./tcl/test/data-procs.tcl
    • -0
    • +244
    ./tcl/test/file-procs.tcl
1:34 pm

antoniop

file file-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/file-procs.tcl
Wednesday 24 Aug 2022
10:58 am

antoniop

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

Options
    • -19
    • +4
    ./tcl/file-procs.tcl
  2. … 2 more files in changeset.