Activity OpenACS/openacs-4/packages/acs-templating

Tree
Accordion

Stats

Commits this week: 4

Total Committers:	61
Last Commit:	14 Nov
Commits this week:	4
Total Lines of Code (LoC):	319,303
Net change in LoC this week:	-6

Commit Activity

last updated 13 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Monday 29 Aug 2022

4:30 pm

antoniop

Deprecate template::util::nvl

- -2
- +6
./tcl/util-procs.tcl
- History
- Source
- Diff
./tcl/util-procs.tcl
- -29
- +1
./tcl/test/util-procs.tcl
- History
- Source
- Diff
./tcl/test/util-procs.tcl

4:25 pm

antoniop

Deprecate template::util::list_to_array

- -2
- +8
./tcl/util-procs.tcl
- History
- Source
- Diff
./tcl/util-procs.tcl

4:17 pm

antoniop

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

- -2
- +2
./tcl/deprecated-procs.tcl
- History
- Source
- Diff
./tcl/deprecated-procs.tcl
- -3
- +3
./tcl/form-procs.tcl
- History
- Source
- Diff
./tcl/form-procs.tcl
- -6
- +6
./tcl/list-procs.tcl
- History
- Source
- Diff
./tcl/list-procs.tcl
- -1
- +1
./tcl/richtext-procs.tcl
- History
- Source
- Diff
./tcl/richtext-procs.tcl
- -2
- +2
./tcl/tag-init.tcl
- History
- Source
- Diff
./tcl/tag-init.tcl
- -4
- +4
./tcl/tag-procs.tcl
- History
- Source
- Diff
./tcl/tag-procs.tcl
- -2
- +8
./tcl/util-procs.tcl
- History
- Source
- Diff
./tcl/util-procs.tcl
… 27 more files in changeset.

3:00 pm

antoniop

Shorten idiom

- -11
- +2
./tcl/util-procs.tcl
- History
- Source
- Diff
./tcl/util-procs.tcl

2:54 pm

antoniop

Test template::util::is_nil

- -1
- +24
./tcl/test/util-procs.tcl
- History
- Source
- Diff
./tcl/test/util-procs.tcl

1:00 pm

antoniop

Deprecate template::util::array_to_vars and template::util::vars_to_array: their functionality can be easily inlined by using the array command

- -3
- +11
./tcl/util-procs.tcl
- History
- Source
- Diff
./tcl/util-procs.tcl
… 3 more files in changeset.

Thursday 25 Aug 2022

3:12 pm

antoniop

Declare proc coverage

- -0
- +1
./tcl/test/file-procs.tcl
- History
- Source
- Diff
./tcl/test/file-procs.tcl
… 1 more file in changeset.

2:45 pm

antoniop

Make also sure the tmpfile from the widget exists beforehand, when validating: we don't want users to "explore" our tmpdir with bogus values that just look sane

- -3
- +3
./acs-templating.info
- History
- Source
- Diff
./acs-templating.info
- -1
- +1
./tcl/file-procs.tcl
- History
- Source
- Diff
./tcl/file-procs.tcl
- -11
- +24
./tcl/test/data-procs.tcl
- History
- Source
- Diff
./tcl/test/data-procs.tcl

1:37 pm

antoniop

Improve doc

- -3
- +3
./tcl/file-procs.tcl
- History
- Source
- Diff
./tcl/file-procs.tcl

1:34 pm

Revert to previous template::widget::file behavior of accepting input in a form of a list of 3 elements (e.g. without a .tmpfile in the request), but introduce validation so that we enforce all widget values to be in the proper format and the files to be "safe"

- -3
- +3
./acs-templating.info
- History
- Source
- Diff
./acs-templating.info
- -0
- +1
./catalog/acs-templating.en_US.ISO-8859-1.xml
- History
- Source
- Diff
./catalog/acs-templating.en_US.ISO-8859-1.xml
- -42
- +83
./tcl/file-procs.tcl
- History
- Source
- Diff
./tcl/file-procs.tcl
- -7
- +14
./tcl/test/data-procs.tcl
- History
- Source
- Diff
./tcl/test/data-procs.tcl
- -0
- +244
./tcl/test/file-procs.tcl
- History
- Source
- Diff
./tcl/test/file-procs.tcl

1:34 pm

antoniop

More
MAIN:antoniop:20220825113450
deleted 1 file
MAIN

file file-procs.tcl was initially added on branch oacs-5-10.

- -0
- +0
./tcl/test/file-procs.tcl
- History
- Source
./tcl/test/file-procs.tcl

Wednesday 24 Aug 2022

10:58 am

antoniop

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

- -19
- +4
./tcl/file-procs.tcl
- History
- Source
- Diff
./tcl/file-procs.tcl
… 2 more files in changeset.

Tuesday 23 Aug 2022

5:39 pm

antoniop

Incorporate feedback from downstream penetration tests:

do not skip basic validation in the file widget when a tmpfile is not found in the request.

- -47
- +54
./tcl/file-procs.tcl
- History
- Source
- Diff
./tcl/file-procs.tcl

Sunday 14 Aug 2022

10:05 am

gustafn

extended adp:icon handling

Added support for multiple classes,

Added more potentially reusabel icon names,

bumped version to 5.10.1d13

- -2
- +2
./acs-templating.info
- History
- Source
- Diff
./acs-templating.info
- -3
- +4
./tcl/style-procs.tcl
- History
- Source
- Diff
./tcl/style-procs.tcl
- -2
- +6
./tcl/tag-init.tcl
- History
- Source
- Diff
./tcl/tag-init.tcl

Saturday 13 Aug 2022

3:55 pm

gustafn

extended generic names by "user" and "list-alt"

- -1
- +9
./tcl/tag-init.tcl
- History
- Source
- Diff
./tcl/tag-init.tcl

Thursday 11 Aug 2022

1:05 pm

gustafn

whitespace changes

- -50
- +50
./tcl/tag-init.tcl
- History
- Source
- Diff
./tcl/tag-init.tcl

1:01 pm

gustafn

added new generic icon name: add-new-item

- -1
- +5
./tcl/tag-init.tcl
- History
- Source
- Diff
./tcl/tag-init.tcl

1:00 pm

gustafn

prefer parameter::get_from_package_key over fetching package_id first

- -7
- +9
./tcl/template-init.tcl
- History
- Source
- Diff
./tcl/template-init.tcl

Friday 15 Jul 2022

1:21 pm

antoniop

Cleanup message keys that do not exist in the english locale (they do exist in their "_time" variant, e.g. Time_must_be_after_min_time, already translated in spanish)