OpenACS / openacs-4 / packages

acs-templating

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 61
Last Commit: 26 Dec
Commits this week: 1
Total Lines of Code (LoC): 319,359
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 05 Dec
5:12 pm

antoniop

Test converting to and from a multirow and a list

The test reveals that when converting a list into a multirow, the columns will not be set correctly

Options
    • -1
    • +53
    ./tcl/test/util-procs.tcl
Thursday 14 Nov
1:02 pm

antoniop

Ensure the namespace exists for template::form::export

Options
    • -1
    • +4
    ./tcl/deprecated-procs.tcl
Wednesday 13 Nov
9:41 am

gustafn

prefer more efficient "ns_set array" over single item ns_set access

Options
    • -23
    • +16
    ./tcl/tag-procs.tcl
9:40 am

gustafn

use consistently case-insensitive access to attributes of tags

Options
    • -2
    • +2
    ./tcl/parse-procs.tcl
    • -1
    • +1
    ./tcl/tab-procs.tcl
    • -11
    • +9
    ./tcl/tag-init.tcl
9:36 am

gustafn

moved deprecated proc to deprecated-procs.tcl

Options
    • -1
    • +31
    ./tcl/deprecated-procs.tcl
    • -31
    • +1
    ./tcl/form-procs.tcl
Wednesday 06 Nov
1:59 pm

antoniop

Deprecate template::list::csv_quote and replace its usages in packages that we have been supporting

Options
    • -2
    • +6
    ./tcl/list-procs.tcl
  2. … 3 more files in changeset.
1:37 pm

antoniop

Introduce a new "label_headers" flag for template::list::write_csv that allows to revert to behavior before https://cvs.openacs.org/changelog/OpenACS?cs=MAIN%3Adaveb%3A20080908165252, e.g. use the column names as headers rather than the labels

For some use cases is in fact more useful to have machine-readable headers, e.g. when processing the csv via software

Options
    • -2
    • +11
    ./tcl/list-procs.tcl
1:18 pm

antoniop

Rely on the csv Tcllib package to generate a csv from a template::list

Options
    • -7
    • +12
    ./tcl/list-procs.tcl
Wednesday 30 Oct
5:25 pm

antoniop

Provide a way to retrieve known css toolkits without hardcoding

Options
    • -2
    • +2
    ./acs-templating.info
    • -0
    • +7
    ./tcl/style-procs.tcl
4:32 pm

antoniop

Provide some xowiki-relevant classes for the ui toolkit as well, fix pattern to detect w3css

Options
    • -2
    • +2
    ./acs-templating.info
    • -1
    • +7
    ./tcl/style-procs.tcl
Tuesday 29 Oct
4:27 pm

gustafn

don't use swallowing exception handling

Options
    • -14
    • +16
    ./tcl/style-procs.tcl
2:43 pm

antoniop

Fix idiom

Options
    • -1
    • +1
    ./tcl/style-procs.tcl
1:51 pm

antoniop

Handle the case where acs_templating_cssClasses nsv does not exist

This array is currently only defined in upstream theme packages.

Options
    • -4
    • +10
    ./tcl/style-procs.tcl
Monday 28 Oct
6:09 pm

gustafn

added theme specific registry for cass class name mapping

Options
    • -2
    • +2
    ./acs-templating.info
    • -2
    • +20
    ./tcl/style-procs.tcl
  3. … 4 more files in changeset.
Sunday 27 Oct
7:19 pm

gustafn

map in adp:button fro bootstrap5 only selectively data attribute names

Options
    • -2
    • +2
    ./acs-templating.info
    • -5
    • +8
    ./tcl/tag-init.tcl
12:38 pm

gustafn

This change intruduces <adp:button>, which avoids adp:* markup inside

HTML attribute values, which we had before. One can now use

<adp:button type="submit" class="btn btn-outline-secondary">Filter</adp:button>

instead of

<button type="submit" class="btn <adp:class name='btn-outline-secondary'>">Filter</button>

One should probably provide in the future more adp:* tags for

providing a clean mapping of CSS class attributes.

<adp:class> was deactivated for the time being

Options
    • -2
    • +2
    ./acs-templating.info
    • -10
    • +46
    ./tcl/tag-init.tcl
  3. … 2 more files in changeset.
Friday 25 Oct
11:50 am

gustafn

factor out some w3css styling and make it available via template::CSS

Options
    • -37
    • +50
    ./tcl/style-procs.tcl
    • -1
    • +13
    ./tcl/tag-init.tcl
  3. … 1 more file in changeset.
Thursday 24 Oct
7:02 pm

gustafn

Move functionality of xowiki::CSS to tempate::CSS

template CSS provides an abstraction for CSS class names and other

styling elements depending on user preferences or on the current theme

Backwards compatibility for xowiki::CSS was provided via a stub function

Options
    • -2
    • +3
    ./acs-templating.info
    • -4
    • +262
    ./tcl/style-procs.tcl
  3. … 21 more files in changeset.
Wednesday 16 Oct
11:21 am

gustafn

Added code to skip suspicious looking query variables

On openacs.org, we are experiencing numerous requests with

multiply very long and strange query variables like in the example

below. So far, it is not clear, whether these requests are the

consequence of a double encoding or a deliberate attack. Many (most)

of the requests contain the query variable names containing the

(decoded) pattern "*amp;*".

This is a relatively new phenomenon. I cannot exclude that this is a

bug introduced lately in OpenACS, or a bug in an external bot, or

whatever. The problem with these query variables is that OpenACS

propagates these further, e.g., when updating query variables in

ad_dimensional, via export_vars, or return_urls.

Since OpenACS never uses these query-variables, these can be safely

skipped, without loosing functionality in OpenACS. It is possible to

construct examples, where skipping such variables can change the

semantics. Therefore, the change introduces a single function

util::suspicious_query_variable where in case of problems, the

skipping feature can be deactivated.

GET /api-doc/proc-browse?amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp;type=All&amp;amp%3btype=All&amp;amp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=Private&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All HTTP/1.1" 200 62378 "" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/605.1.15 (KHTML, like Gecko; compatible; FriendlyCrawler/1.0) Chrome/120.0.6099.216 Safari/605.1.15" "1729029614.331581 0.109805 0.000434 0.004026 0.215927

Options
    • -3
    • +3
    ./acs-templating.info
    • -1
    • +8
    ./tcl/dimensional-procs.tcl
  3. … 5 more files in changeset.
Tuesday 08 Oct
4:26 pm

antoniop

Modernize tcl idioms

Options
    • -11
    • +8
    ./tcl/query-procs.tcl
4:20 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -7
    • +7
    ./tcl/head-procs.tcl
    • -2
    • +2
    ./tcl/list-procs.tcl
    • -3
    • +3
    ./tcl/query-procs.tcl
  4. … 1 more file in changeset.
Tuesday 01 Oct
2:44 pm

gustafn

tcl9 changes: "string bytelength" does not exist in tcl9

Options
    • -2
    • +7
    ./tcl/element-procs.tcl
  2. … 1 more file in changeset.
Wednesday 11 Sep
8:11 am

gustafn

merge with missing files

Options
    • -0
    • +2
    ./lib/body_scripts.adp
    • -0
    • +9
    ./lib/body_scripts.tcl
    • -0
    • +6
    ./lib/registered-urns.adp
    • -0
    • +22
    ./lib/registered-urns.tcl
    • -0
    • +0
    ./sql/oracle/acs-templating-create.sql
    • -0
    • +0
    ./sql/postgresql/acs-templating-create.sql
    • -0
    • +0
    ./tcl/0-acs-templating-procs.tcl
    • -0
    • +0
    ./tcl/acs-integration-procs.tcl
    • -0
    • +0
    ./tcl/data-procs.tcl
    • -0
    • +0
    ./tcl/date-procs.tcl
    • -0
    • +0
    ./tcl/deprecated-procs.tcl
    • -0
    • +0
    ./tcl/dimensional-procs.tcl
    • -0
    • +0
    ./tcl/doc-procs.tcl
    • -0
    • +0
    ./tcl/doc-tcl-procs.tcl
    • -0
    • +0
    ./tcl/element-procs.tcl
  16. … 1450 more files in changeset.
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -6
    • +8
    ./acs-templating.info
    • -0
    • +6
    ./catalog/acs-templating.de_DE.ISO-8859-1.xml
    • -2
    • +16
    ./catalog/acs-templating.en_US.ISO-8859-1.xml
    • -0
    • +11
    ./catalog/acs-templating.es_ES.ISO-8859-1.xml
    • -0
    • +15
    ./catalog/acs-templating.it_IT.ISO-8859-1.xml
    • -12
    • +3
    ./resources/forms/confirm-button.tcl
    • -1
    • +1
    ./resources/forms/standard.adp
    • -7
    • +7
    ./resources/lists/table-2third.adp
    • -2
    • +2
    ./resources/lists/table.adp
    • -1
    • +1
    ./sql/oracle/acs-templating-create.sql
    • -1
    • +1
    ./sql/postgresql/acs-templating-create.sql
    • -14
    • +26
    ./tcl/0-acs-templating-procs.tcl
    • -17
    • +40
    ./tcl/acs-integration-procs.tcl
    • -2
    • +2
    ./tcl/currency-procs.tcl
    • -288
    • +391
    ./tcl/data-procs.tcl
  16. … 8085 more files in changeset.
Monday 02 Sep
2:54 pm

gustafn

bumped version number from development version to release version

Options
    • -5
    • +5
    ./acs-templating.info
  2. … 93 more files in changeset.
11:40 am

gustafn

regenerated documentation

Options
    • -5
    • +8
    ./www/doc/design.adp
    • -0
    • +4
    ./www/doc/designer-guide.adp
    • -2
    • +8
    ./www/doc/developer-guide.adp
    • -0
    • +4
    ./www/doc/index.adp
    • -16
    • +12
    ./www/doc/install.adp
    • -0
    • +4
    ./www/doc/introduction.adp
    • -22
    • +15
    ./www/doc/migration.adp
    • -20
    • +14
    ./www/doc/no-quote-upgrade.adp
    • -3
    • +7
    ./www/doc/noquote.adp
    • -14
    • +20
    ./www/doc/requirements.adp
    • -0
    • +4
    ./www/doc/timing-1.adp
    • -0
    • +4
    ./www/doc/timing-2.adp
    • -0
    • +4
    ./www/doc/timing-3.adp
    • -5
    • +8
    ./www/doc/timing.adp
    • -0
    • +4
    ./www/doc/todo.adp
  16. … 426 more files in changeset.
Sunday 01 Sep
2:39 pm

gustafn

improved spelling

Options
    • -1
    • +1
    ./www/doc/demo/index.adp
    • -1
    • +1
    ./www/doc/demo/index.html
    • -4
    • +2
    ./www/doc/exercise/ats-for-designers.html
    • -1
    • +1
    ./www/doc/gadgets/modal.adp
    • -1
    • +1
    ./www/doc/guide/composite.adp
    • -1
    • +1
    ./www/doc/guide/composite.html
  7. … 9 more files in changeset.
Thursday 29 Aug
2:15 pm

antoniop

Fix typo

Options
    • -1
    • +1
    ./www/sitewide-admin/index.adp
Tuesday 27 Aug
4:50 pm

gustafn

fixed race condition and silence regression test

Options
    • -16
    • +26
    ./tcl/test/file-procs.tcl
Monday 26 Aug
4:31 pm

gustafn

Removed dependency on file-storage

- there was a "silent" dependency of acs-templating to the file-storage, since it

used many message keys from there.

- The message keys went to acs-content-repository

Options
    • -2
    • +2
    ./acs-templating.info
    • -8
    • +7
    ./www/resources/xinha-nightly/plugins/OacsFs/popups/file-selector.tcl
    • -8
    • +7
    ./www/scripts/xinha/file-selector.tcl