Activity OpenACS/openacs-4/packages/acs-templating/tcl

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	46
Last Commit:	05 Jul
Commits this week:	0
Total Lines of Code (LoC):	20,734
Net change in LoC this week:	0

Commit Activity

last updated 10 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Thursday 25 Aug 2022

2:45 pm

antoniop

Make also sure the tmpfile from the widget exists beforehand, when validating: we don't want users to "explore" our tmpdir with bogus values that just look sane

- -1
- +1
./file-procs.tcl
- History
- Source
- Diff
./file-procs.tcl
- -11
- +24
./test/data-procs.tcl
- History
- Source
- Diff
./test/data-procs.tcl
… 1 more file in changeset.

1:37 pm

antoniop

Improve doc

- -3
- +3
./file-procs.tcl
- History
- Source
- Diff
./file-procs.tcl

1:34 pm

Revert to previous template::widget::file behavior of accepting input in a form of a list of 3 elements (e.g. without a .tmpfile in the request), but introduce validation so that we enforce all widget values to be in the proper format and the files to be "safe"

- -42
- +83
./file-procs.tcl
- History
- Source
- Diff
./file-procs.tcl
- -7
- +14
./test/data-procs.tcl
- History
- Source
- Diff
./test/data-procs.tcl
- -0
- +244
./test/file-procs.tcl
- History
- Source
- Diff
./test/file-procs.tcl
… 2 more files in changeset.

1:34 pm

antoniop

More
MAIN:antoniop:20220825113450
deleted 1 file
MAIN

file file-procs.tcl was initially added on branch oacs-5-10.

- -0
- +0
./test/file-procs.tcl
- History
- Source
./test/file-procs.tcl

Wednesday 24 Aug 2022

10:58 am

antoniop

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

- -19
- +4
./file-procs.tcl
- History
- Source
- Diff
./file-procs.tcl
… 2 more files in changeset.

Tuesday 23 Aug 2022

5:39 pm

antoniop

Incorporate feedback from downstream penetration tests:

do not skip basic validation in the file widget when a tmpfile is not found in the request.

- -47
- +54
./file-procs.tcl
- History
- Source
- Diff
./file-procs.tcl

Sunday 14 Aug 2022

10:05 am

gustafn

extended adp:icon handling

Added support for multiple classes,

Added more potentially reusabel icon names,

bumped version to 5.10.1d13

- -3
- +4
./style-procs.tcl
- History
- Source
- Diff
./style-procs.tcl
- -2
- +6
./tag-init.tcl
- History
- Source
- Diff
./tag-init.tcl
… 1 more file in changeset.

Saturday 13 Aug 2022

3:55 pm

gustafn

extended generic names by "user" and "list-alt"

- -1
- +9
./tag-init.tcl
- History
- Source
- Diff
./tag-init.tcl

Thursday 11 Aug 2022

1:05 pm

gustafn

whitespace changes

- -50
- +50
./tag-init.tcl
- History
- Source
- Diff
./tag-init.tcl

1:01 pm

gustafn

added new generic icon name: add-new-item

- -1
- +5
./tag-init.tcl
- History
- Source
- Diff
./tag-init.tcl

1:00 pm

gustafn

prefer parameter::get_from_package_key over fetching package_id first

- -7
- +9
./template-init.tcl
- History
- Source
- Diff
./template-init.tcl

Sunday 26 Jun 2022

9:30 pm

gustafn

fix false positive of regression test

- -1
- +1
./richtext-procs.tcl
- History
- Source
- Diff
./richtext-procs.tcl

1:06 pm

gustafn

removed code factored out to the separate "captcha" package

- -353
- +0
./captcha-procs.tcl
- History
- Source
- Diff
./captcha-procs.tcl
- -163
- +0
./test/captcha-procs.tcl
- History
- Source
- Diff
./test/captcha-procs.tcl
… 10 more files in changeset.

Saturday 25 Jun 2022

2:05 pm

gustafn

improve comments, such that is is clear what command to use instead

- -4
- +4
./deprecated-procs.tcl
- History
- Source
- Diff
./deprecated-procs.tcl

2:05 pm

gustafn

deactivate captcha test for the time being

- -0
- +1
./test/captcha-procs.tcl
- History
- Source
- Diff
./test/captcha-procs.tcl

Wednesday 22 Jun 2022

10:42 am

antoniop

Constrain captcha width to 100% of its parent's size

- -1
- +1
./captcha-procs.tcl
- History
- Source
- Diff
./captcha-procs.tcl

Wednesday 15 Jun 2022

8:54 pm

gustafn

whitespace changes

- -8
- +8
./parse-procs.tcl
- History
- Source
- Diff
./parse-procs.tcl

8:48 pm

gustafn

reduce useless warnings for template::adp_parse_tags

The problem was that template::adp_compile_chunk produces no output, when the parsed chunk contains only whitespace,

causing an error message in this case. The changed method shortcuts the behavior.

- -4
- +7
./parse-procs.tcl
- History
- Source
- Diff
./parse-procs.tcl

Monday 02 May 2022

2:03 pm

antoniop

Fix missing variable

- -1
- +1
./captcha-procs.tcl
- History
- Source
- Diff
./captcha-procs.tcl

Thursday 28 Apr 2022

12:59 pm

antoniop

Fix typo

- -2
- +1
./captcha-procs.tcl
- History
- Source
- Diff
./captcha-procs.tcl

Wednesday 27 Apr 2022

6:43 pm

antoniop

Provide an alternative exec-free captcha implementation using libgd and its Tcl wrapper https://github.com/flightaware/tcl.gd

This implementation will be preferred to the one using convert, when available.

- -23
- +152
./captcha-procs.tcl
- History
- Source
- Diff
./captcha-procs.tcl
… 1 more file in changeset.

Thursday 21 Apr 2022

1:34 pm

antoniop

Cleanup dummy commands and objects to avoid cross interactions between tests

- -0
- +1
./test/captcha-procs.tcl
- History
- Source
- Diff
./test/captcha-procs.tcl
… 1 more file in changeset.

Wednesday 20 Apr 2022

3:49 pm

antoniop

Go back supporting arbitrary options, potentially from custom user-defined widgets: these will be assumed to be expressed as name-value pairs and we will keep notifying such cases in the logfile