OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 73
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 74,868
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 28 Dec 2024
4:37 pm

gustafn

improved comments

Options
    • -5
    • +7
    ./tcl/utilities-procs.tcl
Friday 27 Dec 2024
7:25 pm

gustafn

Fixed bug in install-from-repository (issue #3472)

Install from repository (e.g., of /dotlrn) was horribly broken, see,

e.g., issue #3472. Furthermore, this bug was hard to debug, since it

showed up just during a complex installation attempts involving

install.xml, and it requires fetching from the repository. Therefore,

the debug rounds were quite time-consuming.

There were several problems involved:

1) dotlrn/install.xml was trying to set the theme to the

dotlrn-bootstrap3-theme, which was not loaded from the repository

2) The loading order was not correct, since the theme requires an

existing dotlrn instance to register the theme templates there.

3) The tests in install::xml::action::mount checking, if the package

was already mounted were incorrect, probably since many years. It

looks to me as some refactorings of the "get_node_id" semantics

(many years ago) were not reflected in this code. This bug let

the code assume, that the package was already mounted. Therefore,

the package was never mounted, causing a long tail of subsequent

issues.

4) the site_node::instantiate_and_mount call in

install::xml::action::mount was called with incorrect parameters,

causing overwriting of the site root node, leaving the site

completely unusable.

Bumped version number of acs-tcl to 5.10.2d1

Options
    • -2
    • +2
    ./acs-tcl.info
    • -8
    • +14
    ./tcl/install-procs.tcl
6:31 pm

gustafn

fixed overquoting in "ad_progress_base_end"

Options
    • -2
    • +8
    ./tcl/defs-procs.tcl
1:32 pm

gustafn

fixed cut&paste problem

Options
    • -1210
    • +0
    ./tcl/install-procs.tcl
1:09 pm

gustafn

reset to released version to keep differences little

Options
    • -1
    • +1201
    ./tcl/install-procs.tcl
    • -13
    • +9
    ./tcl/site-nodes-procs.tcl
  3. … 1 more file in changeset.
10:50 am

gustafn

keep theme-stetting for dotlrn themes in dotlrn, since it requires a dotlrn instance

but when the dotlrn is installed, it requires the dotlrn-theme package to be installed

Options
    • -0
    • +2
    ./tcl/site-nodes-procs.tcl
  2. … 3 more files in changeset.
10:22 am

gustafn

Continue working on the install.xml issue.

Options
    • -8
    • +9
    ./tcl/site-nodes-procs.tcl
10:01 am

gustafn

added more debugging info

Options
    • -2
    • +7
    ./tcl/install-procs.tcl
    • -2
    • +2
    ./tcl/site-nodes-procs.tcl
9:29 am

gustafn

undo one more recent change

Options
    • -3
    • +3
    ./tcl/install-procs.tcl
9:15 am

gustafn

undo recent change. This was not the problem

Options
    • -5
    • +1
    ./tcl/install-procs.tcl
9:00 am

gustafn

added debug statement

Options
    • -0
    • +1
    ./tcl/site-nodes-procs.tcl
Thursday 26 Dec 2024
7:25 pm

gustafn

try to get a non-empty context id

Options
    • -3
    • +7
    ./tcl/install-procs.tcl
6:56 pm

gustafn

added debugging line

Options
    • -1
    • +8
    ./tcl/install-procs.tcl
6:32 pm

gustafn

Fixed incorrect result handling from ::acs::site_node get_node_id

When

::acs::site_node get_node_id -url /$mount_point

is executed with a non-existing mount point, the node info of the

parent_id is returned. The code assumed that for such cases, the

resulting "object_id" member is empty. Since this affects only the

two action procs

install::xml::action::mount

install::xml::action::mount-existing

i have adjusted the behavior there.

Furthermore, some tests are now less mind-twisted.

Options
    • -13
    • +11
    ./tcl/install-procs.tcl
Tuesday 24 Dec 2024
5:27 pm

gustafn

improved log messages

Options
    • -2
    • +3
    ./tcl/apm-install-procs.tcl
Friday 13 Dec 2024
10:53 am

gustafn

avoid triggering exception, when provided host header field cannot be resolved.

Options
    • -2
    • +8
    ./tcl/security-procs.tcl
10:40 am

gustafn

avoid error, when page_contract is called without an ns_set and without an open connection

Options
    • -4
    • +8
    ./tcl/tcl-documentation-procs.tcl
Tuesday 26 Nov 2024
9:18 am

gustafn

Avoid calls to deprecated NaviServer functions

Options
    • -1
    • +0
    ./tcl/00-icanuse-procs.tcl
    • -1
    • +1
    ./tcl/cluster-procs.tcl
    • -5
    • +5
    ./tcl/deprecated-procs.tcl
    • -22
    • +1
    ./tcl/security-procs.tcl
Monday 25 Nov 2024
2:20 pm

gustafn

removed deprecated "ns_set new" by "ns_set create"

Options
    • -2
    • +2
    ./tcl/html-email-procs.tcl
    • -19
    • +4
    ./tcl/utilities-procs.tcl
2:18 pm

gustafn

moved stuff for AOLserver 2 emulation to deprecated procs, mark it explicitly as deprecated

Options
    • -173
    • +0
    ./tcl/aolserver-3-procs.tcl
    • -3
    • +179
    ./tcl/deprecated-procs.tcl
Wednesday 13 Nov 2024
9:43 am

gustafn

prefer more efficient approach to iterate over all key/values of an ns_set

Options
    • -18
    • +5
    ./tcl/tcl-documentation-procs.tcl
Thursday 07 Nov 2024
12:54 pm

antoniop

Extend user_message feature so that a "severity" information can be passed alongside the message

This allows theme templates to color code messages according to their severity. Severity follows the Bootstrap nomenclature of "info", "success", "warning" and "danger".

Default severity has been set to "success" consistent with styling applied so far by OpenACS to the user messages.

Options
    • -3
    • +3
    ./acs-tcl.info
    • -4
    • +14
    ./tcl/utilities-procs.tcl
  3. … 7 more files in changeset.
Tuesday 29 Oct 2024
4:58 pm

antoniop

Extend test suite to cover :multiple and :array

Options
    • -0
    • +93
    ./tcl/test/acs-tcl-test-procs.tcl
Monday 28 Oct 2024
7:05 pm

gustafn

improved documentation, removed AOLserver stuff

Options
    • -140
    • +81
    ./tcl/acs-cache-procs.tcl
5:04 pm

gustafn

Remove AOLserver cruft

- reduced complexity of registering/invoking filters

- move more deprecated procs in acs-tcl to acs-tcl/tcl/deprecated-procs.tcl

Options
    • -3
    • +3
    ./acs-tcl.info
    • -2
    • +2
    ./tcl/admin-procs.tcl
    • -3
    • +103
    ./tcl/deprecated-procs.tcl
    • -3
    • +3
    ./tcl/request-processor-init.tcl
    • -137
    • +8
    ./tcl/request-processor-procs.tcl
  6. … 4 more files in changeset.
3:25 pm

antoniop

Consider documentation the presence of an author

Options
    • -1
    • +2
    ./tcl/test/doc-check-procs.tcl
Sunday 27 Oct 2024
5:51 pm

gustafn

New API function: ad_docbook_xml_to_html

This function converts DocBook XML as used in the OpenACS

documentation to HTML. This is not a full implementation of all

possible DocBook markup, but just a subset sufficient for rendering a

substantial subset of the OpenACS documentation.

The function can be used via

set html [ad_html_text_convert -from application/docbook+xml -to text/html $text]

or

set txt [ad_html_text_convert -from application/docbook+xml -to text/plain $text]

Options
    • -2
    • +159
    ./tcl/text-html-procs.tcl
5:50 pm

gustafn

fixedm typo in comment

Options
    • -1
    • +1
    ./tcl/cluster-procs.tcl
Thursday 24 Oct 2024
6:53 pm

gustafn

rework register_icanuse "domDoc asTclValue" since w cannot use apm_version_names_compare during startup

Options
    • -1
    • +9
    ./tcl/00-icanuse-procs.tcl
5:36 pm

antoniop

Extend test suite

Options
    • -0
    • +7
    ./tcl/test/acs-tcl-test-procs.tcl