OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 72
Last Commit:
Commits this week: 1
Total Lines of Code (LoC): 68,337
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 12 Jun
8:01 pm

gustafn

fix once more handling of internal redirects in error cases

many thanks to thomas renner!

Options
    • -2
    • +2
    ./tcl/request-processor-procs.tcl
Monday 07 Jun
3:55 pm

antoniop

Remove message keys sanitizing, which does not belong here

Options
    • -9
    • +1
    ./tcl/utilities-procs.tcl
Thursday 27 May
9:08 pm

gustafn

use the right message key

VS: ----------------------------------------------------------------------

Options
    • -2
    • +2
    ./tcl/tcl-documentation-procs.tcl
9:07 pm

gustafn

Fixed a bug in the request processor, when URL is /%3F

The problem was that /%3F corresponds to a URL which is literally '/?'

(question mark is not the separator for query variables). In this case

a "string match" operation to determine the suffix based on this

string will lead to unexpected characters since '?' is a match

character. This lead in turn to a problem with redirects to the

internally redirect of custom error pages. So, in this case (and

probably others) the custom error page was not displayed.

Options
    • -13
    • +27
    ./tcl/request-processor-procs.tcl
Sunday 23 May
7:57 pm

gustafn

improved spelling

Options
    • -1
    • +1
    ./tcl/00-icanuse-procs.tcl
    • -3
    • +3
    ./tcl/deprecated-procs.tcl
    • -1
    • +1
    ./tcl/form-processing-procs.tcl
    • -2
    • +2
    ./tcl/navigation-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs.tcl
    • -1
    • +1
    ./tcl/test/proxy-test-procs.tcl
7:56 pm

gustafn

Added page_contract filter "object_id"

This change adds the page_contract filter "object_id", which validates

values whether these are syntactically acceptable as object_ids in

PostgreSQL and Oracle.

Note that before one is able to use the filter, the server has to be

restarted. Otherwise, when e.g. "apm/version_reload.tcl" would be

executed with the new filter, it would fail. So, one has to be careful

on update scripts, when people upgrade from old version not to create

a blocking mutual blocking condition.

Options
    • -2
    • +2
    ./acs-tcl.info
    • -1
    • +2
    ./catalog/acs-tcl.de_DE.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-tcl.en_US.ISO-8859-1.xml
    • -2
    • +30
    ./tcl/tcl-documentation-procs.tcl
    • -1
    • +5
    ./tcl/test/acs-tcl-test-procs.tcl
7:24 pm

gustafn

improve comments

Options
    • -4
    • +19
    ./tcl/request-processor-procs.tcl
Thursday 20 May
10:49 am

gustafn

new variant of zip_file_contains_valid_filenames independent of "unuip -l"

unfortunately the behavior of "unzip -l" differs not only between

macOS and Linux, but even between different linux families, although

showing the same version.

Options
    • -12
    • +25
    ./tcl/utilities-procs.tcl
Wednesday 19 May
9:04 am

trenner

fix typo

Options
    • -2
    • +2
    ./tcl/utilities-procs.tcl
Tuesday 18 May
10:01 pm

gustafn

improve handling of zip files that contain filenames, which are not valid UTF-8

Options
    • -2
    • +33
    ./tcl/utilities-procs.tcl
Wednesday 05 May
5:28 pm

antoniop

In acs-tcl.documentation__check_proc_doc automated test, if the test fails on procs that belong to namespaces outside the OpenACS codebase, just issue a warning rather than failing

Options
    • -2
    • +16
    ./tcl/test/doc-check-procs.tcl
Monday 03 May
11:19 am

gustafn

improved listing of covered procs

Options
    • -0
    • +8
    ./tcl/test/acs-tcl-test-procs.tcl
10:55 am

gustafn

added minor debugging aids, make disk-cache more similar to ns_cache

Options
    • -2
    • +2
    ./tcl/request-processor-procs.tcl
    • -1
    • +2
    ./tcl/site-nodes-procs.tcl
    • -3
    • +3
    ./tcl/utilities-procs.tcl
Friday 23 Apr
11:01 am

gernst

Remove non-functional "double click protection" in order to remove a potential attack vector

Options
    • -14
    • +0
    ./tcl/form-processing-procs.tcl
    • -16
    • +1
    ./tcl/tcl-documentation-procs.tcl
Thursday 22 Apr
8:47 pm

gustafn

added page contract filter "printable" to avoid passing of binary values to certain pages

Options
    • -2
    • +2
    ./acs-tcl.info
    • -1
    • +20
    ./tcl/tcl-documentation-procs.tcl
    • -12
    • +26
    ./tcl/test/acs-tcl-test-procs.tcl
Tuesday 13 Apr
2:42 pm

gustafn

removed unclear test

Options
    • -45
    • +66
    ./tcl/test/proxy-test-procs.tcl
11:02 am

hectorr

Whitespace changes + Editor hints

Options
    • -6
    • +10
    ./tcl/test/proxy-test-procs.tcl
10:59 am

hectorr

Relax error level

Options
    • -0
    • +1
    ./tcl/test/proxy-test-procs.tcl
Friday 09 Apr
8:59 am

gustafn

whitespace changes

Options
    • -9
    • +8
    ./tcl/site-node-apm-integration-procs.tcl
  2. … 2 more files in changeset.
Tuesday 30 Mar
5:44 pm

hectorr

Mark 'whos_online::interval' as public, as it is used in 'acs-subsite'

Options
    • -2
    • +2
    ./tcl/whos-online-procs.tcl
5:41 pm

hectorr

Make a bunch of apm procs public, as they are used in 'acs-admin'.

Could be worth considering moving the ones used only in 'acs-admin' to that package, and making them private again, leaving public only those who may be useful to other packages/applications (i.e. CI/CD logic).

Options
    • -2
    • +2
    ./tcl/admin-procs.tcl
    • -5
    • +5
    ./tcl/apm-file-procs.tcl
    • -17
    • +17
    ./tcl/apm-install-procs.tcl
    • -4
    • +4
    ./tcl/apm-procs.tcl
    • -2
    • +2
    ./tcl/apm-xml-procs.tcl
4:45 pm

hectorr

Mark 'apm_application_new_checkbox' as public, as it is used in the site-map

Options
    • -2
    • +2
    ./tcl/apm-procs.tcl
4:43 pm

hectorr

Mark 'sec_get_random_cached_token_id' as public, as it is used in 'acs-subsite'

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
4:40 pm

hectorr

Mark 'apm_mark_version_for_reload' as public, as it is used in 'acs-automated-testing'

Options
    • -2
    • +2
    ./tcl/apm-procs.tcl
3:16 pm

hectorr

Check also token value in nsv in 'secret_tokens_get' test case

Options
    • -3
    • +5
    ./tcl/test/test-set-cookie-procs.tcl
9:28 am

gustafn

fix and extend regression test, when bread-crumb label needs quoting

Options
    • -12
    • +10
    ./tcl/test/navigation-procs.tcl
Monday 29 Mar
1:59 pm

hectorr

Whitespace changes

Options
    • -5
    • +4
    ./tcl/test/test-set-cookie-procs.tcl
1:57 pm

hectorr

Change test category and rollback after execution

Options
    • -3
    • +3
    ./tcl/test/test-set-cookie-procs.tcl
1:48 pm

hectorr

Add new 'secret_tokens_get' and refactor 'test_set_cookie_procs' to include cases handled by the deleted ancient tests in 'acs-admin/www/test/signed-cookies-test'

Options
    • -64
    • +118
    ./tcl/test/test-set-cookie-procs.tcl
Monday 22 Mar
12:00 pm

gustafn

Improve robustness over invalid configurations

Previouly, the configuration of invalid hostnames (i.e. hostnames,

which cannot be resolved via the OS means) for a network driver

lead to runtime errors under certain conditions.

Options
    • -48
    • +59
    ./tcl/security-procs.tcl