OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 4
Total Committers: 72
Last Commit:
Commits this week: 4
Total Lines of Code (LoC): 68,337
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 27 Nov
10:52 am

gustafn

added example line to ease spotting of the creation of unnamed mutexes

Options
    • -0
    • +1
    ./tcl/tcltrace-init.tcl
10:27 am

gustafn

provide name for mutexes to ease spotting potential locks

Options
    • -4
    • +3
    ./tcl/tcl-documentation-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs.tcl
Tuesday 24 Nov
8:02 pm

gustafn

avoid burst cache hits by using nsvs instead of ns_cache for secret token caching

The problem with the prevision version was that ns_cache has no equivalent

to nsv_array to get in an atomic fashion all key value pairs from the cache.

thefore, for the per-thread caching, a tight loop was used processing

the result of ns_cache_keys. If this was necessary in a high number of

threads, higher lock times were possible (~100ms). The new version

should not face this problem.

Options
    • -26
    • +66
    ./tcl/security-procs.tcl
Monday 23 Nov
3:11 pm

antoniop

Important, although very simple reform in the page-contract filters: do not kill the case in the filter specs, or filters such as "w:oneof(One|Two)" or "locale:oneof(en_US|de_DE)" would not have a chance to match

Note that this makes the contracts stricter with respect to case, which might break obscure use cases...

Options
    • -2
    • +4
    ./tcl/tcl-documentation-procs.tcl
Saturday 21 Nov
5:45 pm

gustafn

avoid to try to return an error to client in request processor when connection was already closed

Options
    • -1
    • +6
    ./tcl/request-processor-procs.tcl
Friday 20 Nov
12:53 pm

gustafn

add hook to write changed blueprints

Options
    • -3
    • +12
    ./tcl/apm-procs.tcl
12:52 pm

gustafn

fix typo

Options
    • -2
    • +2
    ./tcl/tcl-documentation-procs.tcl
Tuesday 17 Nov
1:02 pm

gustafn

report changes in blueprint size when reloading files

Options
    • -4
    • +23
    ./tcl/apm-procs.tcl
1:01 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./tcl/utilities-procs.tcl
1:00 pm

gustafn

whitespace changes

Options
    • -1
    • +4
    ./tcl/proxy-procs.tcl
Wednesday 11 Nov
1:37 pm

hectorr

Fix test category misplacement

Options
    • -2
    • +2
    ./tcl/test/text-html-procs.tcl
Tuesday 10 Nov
1:39 pm

hectorr

Take care of string values when these are longer than the randomized length

Options
    • -0
    • +4
    ./tcl/test/text-html-procs.tcl
1:08 pm

hectorr

Whitespace changes

Options
    • -12
    • +12
    ./tcl/test/text-html-procs.tcl
1:07 pm

hectorr

Set tests as 'production_safe'

Options
    • -4
    • +4
    ./tcl/test/text-html-procs.tcl
Saturday 07 Nov
4:55 pm

gustafn

add i-can-use rule for "ns_urlencode -part oauth1"

Options
    • -0
    • +1
    ./tcl/00-icanuse-procs.tcl
Sunday 01 Nov
7:04 pm

gustafn

revert escaped change

Options
    • -2
    • +2
    ./tcl/apm-procs.tcl
6:58 pm

gustafn

make proxy exec more compatible with tcl exec: support flags "-ignorestderr" and "--"

Options
    • -3
    • +2
    ./tcl/apm-procs.tcl
    • -2
    • +10
    ./tcl/proxy-procs.tcl
Thursday 29 Oct
5:24 pm

hectorr

Do rollback after test run

Options
    • -1
    • +1
    ./tcl/test/navigation-procs.tcl
Wednesday 28 Oct
4:39 pm

hectorr

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

Options
    • -3
    • +3
    ./tcl/00-icanuse-procs.tcl
    • -2
    • +2
    ./tcl/01-database-procs.tcl
    • -2
    • +2
    ./tcl/10-charset-compat-procs.tcl
    • -2
    • +2
    ./tcl/20-memoize-init.tcl
    • -1
    • +1
    ./tcl/30-xml-utils-procs.tcl
    • -2
    • +2
    ./tcl/acs-cache-procs.tcl
    • -2
    • +2
    ./tcl/acs-permissions-procs.tcl
    • -3
    • +3
    ./tcl/apm-file-procs.tcl
    • -3
    • +3
    ./tcl/apm-install-procs.tcl
    • -4
    • +4
    ./tcl/apm-procs.tcl
    • -1
    • +1
    ./tcl/callback-procs.tcl
    • -5
    • +5
    ./tcl/deprecated-procs.tcl
    • -5
    • +5
    ./tcl/ds-stub-procs.tcl
    • -2
    • +2
    ./tcl/exception-procs.tcl
    • -7
    • +7
    ./tcl/form-processing-procs.tcl
  16. … 44 more files in changeset.
Friday 23 Oct
6:20 pm

gustafn

Fix for issue #3446

This fixes a bug, where the ordering of the site-nodes in the answer

set of the select_child_site_nodes query in site_node::update_cache

led to disappearing entries in the site map, when additional

items were added. This bug happened in the old-style

(nsv-based) site-node impementation, which is used, when no

xotcl is available.

Many thanks to Keith Paskett for debugging and the fix.

Options
    • -16
    • +19
    ./tcl/site-nodes-procs-postgresql.xql
Tuesday 20 Oct
2:29 pm

hectorr

Rework of the 'test_apm_parameter__register' and 'test_apm_package_instance__new' test cases.

Ignored disabled packages in both tests.

Check all enabled packages in 'test_apm_package_instance__new', instead of picking just one randomly, so all issues instantiating packages are found at once.

Indentation changes.

Options
    • -22
    • +40
    ./tcl/test/acs-tcl-apm-procs.tcl
2:21 pm

hectorr

Ignore singleton packages that are already instantiated on 'apm_package_instance_new', preventing the execution of the after-instantiate callbacks

Options
    • -9
    • +23
    ./tcl/apm-procs.tcl
9:59 am

gustafn

Convert content of host header field to lower case, since domain names are case insensitive

Options
    • -1
    • +6
    ./tcl/security-procs.tcl
Monday 19 Oct
5:19 pm

antoniop

Keep tolerating parameter_id specified as unnamed argument in legacy code and warn about deprecation

Options
    • -2
    • +20
    ./tcl/apm-procs.tcl
4:54 pm

hectorr

Adapt tests to the new behaviour of 'apm_parameter_unregister'

Options
    • -3
    • +3
    ./tcl/test/apm-parameter-test-procs.tcl
4:37 pm

hectorr

Do not add admin_node to the component bars if it is empty

Options
    • -3
    • +12
    ./tcl/test/navigation-procs.tcl
2:55 pm

hectorr

Reduce error level to warning in the nullchat test case, as the issue is driver related

Options
    • -1
    • +1
    ./tcl/test/db-proc-test-procs.tcl
Saturday 17 Oct
8:19 pm

gustafn

Allow in testing mode always a "form" tag, independent of the antispam parameter settings

This addresses an issue, when one is running the regression test for xowiki on installations

with plain dotlrn, where otherwise the validator complains about the form tag in a form.

There should be a nicer way of doing this...

Options
    • -9
    • +17
    ./tcl/text-html-procs.tcl
6:47 pm

gustafn

allow calling apm_parameter_unregister without "parameter_id"

previously, it was allowed to call it with an empty parameter_id, but not without it

Options
    • -4
    • +13
    ./tcl/apm-procs.tcl
    • -17
    • +0
    ./tcl/apm-procs.xql
9:20 am

gustafn

prefer db_0or1row for exists-queries

Options
    • -7
    • +6
    ./tcl/apm-procs.tcl