OpenACS / openacs-4 / packages / acs-tcl / tcl

security-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 23
Last Commit: 26 Dec
Commits this week: 0
Total Lines of Code (LoC): 3,710
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Sep 2021
2:46 pm

gustafn

Stronger password hashes for OpenACS

This change introduces the possibility to use either the classical

OpenACS password hash algorithm "salted-sha1" or the SCRAM passord

function "scram-sha-256". The latter can be used by (a) using the

most recent version of NaviServer (from Sept 28, 2021 or newer) and

(b) by configuring the password hash preferences via Kernel package

parameter "PasswordHashAlgorithm". The package parameter can contain a

list of multiple hash algorithms in preference order. The most

preferred available algorithm is chosen.

By default, the "PasswordHashAlgorithm" is "salted-sha1", and the

behavior is as before. After upgrading to the new version of acs-tcl

and acs-kernel, the preference list can be configured. When a user

logs in and the preferred available algorithm is different from the

previously used algorithm, the upgrade is performed for the user

automatically.

The usage of SHA1 in OpenACS is easily target of security audits (see

[1]). The biggest danger is that if somebody gets full access to the

"users" table (e.g. when decommissioning a hard disk). In this case

the hashes can be attacked with dictionaries by using some crypto

hardware (when someone gets raw access to the DB, one has usually some

other big problems). However, by using the "scram-sha-256" hash

function this danger is substantially reduced. This function computes

a password hash using PBKDF2 (Password-Based Key Derivation Function

2). This function is used to reduce vulnerabilities of brute-force

attacks against password hashes. The hash function of SCRAM is PBKDF2

[RFC2898] with HMAC as the pseudorandom function (PRF) and with dkLen

== output length of HMAC == output length of the digest function. So,

it uses a better hash algorithm (sha-256 vs. sha1) and applies this a

high number of times (15K times for a password hash computation).

NaviServer supports as well the even better SCRYPT algorithm, but this

is only available when NaviServer is compiled with OpenSSL 3.0 or

newer. On the contrary, scram-sha-256 (actually PKCS5_PBKDF2_HMAC) is

available since OpenSSL 1.0.0 (2015).

All the improved hash functions require NaviServer with its tight

integration to the crypto functions of OpenSSL.

[1] https://openacs.org/forums/message-view?message_id=5522562

Options
    • -14
    • +103
    ./security-procs.tcl
  2. … 6 more files in changeset.
Tuesday 30 Mar 2021
4:43 pm

hectorr

Mark 'sec_get_random_cached_token_id' as public, as it is used in 'acs-subsite'

Options
    • -2
    • +2
    ./security-procs.tcl
Monday 22 Mar 2021
12:00 pm

gustafn

Improve robustness over invalid configurations

Previouly, the configuration of invalid hostnames (i.e. hostnames,

which cannot be resolved via the OS means) for a network driver

lead to runtime errors under certain conditions.

Options
    • -48
    • +59
    ./security-procs.tcl
Monday 22 Feb 2021
3:35 pm

antoniop

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -6
    • +6
    ./security-procs.tcl
  2. … 2 more files in changeset.
Friday 19 Feb 2021
11:11 am

gustafn

remove protection "private", since function has to be called from other packages

Options
    • -4
    • +4
    ./security-procs.tcl
  2. … 6 more files in changeset.
Thursday 18 Feb 2021
3:41 pm

gustafn

mark functions called only internally as private

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 15 more files in changeset.
Wednesday 17 Feb 2021
9:52 pm

gustafn

improve comment

Options
    • -4
    • +4
    ./security-procs.tcl
Saturday 06 Feb 2021
9:43 pm

gustafn

avoid array notation for per_thread caches to ease flushing

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 5 more files in changeset.
Friday 22 Jan 2021
5:46 pm

gustafn

make call more robust in case "location" is not provided via config file

Options
    • -2
    • +2
    ./security-procs.tcl
Thursday 14 Jan 2021
7:20 pm

gustafn

use 'self' for "security::csp::require object-src" instead of 'none' since the latter is non-incremental

Options
    • -2
    • +2
    ./security-procs.tcl
Tuesday 12 Jan 2021
6:36 pm

antoniop

Fix acs-tcl.logout_from_everywhere test case and support again invalidating of all existing user logins, useful e.g. to make sure no device still holds a valid login when we change our password on a device

Options
    • -15
    • +24
    ./security-procs.tcl
Saturday 26 Dec 2020
4:32 pm

gustafn

Don't rely on configured "location" value of driver, since this does not work for virtual hosting

Instead, get the "host", "port" and "defaultport" directly from "ns_driver info" when available

Options
    • -9
    • +35
    ./security-procs.tcl
1:05 pm

gustafn

"ns_driver info" has no key "host", but "address" (which might be multiple addresses)

Options
    • -2
    • +2
    ./security-procs.tcl
Tuesday 24 Nov 2020
8:02 pm

gustafn

avoid burst cache hits by using nsvs instead of ns_cache for secret token caching

The problem with the prevision version was that ns_cache has no equivalent

to nsv_array to get in an atomic fashion all key value pairs from the cache.

thefore, for the per-thread caching, a tight loop was used processing

the result of ns_cache_keys. If this was necessary in a high number of

threads, higher lock times were possible (~100ms). The new version

should not face this problem.

Options
    • -26
    • +66
    ./security-procs.tcl
Wednesday 28 Oct 2020
4:39 pm

hectorr

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

Options
    • -4
    • +4
    ./security-procs.tcl
  2. … 58 more files in changeset.
Tuesday 20 Oct 2020
9:59 am

gustafn

Convert content of host header field to lower case, since domain names are case insensitive

Options
    • -1
    • +6
    ./security-procs.tcl
Saturday 17 Oct 2020
9:19 am

gustafn

improve warning message in case invalid characters are passed in

Options
    • -2
    • +2
    ./security-procs.tcl
Monday 28 Sep 2020
10:49 pm

gustafn

whitespace changes

Options
    • -8
    • +16
    ./security-procs.tcl
Saturday 26 Sep 2020
2:20 pm

gustafn

relax default samesite setting for login and session cookies to lax

This change was made because otherwise the "keep me logged in"

is often lost, e.g. also with toplevel navigation requests

(e.g. when navigating to the site via Google)

Options
    • -2
    • +2
    ./security-procs.tcl
Saturday 08 Aug 2020
1:19 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 16 more files in changeset.
Tuesday 21 Jul 2020
3:58 pm

gustafn

prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

Options
    • -3
    • +3
    ./security-procs.tcl
  2. … 18 more files in changeset.
Friday 03 Jul 2020
9:27 am

gustafn

improve spelling: move closer to the linux documentation recommendations

Options
    • -4
    • +4
    ./security-procs.tcl
  2. … 34 more files in changeset.
Saturday 20 Jun 2020
11:48 am

gustafn

report peeraddr and URL in warning, add comment

Options
    • -2
    • +6
    ./security-procs.tcl
11:41 am

gustafn

fine tuing for ad_log vs ns_log

Options
    • -3
    • +3
    ./security-procs.tcl
Friday 22 May 2020
2:18 pm

gustafn

don't depend on the node-id cache, which is only available, when xotcl-core is loaded

Options
    • -3
    • +3
    ./security-procs.tcl
  2. … 4 more files in changeset.
Tuesday 19 May 2020
9:15 pm

gustafn

acs::per_request_cache: standardize per-request caching

- added per-request cache verfsy similar to acs::per_thread_cache

- use per-request-cache on several occasions

- bump version number of acs-tcl to 5.10.0d35

Options
    • -8
    • +7
    ./security-procs.tcl
  2. … 9 more files in changeset.
Sunday 17 May 2020
7:04 pm

gustafn

fix typos

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 1 more file in changeset.
Wednesday 13 May 2020
12:28 pm

gustafn

move ad_get_host_node_map and security-locations-host-names from db_cache_pool to partitioned cache

Options
    • -8
    • +9
    ./security-procs.tcl
  2. … 3 more files in changeset.
Friday 08 May 2020
2:58 pm

gustafn

update comments concering CSP "report-to" directive

Options
    • -3
    • +7
    ./security-procs.tcl
Sunday 26 Jan 2020
6:10 pm

gustafn

remove useless semicolon

Options
    • -6
    • +6
    ./security-procs.tcl