• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove leftovers

Whitespace changes

Add new test 'acs_subsite_attributes' covering the 'attribute::add', 'attribute::exists_p' and 'attribute::delete' procs

prefer ns_dbquotevalue over db_quote, mark latter as deprecated

  1. … 3 more files in changeset.
improve listing of test coverage

  1. … 17 more files in changeset.
make listing of tested procs more complete

  1. … 11 more files in changeset.
make end of options explicit

  1. … 12 more files in changeset.
address issue #3456

fix typos

fix for issue #3455

add explicit cast to all max_n_rels with value null to increase readability and to ease function disambiguation

    • -11
    • +11
    ./sql/postgresql/user-profiles-create.sql
  1. … 4 more files in changeset.
Add missing var

Add include contract

Whitespace cleanup

Remove irrelevant comment

Port of downstream customization: don't lose the return URL when one tries to join a community before login

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

  1. … 56 more files in changeset.
remove calls to deprecated proc acs_lookup_magic_object (use acs_magic_object instead)

  1. … 2 more files in changeset.
prefer db_0or1row for exists-queries

improve message wording for message key

    • -1
    • +1
    ./catalog/acs-subsite.de_DE.ISO-8859-1.xml
Add page contract

    • -5
    • +5
    ./www/admin/group-types/groups-list.tcl
don't rely on uppercase header field names

  1. … 10 more files in changeset.
switch to simple new group::update call with dict as argument

This change fixes as well a bug in install::xml::action::set-join-policy

since group::get returns a member "text" which is not accepted by

group::update.

  1. … 3 more files in changeset.
support passing a dict as argument to "group::update" (not only array)

prefer db_0or1row +"where exists" over db_string + "select case"

  1. … 3 more files in changeset.
Improve sql portability

    • -12
    • +15
    ./tcl/test/acs-subsite-procs.tcl
  1. … 1 more file in changeset.
Replace limit with a portable idiom

Make apm callbacks private and move them together with the others

When a new group is created, flush all the group::get_id caches with the same name so that the new group has a chance to be retrieved

Note that it is wrong to assume a group_name will be unique, although this is normally not far from the truth in our everyday practice

Cover more group api

this also exposes a potential problem with group::get_id when a group is created, deleted, and then a new one is created with the same name (e.g. executing the test multiple times). As the memoize cache is not maintained, the returned group_id will be incorrect.