OpenACS / openacs-4 / packages

acs-subsite

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 79
Last Commit: 20 Dec
Commits this week: 0
Total Lines of Code (LoC): 49,839
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 03 Dec 2020
2:36 pm

antoniop

Add missing var

Options
    • -0
    • +1
    ./www/admin/rel-segments/elements-display.tcl
2:30 pm

antoniop

Add include contract

Options
    • -1
    • +7
    ./www/admin/rel-segments/elements-display.tcl
Monday 23 Nov 2020
3:55 pm

antoniop

Whitespace cleanup

Options
    • -5
    • +5
    ./www/register/user-join.tcl
3:55 pm

antoniop

Remove irrelevant comment

Options
    • -3
    • +1
    ./www/register/user-join.tcl
3:55 pm

antoniop

Port of downstream customization: don't lose the return URL when one tries to join a community before login

Options
    • -2
    • +12
    ./www/register/user-join.tcl
Wednesday 28 Oct 2020
4:39 pm

hectorr

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

Options
    • -2
    • +2
    ./tcl/apm-callback-procs.tcl
    • -2
    • +2
    ./tcl/attribute-procs.tcl
    • -2
    • +2
    ./www/shared/ajax/chat.tcl
  4. … 56 more files in changeset.
Saturday 17 Oct 2020
6:41 pm

gustafn

remove calls to deprecated proc acs_lookup_magic_object (use acs_magic_object instead)

Options
    • -2
    • +2
    ./www/admin/users/new.tcl
    • -2
    • +2
    ./www/shared/parameters.tcl
  3. … 2 more files in changeset.
6:40 pm

gustafn

prefer db_0or1row for exists-queries

Options
    • -4
    • +2
    ./tcl/group-procs.tcl
Wednesday 30 Sep 2020
7:24 pm

gustafn

improve message wording for message key

Options
    • -1
    • +1
    ./catalog/acs-subsite.de_DE.ISO-8859-1.xml
11:14 am

antoniop

Add page contract

Options
    • -5
    • +5
    ./www/admin/group-types/groups-list.tcl
Monday 28 Sep 2020
11:04 pm

gustafn

don't rely on uppercase header field names

Options
    • -2
    • +2
    ./www/admin/configure.tcl
  2. … 10 more files in changeset.
Sunday 27 Sep 2020
7:56 pm

gustafn

switch to simple new group::update call with dict as argument

This change fixes as well a bug in install::xml::action::set-join-policy

since group::get returns a member "text" which is not accepted by

group::update.

Options
    • -2
    • +2
    ./acs-subsite.info
    • -4
    • +3
    ./www/admin/configure.tcl
    • -2
    • +1
    ./www/admin/subsite-add.tcl
  4. … 3 more files in changeset.
1:12 pm

gustafn

support passing a dict as argument to "group::update" (not only array)

Options
    • -12
    • +19
    ./tcl/group-procs.tcl
Thursday 03 Sep 2020
11:16 am

gustafn

prefer db_0or1row +"where exists" over db_string + "select case"

Options
    • -5
    • +3
    ./tcl/attribute-procs.tcl
  2. … 3 more files in changeset.
Tuesday 01 Sep 2020
7:37 pm

antoniop

Improve sql portability

Options
    • -5
    • +7
    ./tcl/attribute-procs.tcl
    • -4
    • +6
    ./tcl/group-procs.tcl
    • -6
    • +10
    ./tcl/group-type-procs.tcl
    • -3
    • +6
    ./tcl/subsite-procs.tcl
    • -12
    • +15
    ./tcl/test/acs-subsite-procs.tcl
  6. … 1 more file in changeset.
4:32 pm

antoniop

Replace limit with a portable idiom

Options
    • -5
    • +5
    ./tcl/group-procs.tcl
Monday 31 Aug 2020
2:42 pm

antoniop

Make apm callbacks private and move them together with the others

Options
    • -0
    • +70
    ./tcl/apm-callback-procs.tcl
    • -73
    • +1
    ./tcl/subsite-procs.tcl
Friday 28 Aug 2020
6:45 pm

antoniop

When a new group is created, flush all the group::get_id caches with the same name so that the new group has a chance to be retrieved

Note that it is wrong to assume a group_name will be unique, although this is normally not far from the truth in our everyday practice

Options
    • -1
    • +7
    ./tcl/group-procs.tcl
6:42 pm

antoniop

Cover more group api

this also exposes a potential problem with group::get_id when a group is created, deleted, and then a new one is created with the same name (e.g. executing the test multiple times). As the memoize cache is not maintained, the returned group_id will be incorrect.

Options
    • -1
    • +18
    ./tcl/test/acs-subsite-procs.tcl
5:25 pm

antoniop

Increase proc coverage

Options
    • -1
    • +3
    ./tcl/test/acs-subsite-procs.tcl
Tuesday 25 Aug 2020
3:42 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./tcl/test/acs-subsite-procs.tcl
3:38 pm

antoniop

acs-lang reform

Provide an optional object_id which can be used to register message keys that will be bound to the lifecycle of an acs-object. When the object is deleted, so will the message key.

This is useful for groups that automatically define a message key for their pretty name. Tcl api was already aware of this and would cleanup such message keys, but other idioms e.g. stored procedures used to delete groups would leave leftovers behind. These can become relatively numerous on group-intensive systems such as LEARN.

Other future usages for this new feature might be the automatic localization of xowiki FormPage properties.

Options
    • -3
    • +3
    ./acs-subsite.info
    • -2
    • +5
    ./tcl/group-procs.tcl
  3. … 8 more files in changeset.
2:57 pm

antoniop

New test checking that no leftover groups localizations are still there on the system

Options
    • -1
    • +16
    ./tcl/test/acs-subsite-procs.tcl
2:43 pm

antoniop

Cleanup test message key

Options
    • -1
    • +4
    ./tcl/test/acs-subsite-procs.tcl
2:40 pm

antoniop

Test covering the automagical localization of group pretty names

Options
    • -1
    • +48
    ./tcl/test/acs-subsite-procs.tcl
Sunday 23 Aug 2020
2:16 pm

gustafn

fix for issue #3445

a broken query (without a table alias) was

in the .xql file, where the correct query was

in the source (where it was ignored). This

can be quite confusing. It is probably

a good idea to improve code locality

and use .xql just in cases, where the

query is NOT included in the source.

I took the opportunity to fix more such cases

in this file.

Many thanks to Tony Kirkham for the bug report.

CVS: ----------------------------------------------------------------------

Options
    • -104
    • +0
    ./tcl/attribute-procs.xql
Thursday 20 Aug 2020
4:11 pm

gustafn

flag that submission is coming via ajax

Options
    • -0
    • +1
    ./www/resources/core.js
3:54 pm

gustafn

fix cleanup typo

Options
    • -1
    • +1
    ./www/resources/core.js
3:50 pm

gustafn

whitespace changes

Options
    • -1114
    • +1113
    ./www/resources/core.js
3:49 pm

gustafn

new function: acs_ListBulkActionMultiFormClick()

//

// The function acs_ListBulkActionMultiFormClick() is similar to

// acs_ListBulkActionClick() but it iterates over all forms with the

// same name and submits the input elements of all such forms.

//

Options
    • -2
    • +46
    ./www/resources/core.js