• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add ad_include_contract (fixes automated tests)

Add ad_include_contract (fixes automated test)

Replace ad_decode idioms

  1. … 1 more file in changeset.
new parameter PersistentLoginDefault: let admin decide, whether default value in login box should be true of false

  1. … 1 more file in changeset.
add autocomplete hint as suggested by chrome

Add (trivial) ad_include_contract

Avoid unnecessary computations

Reuse return url over subsites, remove dummy sql

Use best practice list idiom

Avoid useless check

improve comment and provide warning, when kernel parameter is overruled

fix typo

remove obsolete flag "include_bio" from acs_user::get.

provide ad_include_contract for ADP include user-info

improve rowcount expressions

  1. … 76 more files in changeset.
Whitespace changes

  1. … 1 more file in changeset.
Remove superflous parentheses

  1. … 1 more file in changeset.
Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- Add mising @param

- Add missing @author

- @creation_date -> @creation-date

- @creation-user -> @author

- Fix typos

  1. … 8 more files in changeset.
Prefer literal in adp axpressions + Whitespace changes

  1. … 29 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 474 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 224 more files in changeset.
Prefer string comparison operators to 'string equal' and 'empty_string_p'

  1. … 5 more files in changeset.
Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

  1. … 15 more files in changeset.
make sure to call ad_script_abort after ad_returnredirect

  1. … 2 more files in changeset.
Bug fix: avoid confusion between command argument and option, when argument starts with "-"

  1. … 79 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7820 more files in changeset.
make field host_node_id optional to improve backward compatibility

Make sure message exists when dealing with a banned user

Provide more infrastructure support for host-node-maps for more flexible domain handling

- add optional -cookie_domain parameter to the following functions

ad_user_login

ad_user_logout

sec_generate_session_id_cookie

auth::issue_login (wrapper for ad_user_login)

if not specified, the functions are full backward compatible

- add optional parameter -host_node_id to auth::authenticate

which refers to the node_id in the host-node-map

- pass host_node_id from from/to register pages

TODO:

1) probably, sec_generate_session_id_cookie picks up the wrong

session_id via [ad_conn session_id]

2) check interaction with CookieDomain (probably, we need

must not pass host_node_id wheren CookieDomain is non-empty)

  1. … 7 more files in changeset.
- add optional parameter host_node_id (for future use)

- Reflow overlong lines

Modernize code (use ad_include_contract instead of manual checks)