• last updated 16 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 474 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 224 more files in changeset.
Prefer string comparison operators to 'string equal' and 'empty_string_p'

  1. … 5 more files in changeset.
Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

  1. … 15 more files in changeset.
make sure to call ad_script_abort after ad_returnredirect

  1. … 2 more files in changeset.
Bug fix: avoid confusion between command argument and option, when argument starts with "-"

  1. … 79 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7820 more files in changeset.
make field host_node_id optional to improve backward compatibility

Make sure message exists when dealing with a banned user

Provide more infrastructure support for host-node-maps for more flexible domain handling

- add optional -cookie_domain parameter to the following functions

ad_user_login

ad_user_logout

sec_generate_session_id_cookie

auth::issue_login (wrapper for ad_user_login)

if not specified, the functions are full backward compatible

- add optional parameter -host_node_id to auth::authenticate

which refers to the node_id in the host-node-map

- pass host_node_id from from/to register pages

TODO:

1) probably, sec_generate_session_id_cookie picks up the wrong

session_id via [ad_conn session_id]

2) check interaction with CookieDomain (probably, we need

must not pass host_node_id wheren CookieDomain is non-empty)

  1. … 7 more files in changeset.
- add optional parameter host_node_id (for future use)

- Reflow overlong lines

Modernize code (use ad_include_contract instead of manual checks)

Add link to package url for application groups in user-subsite "portlet"

Show member state in user-subsites listing

- Make file more modular

- Improve documentation

Use ad_include_contract to simplify code

  1. … 1 more file in changeset.
Improved adp-include user-subsites (which should be probably named

user-groups), used on pvt/home: instead of providing a broken link,

provide a link to the "members" page.

add missing rdbms types in .xql files (why wasn't this noticed before?)

  1. … 9 more files in changeset.
- replace "<include ... />" by "<include ... >", since adp parser in

AOLserver and NaviServer passes "/" as argument to the adp-include.

  1. … 5 more files in changeset.
- make boolean tests in .adp files more uniform

  1. … 53 more files in changeset.
- reduce dependencies on acs_object_party_privilege_map (for PostgreSQL)

file applications-oracle.xql was initially added on branch oacs-5-9.

    • -0
    • +0
    ./applications-oracle.xql
file applications-postgresql.xql was initially added on branch oacs-5-9.

    • -0
    • +0
    ./applications-postgresql.xql
- reduce dependencies on acs_object_party_privilege_map (on PostgreSQL)

file subsites-oracle.xql was initially added on branch oacs-5-9.

file subsites-postgresql.xql was initially added on branch oacs-5-9.

    • -0
    • +0
    ./subsites-postgresql.xql
- replace obsolete all_object_party_privilege_map by acs_object_party_privilege_map

  1. … 11 more files in changeset.
- strenthen token checking of login form

- protect against certain characters in return_url (the real solution is probably a fix in ad_form, which could cause some collateral damage)

  1. … 1 more file in changeset.
- fix an old bug in the user-info adp include. The old version assumed, that every url that is not starting with "http://" has to be prefixed with "http://". This is certainly a problem, when the user url starts with "https://"