• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- use tcl 8.5 idioms to improve readability and performance

- modernize tcl

- remove unneeded "expr" in side if-expressions

  1. … 12 more files in changeset.
- get rid of empty_string_p

  1. … 19 more files in changeset.
- change deprecated message from "Debug" to "Notice" level

- apm_get_package_files: add flag "-all", otherwise .apm file generation on openacs.org leads to incomplete package files

Moving handling NaviServer deprecated ns_info subcommands to 0-acs-init.tcl.

  1. … 2 more files in changeset.
- turn on warning for using deprecated commands, at least during the release phase

apm_include_file_p wont ignore anymore the upgrade directory in case data_model_files flag is set.

apm_get_package_files has new boolean switch -include_data_model_files in order to allow including/excluding sql files when looking for files within a package.

Taking .sql out of the list of ignored file extensions. Otherwise create/upgrade sql scripts are not loaded while installing/upgrading.

- added victor's patch to omit deprecated messages of "ns_info tcllib". Background: naviserver supports multiple (virtual) servers, which might have different tcllibs. Therefore, the preferred command to query this was moved to "ns_server ?-server s? tcllib" and "ns_info tcllib" was deprecated. From the OpenACS point of view, one wants to locate the actual library. Since the variable does not change, it is fine to store it in a per-thread variable which can be efficiently accessed.

  1. … 20 more files in changeset.
- add git to the list of ignored directories for apm loading

- use usual style non-poistional arguments in ad_proc

- use tcl 8.5 operations

- apm_file loader: ignore directories www/resources/, catalog/, upgrade/

- apm_file loader: ignore extensions .html .gif .png .jpg .ico .pdf .js .css .xsl .tgz .zip .gz .java .sql

- align implementation of apm_backup_file_p with documentation

- cleanup and minor performance improvements

    • -16
    • +13
    ./40-db-query-dispatcher-procs.tcl
  1. … 1 more file in changeset.
- abstract in check for existance of a command whether this is scripted or not

- use a more modern tcl command set

  1. … 10 more files in changeset.
- Fix for Tcl 8.5: OpenACS did overwrite the Tcl built-in command

"::apply" and broke therefore all scripts/libraries using it.

Changed the name of the OpenACS function to "ad_apply" and altered

the few occurances. The fix works as well with Tcl 8.4. The proper

fix for 8.5 would be to use instead of the function the expand

operator {*}

  1. … 3 more files in changeset.
- Fix for Tcl 8.5: OpenACS did overwrite the Tcl built-in command

"::apply" and broke therefore all scripts/libraries using it.

Changed the name of the OpenACS function to "ad_apply" and altered

the few occurances. The fix works as well with Tcl 8.4. The proper

fix for 8.5 would be to use instead of the function the expand

operator {*}

  1. … 3 more files in changeset.
- fix for Tcl 8.5: OpenACS did overwrite the Tcl built-in command "::apply" and broke therefore all scripts/libraries using it.

Changed the name of the OpenACS function to "ad_apply" and altered the few occurances.

The fix works as well with Tcl 8.4. The proper fix for 8.5 would be to use instead of the function the expand operator {*}

  1. … 3 more files in changeset.
change all core proc_doc calls to ad_proc calls

  1. … 7 more files in changeset.
print a call stack when emitting a deprecated/warn message

  1. … 1 more file in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

    • -23
    • +23
    ./40-db-query-dispatcher-procs.tcl
  1. … 363 more files in changeset.
Merged oacs-5-2 -> oacs-5-3 branches.

  1. … 66 more files in changeset.
Backport 10g recognition patches from HEAD

  1. … 1 more file in changeset.
Fixed bug 2961 by applying Christian Brechbühler's patch

  1. … 1 more file in changeset.
OK did it right this time. Damnation!

Make ad_proc default to the function being public. This decision was made

by Don and Dave and a couple of others during the current bugbash.

Why not TIP it? There's no semantic meaning to the switch, and ad_proc

doesn't require you to declare a procedure to be either -public or -private.

This was enforced in an automated test, but if we WERE to insist on it,

ad_proc should cause failure to declare a proc public or private and error.

That would be too harsh (would break a lot of client code, too). Assuming

functions are public by default seems reasonable. The only effect is to

change the behavior of the API browser if you've chosen private or public

viewing modes.

Merged acs-core oacs-5-2 (currently 5.2.3) -> HEAD.

TODO:

1. Bump acs-core package version numbers to 5.3.0d1

2. Would be nice to do a test install, wouldn't it?

  1. … 721 more files in changeset.
Fixed a problem in callbacks; implementations always call the contract definitions arg parser, but in the case where the contract only had positional arguments the arg parser was not defined.

added basic info about defining and using callbacks to docstring of ad_proc