Activity OpenACS/openacs-4/packages/acs-authentication

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	38
Last Commit:	13:32
Commits this week:	0
Total Lines of Code (LoC):	13,240
Net change in LoC this week:	0

Commit Activity

last updated 3 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Thursday 29 Apr 2021

9:14 am

antoniop

Streamline idiom: we are only interested in the user ids

- -9
- +11
./tcl/local-procs.tcl
- History
- Source
- Diff
./tcl/local-procs.tcl
- -14
- +0
./tcl/local-procs.xql
- History
- Source
- Diff
./tcl/local-procs.xql

Friday 09 Apr 2021

7:17 pm

Comment deprecated proc, which was before defined as private, because of a false positive in acs-api-browser.callgraph__bad_library_calls: the "Authenticate" operation in the spec of auth::authentication::create_contract is mistakenly interpreted as the deprecated proc

- -16
- +16
./tcl/authentication-procs.tcl
- History
- Source
- Diff
./tcl/authentication-procs.tcl

4:01 pm

antoniop

Make proc public, as was intended

- -2
- +2
./tcl/authentication-procs.tcl
- History
- Source
- Diff
./tcl/authentication-procs.tcl

Thursday 08 Apr 2021

6:18 pm

antoniop

Deprecated trivial private ad_user_login wrapper, which is already a public api

- -7
- +11
./tcl/authentication-procs.tcl
- History
- Source
- Diff
./tcl/authentication-procs.tcl
- -2
- +2
./tcl/password-procs.tcl
- History
- Source
- Diff
./tcl/password-procs.tcl

5:52 pm

antoniop

Promote logics in auth::authentication::Authenticate to a public api, which unfortunately cannot be the same due to the inconsistent naming, hence we have to create a new alias

Rationale:

- the proc provides some value to the user by choosing the right contract implementation depending on the authority

- we found occurrences in other packages downstream, and as internally this proc is calling only public api, one could just duplicate the whole thing and be compliant with our standards, which is not an improvement IMO

- the proc was already tested and documented

- -3
- +20
./tcl/authentication-procs.tcl
- History
- Source
- Diff
./tcl/authentication-procs.tcl
- -4
- +4
./tcl/test/acs-authentication-procs.tcl
- History
- Source
- Diff
./tcl/test/acs-authentication-procs.tcl
… 1 more file in changeset.

Tuesday 30 Mar 2021

5:58 pm

hectorr

Mark 'auth::can_admin_system_without_authority_p' as public, as it is used in 'acs-admin'

- -2
- +2
./tcl/authentication-procs.tcl
- History
- Source
- Diff
./tcl/authentication-procs.tcl

5:54 pm

hectorr

Mark 'auth::authority::get_sc_impl_columns' as public, as it is used in 'acs-admin'

- -2
- +2
./tcl/authority-procs.tcl
- History
- Source
- Diff
./tcl/authority-procs.tcl

Friday 26 Mar 2021

3:43 pm

hectorr

Make 'auth::get_register_authority' public, as it is used by acs-subsite

- -2
- +2
./tcl/authentication-procs.tcl
- History
- Source
- Diff
./tcl/authentication-procs.tcl

Tuesday 23 Mar 2021

2:16 pm

hectorr

Make 'auth::verify_account_status' public, as it is used in other packages. Fixes 'callgraph__bad_page_calls' test case

- -4
- +2
./tcl/authentication-procs.tcl
- History
- Source
- Diff
./tcl/authentication-procs.tcl

Thursday 11 Mar 2021

3:26 pm

hectorr

Use the new 'url' and 'email' input type widgets

- -2
- +3
./acs-authentication.info
- History
- Source
- Diff
./acs-authentication.info
- -3
- +3
./tcl/authentication-procs.tcl
- History
- Source
- Diff
./tcl/authentication-procs.tcl

Wednesday 03 Mar 2021

4:06 pm

antoniop

Port of downstream logic: do not use a hardcoded list of local authorities, but rather check if the authority implementation is local, which would handle also other downstream local authorities

Rework the idiom to perform cheap checks first and improve documentation

- -9
- +20
./tcl/authentication-procs.tcl
- History
- Source
- Diff
./tcl/authentication-procs.tcl

1:35 pm

antoniop

Fix var name

- -5
- +5
./tcl/authentication-procs.tcl
- History
- Source
- Diff
./tcl/authentication-procs.tcl

12:25 pm

antoniop

Creating a user without a username is possible if the authority is local, include the test authority among those for which we generate a username, as it is also local as in "hosted locally"

Fixes acs-authentication.auth_use_email_for_login_p automated test

- -2
- +6
./tcl/authentication-procs.tcl
- History
- Source
- Diff
./tcl/authentication-procs.tcl

4:42 am

gustafn

reduce public footprint

- -2
- +2
./tcl/sync-procs.tcl
- History
- Source
- Diff
./tcl/sync-procs.tcl
… 1 more file in changeset.

Tuesday 02 Mar 2021

11:32 am

gustafn

fixed bug: exception in test case auth_use_email_for_login_p caused test to terminate

By adding an "ad_try", we can see that the intention to create

a user with no username failed. Probably this was working at some time,

not sure, if it still should.

This is could be a general problem with "aa_run_with_teardown" to

terminate too early in such cases.

- -10
- +18
./tcl/test/acs-authentication-procs.tcl
- History
- Source
- Diff
./tcl/test/acs-authentication-procs.tcl

Monday 22 Feb 2021

8:00 pm

antoniop

- Rework acs-api-browser.callgraph__bad_calls automated test so that acs-service-contract calling contract implementation is considered OK

- Reinstate authentication service contracts as private

- Move test authority implementation to acs-authentication to remove intra-package dependency

acs-api-browser.callgraph__bad_call still fails because proc acs-tcl.install::xml::action::create-user calls private acs-authentication.auth::local::registration::Register... to be continued