OpenACS / openacs-4 / packages

acs-authentication

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 38
Last Commit: 13:32
Commits this week: 0
Total Lines of Code (LoC): 13,240
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 09 Apr 2021
4:01 pm

antoniop

Make proc public, as was intended

Options
    • -2
    • +2
    ./tcl/authentication-procs.tcl
Thursday 08 Apr 2021
6:18 pm

antoniop

Deprecated trivial private ad_user_login wrapper, which is already a public api

Options
    • -7
    • +11
    ./tcl/authentication-procs.tcl
    • -2
    • +2
    ./tcl/password-procs.tcl
5:52 pm

antoniop

Promote logics in auth::authentication::Authenticate to a public api, which unfortunately cannot be the same due to the inconsistent naming, hence we have to create a new alias

Rationale:

- the proc provides some value to the user by choosing the right contract implementation depending on the authority

- we found occurrences in other packages downstream, and as internally this proc is calling only public api, one could just duplicate the whole thing and be compliant with our standards, which is not an improvement IMO

- the proc was already tested and documented

Options
    • -3
    • +20
    ./tcl/authentication-procs.tcl
    • -4
    • +4
    ./tcl/test/acs-authentication-procs.tcl
  3. … 1 more file in changeset.
Tuesday 30 Mar 2021
5:58 pm

hectorr

Mark 'auth::can_admin_system_without_authority_p' as public, as it is used in 'acs-admin'

Options
    • -2
    • +2
    ./tcl/authentication-procs.tcl
5:54 pm

hectorr

Mark 'auth::authority::get_sc_impl_columns' as public, as it is used in 'acs-admin'

Options
    • -2
    • +2
    ./tcl/authority-procs.tcl
Friday 26 Mar 2021
3:43 pm

hectorr

Make 'auth::get_register_authority' public, as it is used by acs-subsite

Options
    • -2
    • +2
    ./tcl/authentication-procs.tcl
Tuesday 23 Mar 2021
2:16 pm

hectorr

Make 'auth::verify_account_status' public, as it is used in other packages. Fixes 'callgraph__bad_page_calls' test case

Options
    • -4
    • +2
    ./tcl/authentication-procs.tcl
Thursday 11 Mar 2021
3:26 pm

hectorr

Use the new 'url' and 'email' input type widgets

Options
    • -2
    • +3
    ./acs-authentication.info
    • -3
    • +3
    ./tcl/authentication-procs.tcl
Wednesday 03 Mar 2021
4:06 pm

antoniop

Port of downstream logic: do not use a hardcoded list of local authorities, but rather check if the authority implementation is local, which would handle also other downstream local authorities

Rework the idiom to perform cheap checks first and improve documentation

Options
    • -9
    • +20
    ./tcl/authentication-procs.tcl
1:35 pm

antoniop

Fix var name

Options
    • -5
    • +5
    ./tcl/authentication-procs.tcl
12:25 pm

antoniop

Creating a user without a username is possible if the authority is local, include the test authority among those for which we generate a username, as it is also local as in "hosted locally"

Fixes acs-authentication.auth_use_email_for_login_p automated test

Options
    • -2
    • +6
    ./tcl/authentication-procs.tcl
4:42 am

gustafn

reduce public footprint

Options
    • -2
    • +2
    ./tcl/sync-procs.tcl
  2. … 1 more file in changeset.
Tuesday 02 Mar 2021
11:32 am

gustafn

fixed bug: exception in test case auth_use_email_for_login_p caused test to terminate

By adding an "ad_try", we can see that the intention to create

a user with no username failed. Probably this was working at some time,

not sure, if it still should.

This is could be a general problem with "aa_run_with_teardown" to

terminate too early in such cases.

Options
    • -10
    • +18
    ./tcl/test/acs-authentication-procs.tcl
Monday 22 Feb 2021
8:00 pm

antoniop

- Rework acs-api-browser.callgraph__bad_calls automated test so that acs-service-contract calling contract implementation is considered OK

- Reinstate authentication service contracts as private

- Move test authority implementation to acs-authentication to remove intra-package dependency

acs-api-browser.callgraph__bad_call still fails because proc acs-tcl.install::xml::action::create-user calls private acs-authentication.auth::local::registration::Register... to be continued

Options
    • -6
    • +6
    ./tcl/local-procs.tcl
    • -0
    • +133
    ./tcl/test-authority-procs.tcl
  3. … 2 more files in changeset.
8:00 pm

antoniop

file test-authority-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test-authority-procs.tcl
3:35 pm

antoniop

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -4
    • +4
    ./tcl/local-procs.tcl
    • -2
    • +2
    ./tcl/authentication-procs.tcl
  3. … 1 more file in changeset.
3:04 pm

antoniop

Make service contract implementation public

Complies with acs-api-browser.callgraph__bad_calls

Options
    • -3
    • +3
    ./tcl/local-procs.tcl
Tuesday 16 Feb 2021
9:59 pm

gustafn

improve listing of test coverage

Options
    • -1
    • +27
    ./tcl/test/acs-authentication-procs.tcl
    • -1
    • +10
    ./tcl/test/sync-test-procs.tcl
  3. … 16 more files in changeset.
Monday 15 Feb 2021
6:53 pm

gustafn

make listing of tested procs more complete

Options
    • -12
    • +30
    ./tcl/test/acs-authentication-procs.tcl
    • -2
    • +6
    ./tcl/test/sync-test-procs.tcl
  3. … 17 more files in changeset.
Sunday 14 Feb 2021
10:22 pm

gustafn

whitespace changes

Options
    • -2
    • +4
    ./tcl/authentication-procs.tcl
10:21 pm

gustafn

set default value only in case of failure

Options
    • -6
    • +7
    ./tcl/authentication-procs-naviserver.tcl
Tuesday 13 Oct 2020
10:24 am

hectorr

Care about the parameter cache after test case

Options
    • -1
    • +3
    ./tcl/test/acs-authentication-procs.tcl
9:07 am

hectorr

Set a bunch of test cases to 'production_safe'

Options
    • -7
    • +7
    ./tcl/test/acs-authentication-procs.tcl
8:52 am

hectorr

Merge 'auth_authority_api' and 'auth_authority_delete' test cases, covering almost the same api

Options
    • -195
    • +122
    ./tcl/test/acs-authentication-procs.tcl
8:13 am

hectorr

Fix typo

Options
    • -2
    • +2
    ./tcl/test/acs-authentication-procs.tcl
Monday 28 Sep 2020
11:04 pm

gustafn

don't rely on uppercase header field names

Options
    • -2
    • +2
    ./tcl/authentication-procs.tcl
  2. … 10 more files in changeset.
Thursday 03 Sep 2020
11:16 am

gustafn

prefer db_0or1row +"where exists" over db_string + "select case"

Options
    • -12
    • +14
    ./tcl/authentication-procs.tcl
  2. … 3 more files in changeset.
Tuesday 01 Sep 2020
7:09 pm

antoniop

Improve sql portability: oracle cannot select a boolean directly using exists

Options
    • -3
    • +4
    ./tcl/authentication-procs.tcl
4:18 pm

antoniop

Reduce divergencies between oracle and postgres codebase

Options
    • -9
    • +0
    ./tcl/test/acs-authentication-procs-oracle.xql
    • -10
    • +0
    ./tcl/test/acs-authentication-procs-postgresql.xql
    • -2
    • +6
    ./tcl/test/acs-authentication-procs.tcl
Tuesday 21 Jul 2020
3:58 pm

gustafn

prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

Options
    • -2
    • +2
    ./tcl/password-procs.tcl
  2. … 18 more files in changeset.