OpenACS / openacs-4 / packages / acs-authentication

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 30
Last Commit: 20 Dec
Commits this week: 0
Total Lines of Code (LoC): 10,422
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Nov 2021
11:41 am

gustafn

Remove backward compatibility check in busy code for versions before 5.1.3 (2004)

The checks for backwards compatibility have on busy sites the highest

hit rates of all entries in the util-memoize cache. Since we require the latest

OpenACS 5.9.* for upgrade to 5.10, this can be removed (17 years later).

https://openacs.org/bugtracker/openacs/bug?format=table&f%5fstate=8&bug%5fnumber=2200

Options
    • -22
    • +6
    ./authentication-procs.tcl
Thursday 07 Oct 2021
2:37 pm

antoniop

Use the test machinery to simulate a cookie authentication

Options
    • -29
    • +10
    ./test/authentication-procs.tcl
1:03 pm

antoniop

Inline sec_login_read_cookie, as it is a private api and would upset the bad calls test

Options
    • -1
    • +10
    ./test/authentication-procs.tcl
Wednesday 06 Oct 2021
4:08 pm

antoniop

Test auth::verify_account_status and complete coverage of acs-authentication

Options
    • -0
    • +57
    ./test/authentication-procs.tcl
3:16 pm

antoniop

Test auth::update_local_account

Options
    • -0
    • +98
    ./test/authentication-procs.tcl
2:19 pm

antoniop

Add auth::sync::job::get_authority_id to an existing test

Options
    • -2
    • +16
    ./test/sync-test-procs.tcl
2:12 pm

antoniop

Test auth::self_registration

Options
    • -0
    • +69
    ./test/authentication-procs.tcl
1:47 pm

antoniop

Test auth::refresh_login

Options
    • -0
    • +36
    ./test/authentication-procs.tcl
11:48 am

antoniop

Cleanup code pasted twice by mistake

Options
    • -53
    • +0
    ./test/authentication-procs.tcl
Tuesday 05 Oct 2021
6:25 pm

antoniop

Bring more stuff into an existing test

Options
    • -4
    • +13
    ./test/acs-authentication-procs.tcl
6:15 pm

antoniop

Test for auth::get_user_id and the whole login attempts api

Options
    • -0
    • +167
    ./test/authentication-procs.tcl
5:43 pm

antoniop

Document actual behavior

Options
    • -2
    • +3
    ./authentication-procs-aolserver.tcl
    • -2
    • +3
    ./authentication-procs-naviserver.tcl
5:08 pm

antoniop

Test auth::get_user_id

Options
    • -0
    • +53
    ./test/authentication-procs.tcl
4:32 pm

antoniop

Test auth::get_register_authority proc

Options
    • -0
    • +49
    ./test/authentication-procs.tcl
4:17 pm

antoniop

Fix test name

Options
    • -1
    • +1
    ./test/authentication-procs.tcl
4:06 pm

antoniop

Test auth::get_all_registration_elements

Options
    • -0
    • +21
    ./test/authentication-procs.tcl
4:00 pm

antoniop

Test more public api

Options
    • -0
    • +47
    ./test/authentication-procs.tcl
3:32 pm

antoniop

Test auth::can_admin_system_without_authority_p public api

Options
    • -0
    • +103
    ./test/authentication-procs.tcl
3:32 pm

antoniop

file authentication-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./test/authentication-procs.tcl
2:42 pm

antoniop

Test auth::authority::get_sc_impl_columns public api

Options
    • -0
    • +36
    ./test/authority-procs.tcl
2:42 pm

antoniop

file authority-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./test/authority-procs.tcl
Monday 04 Oct 2021
12:12 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -19
    • +0
    ./test/acs-authentication-procs-oracle.xql
    • -19
    • +0
    ./test/acs-authentication-procs-postgresql.xql
    • -2
    • +11
    ./test/acs-authentication-procs.tcl
  4. … 6 more files in changeset.
Thursday 02 Sep 2021
6:40 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./authentication-procs-naviserver.tcl
  2. … 42 more files in changeset.
Friday 30 Apr 2021
6:06 pm

gernst

Bring the implementation of the "Search" operation of the "auth_search" service contract in line with the operation's definition by correcting the returned value ("username" instead of "user_id") and restricting the search to the local authority.

Options
    • -8
    • +10
    ./local-procs.tcl
Thursday 29 Apr 2021
9:14 am

antoniop

Streamline idiom: we are only interested in the user ids

Options
    • -9
    • +11
    ./local-procs.tcl
    • -14
    • +0
    ./local-procs.xql
Friday 09 Apr 2021
7:17 pm

antoniop

Comment deprecated proc, which was before defined as private, because of a false positive in acs-api-browser.callgraph__bad_library_calls: the "Authenticate" operation in the spec of auth::authentication::create_contract is mistakenly interpreted as the deprecated proc

Options
    • -16
    • +16
    ./authentication-procs.tcl
4:01 pm

antoniop

Make proc public, as was intended

Options
    • -2
    • +2
    ./authentication-procs.tcl
Thursday 08 Apr 2021
6:18 pm

antoniop

Deprecated trivial private ad_user_login wrapper, which is already a public api

Options
    • -7
    • +11
    ./authentication-procs.tcl
    • -2
    • +2
    ./password-procs.tcl
5:52 pm

antoniop

Promote logics in auth::authentication::Authenticate to a public api, which unfortunately cannot be the same due to the inconsistent naming, hence we have to create a new alias

Rationale:

- the proc provides some value to the user by choosing the right contract implementation depending on the authority

- we found occurrences in other packages downstream, and as internally this proc is calling only public api, one could just duplicate the whole thing and be compliant with our standards, which is not an improvement IMO

- the proc was already tested and documented

Options
    • -3
    • +20
    ./authentication-procs.tcl
    • -4
    • +4
    ./test/acs-authentication-procs.tcl
  3. … 1 more file in changeset.
Tuesday 30 Mar 2021
5:58 pm

hectorr

Mark 'auth::can_admin_system_without_authority_p' as public, as it is used in 'acs-admin'

Options
    • -2
    • +2
    ./authentication-procs.tcl