OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 16 Feb 2021
3:19 pm

gustafn

improve listing of test coverage

Options
    • -1
    • +1
    /openacs-4/packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl
    • -0
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -0
    • +56
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl
    • -0
    • +19
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
    • -1
    • +51
    /openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
    • -0
    • +12
    /openacs-4/packages/xowiki/tcl/test/api-test-procs.tcl
    • -2
    • +64
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
    • -1
    • +20
    /openacs-4/packages/xowiki/tcl/test/xowiki-link-test-procs.tcl
    • -2
    • +66
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
10:38 am

hectorr

Add default to avoid empty values. Fixes 'acs_mail_lite_inbound_procs_check' test case

Options
    • -1
    • +1
    /openacs-4/packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl
7:54 am

trenner

consider subject field restriction from the database also in the ui

Options
    • -1
    • +1
    /openacs-4/packages/forums/tcl/form-procs.tcl
3:31 am

gustafn

just avoid tilde substitution, do not perform sanitizing

sanitizing can lead to file name clashes in case the names

without tilde exists, and they are OS specific. The intention

of "ad_file" is just to be a tilde-proof "file" replacement

Options
    • -2
    • +4
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -5
    • +42
    /openacs-4/packages/acs-bootstrap-installer/tcl/test/00-proc-procs.tcl
3:23 am

gustafn

use per_thread_cache for flusing rather than raw variables

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/tcl/locale-procs.tcl
Monday 15 Feb 2021
6:53 pm

gustafn

make listing of tested procs more complete

Options
    • -12
    • +30
    /openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
    • -2
    • +6
    /openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
    • -0
    • +1
    /openacs-4/packages/acs-content-repository/tcl/test/content-extlink-procs.tcl
    • -0
    • +1
    /openacs-4/packages/acs-content-repository/tcl/test/content-search-procs.tcl
    • -17
    • +20
    /openacs-4/packages/acs-datetime/tcl/test/acs-datetime-procs.tcl
    • -6
    • +22
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -2
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/apm-parameter-test-procs.tcl
    • -0
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/application-data-link-procs.tcl
    • -2
    • +8
    /openacs-4/packages/acs-tcl/tcl/test/community-core-test-procs.tcl
    • -14
    • +32
    /openacs-4/packages/acs-tcl/tcl/test/datamodel-test-procs.tcl
    • -63
    • +69
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
    • -7
    • +18
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
    • -6
    • +27
    /openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl
    • -0
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
    • -1
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
  16. … 4 more files in changeset.
4:50 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
4:50 pm

antoniop

Do not allow backslashes in folders created via zipfile upload

As the folder name is used also for looking up for existing folders, the safest approach is to block the user: the risk with an automatic sanitization would be to overwrite existing folders without the user realizing

Options
    • -1
    • +10
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
3:23 pm

antoniop

Sanitize all trailing tildes from the filename, mapping them to the current folder

Fixes acs-bootstrap-installer.ad_file automated test

Options
    • -4
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
3:13 pm

hectorr

Make 'ad_file' test case deterministic

Options
    • -1
    • +1
    /openacs-4/packages/acs-bootstrap-installer/tcl/test/00-proc-procs.tcl
2:47 pm

antoniop

Automated test for ad_file exposing a blind spot with files starting with the '~' character

Options
    • -0
    • +27
    /openacs-4/packages/acs-bootstrap-installer/tcl/test/00-proc-procs.tcl
2:47 pm

antoniop

file 00-proc-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-bootstrap-installer/tcl/test/00-proc-procs.tcl
2:41 pm

gustafn

make listing of tested procs more complete

Options
    • -1
    • +4
    /openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
    • -0
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -0
    • +6
    /openacs-4/packages/acs-tcl/tcl/test/navigation-procs.tcl
2:27 pm

gustafn

make listing of tested procs more complete

Options
    • -1
    • +9
    /openacs-4/packages/acs-admin/tcl/test/acs-admin-procs.tcl
    • -1
    • +7
    /openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
    • -2
    • +5
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
    • -5
    • +14
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-test-procs.tcl
    • -2
    • +8
    /openacs-4/packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl
    • -1
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -1
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/object-test-case-procs.tcl
12:11 pm

hectorr

Whitespace changes

Options
    • -1
    • +1
    /openacs-4/packages/calendar-portlet/calendar-portlet.info
    • -1
    • +1
    /openacs-4/packages/calendar-portlet/tcl/apm-callback-procs.tcl
12:10 pm

hectorr

Adjust naming to openacs conventions. Fixes 'naming__proc_naming' test case.

Options
    • -3
    • +3
    /openacs-4/packages/calendar-portlet/calendar-portlet.info
    • -2
    • +2
    /openacs-4/packages/calendar-portlet/tcl/apm-callback-procs.tcl
    • -1
    • +1
    /openacs-4/packages/calendar-portlet/tcl/apm-callback-procs.xql
Sunday 14 Feb 2021
10:22 pm

gustafn

whitespace changes

Options
    • -2
    • +4
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
10:21 pm

gustafn

set default value only in case of failure

Options
    • -6
    • +7
    /openacs-4/packages/acs-authentication/tcl/authentication-procs-naviserver.tcl
10:16 pm

gustafn

use ad_proc -private

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
10:16 pm

gustafn

improve warning message

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
10:15 pm

gustafn

provide better error message

Options
    • -1
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
10:13 pm

gustafn

provide warning about deprecated location

Options
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
    • -65
    • +75
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
10:10 pm

gustafn

reduce verbosity

Options
    • -5
    • +6
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/xotcl-init.tcl
10:08 pm

gustafn

improve spelling

Options
    • -1
    • +10
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -4
    • +8
    /openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl
    • -10
    • +12
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
    • -2
    • +2
    /openacs-4/packages/forums/www/message-view.tcl
    • -2
    • +2
    /openacs-4/packages/news/tcl/test/news-db-test-init.tcl
10:05 pm

gustafn

make listing of tested procs more complete

Options
    • -4
    • +1
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -2
    • +23
    /openacs-4/packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
    • -3
    • +11
    /openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
    • -1
    • +2
    /openacs-4/packages/acs-templating/tcl/test/spell-checker-procs.tcl
    • -1
    • +4
    /openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
    • -2
    • +6
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
    • -1
    • +18
    /openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
    • -0
    • +1
    /openacs-4/packages/xowiki/tcl/test/api-test-procs.tcl
    • -14
    • +27
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
    • -0
    • +10
    /openacs-4/packages/xowiki/tcl/test/xowiki-link-test-procs.tcl
    • -6
    • +36
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
10:04 pm

gustafn

make code slightly more regular

Options
    • -15
    • +29
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
    • -15
    • +26
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
9:59 pm

gustafn

no need to use extra namespace for callback

Options
    • -4
    • +4
    /openacs-4/packages/new-portal/new-portal.info
    • -2
    • +2
    /openacs-4/packages/new-portal/tcl/apm-callback-procs.tcl
    • -1
    • +1
    /openacs-4/packages/new-portal/tcl/apm-callback-procs.xql
10:47 am

gustafn

reduce verbosity

Options
    • -3
    • +1
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
Saturday 13 Feb 2021
9:24 pm

gustafn

remove race condition from user/person/party cache management

Options
    • -63
    • +81
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
6:31 pm

gustafn

2 new API functions acs_user::promote_person_to_user and acs_user::demote_user (see issue #3461)

acs_user::promote_person_to_user

Promotes a person/party to an ACS user.

@param person_id the person_id in the acs system that should be promoted to a user.

@param username the username to be used for this user.

Defaults to the person's email

@param password the password to be used for this user.

Defaults to a randomly generated password.

@param authority_id the authority that will be used for the user.

@param locale locale to be used in user preferences.

Defaults to the site wide locale is taken.

@return The user_id of the person promoted to user

@error An error is thrown

if the username is already in use,

or the person_id has no email address,

or if person_id is not in the persons table.

acs_user::demote_user

Demotes an ACS user to a person/party.

This will fail if other tables have content referencing the users

table. It is probably best for tables created in other packages

to reference persons, parties, or acs_objects instead. This proc

could be extended with an option to find all referenced tables and

remove rows referencing this user.

See the following FK relationship in basic OpenACS installations:

TABLE "acs_objects" CONSTRAINT "acs_objects_creation_user_fk" FOREIGN KEY (creation_user) REFERENCES users(user_id)

TABLE "acs_objects" CONSTRAINT "acs_objects_modifying_user_fk" FOREIGN KEY (modifying_user) REFERENCES users(user_id)

TABLE "ad_locale_user_prefs" CONSTRAINT "ad_locale_user_prefs_users_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "auth_batch_job_entries" CONSTRAINT "auth_batch_job_entries_user_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE SET NULL

TABLE "auth_batch_jobs" CONSTRAINT "auth_batch_jobs_user_fk" FOREIGN KEY (creation_user) REFERENCES users(user_id) ON DELETE SET NULL

TABLE "cr_news" CONSTRAINT "cr_news_approval_user_fk" FOREIGN KEY (approval_user) REFERENCES users(user_id)

TABLE "email_images" CONSTRAINT "email_images_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "forums_messages" CONSTRAINT "forums_mess_last_poster_fk" FOREIGN KEY (last_poster) REFERENCES users(user_id)

TABLE "forums_messages" CONSTRAINT "forums_mess_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "forums_reading_info" CONSTRAINT "forums_read_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "lang_messages_audit" CONSTRAINT "lang_messages_audit_ou_fk" FOREIGN KEY (overwrite_user) REFERENCES users(user_id)

TABLE "lang_messages" CONSTRAINT "lang_messages_creation_user_fk" FOREIGN KEY (creation_user) REFERENCES users(user_id)

TABLE "lang_user_timezone" CONSTRAINT "lang_user_timezone_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "notification_replies" CONSTRAINT "notif_repl_from_fk" FOREIGN KEY (from_user) REFERENCES users(user_id)

TABLE "notification_user_map" CONSTRAINT "notif_user_map_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "notifications" CONSTRAINT "notifications_notif_user_fk" FOREIGN KEY (notif_user) REFERENCES users(user_id)

TABLE "notification_requests" CONSTRAINT "notifications_request_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "proctoring_examination_statement_acceptance" CONSTRAINT "proctoring_examination_statement_acceptance_user_id_fkey" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "user_portraits" CONSTRAINT "user_portraits_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "user_preferences" CONSTRAINT "user_preferences_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "xowiki_tags" CONSTRAINT "xowiki_tags_user_id_fkey" FOREIGN KEY (user_id) REFERENCES users(user_id)

Options
    • -9
    • +252
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl