OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 14
Total Committers: 146
Last Commit: 25 Nov
Commits this week: 14
Total Lines of Code (LoC): 7,560,967
Net change in LoC this week: 146

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 31 Mar 2022
6:33 pm

antoniop

Replace the lame template::util::get_opts with some homemade utility that will parse arguments reliably, adjust the one upstream use case where arguments other than those documented might be passed to the element creation, introduce a warning when this happens somewhere else

Options
    • -2
    • +82
    /openacs-4/packages/acs-templating/tcl/element-procs.tcl
    • -5
    • +4
    /openacs-4/packages/forums/tcl/form-procs.tcl
6:28 pm

antoniop

Prevent names made only of invalid characters to end up null after sanitization, as done in other UIs in this package

Options
    • -2
    • +14
    /openacs-4/packages/file-storage/www/folder-edit.tcl
6:23 pm

antoniop

Fix test, the proc behaves as documented (and IMO, it should go away at some point)

Options
    • -2
    • +7
    /openacs-4/packages/acs-templating/tcl/test/util-procs.tcl
4:16 pm

trenner

increase robustness

Options
    • -5
    • +9
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
2:59 pm

antoniop

New test for template::util::get_opts

This will expose a bug when an argument in an even position is specified that starts with a "-" character

Options
    • -1
    • +32
    /openacs-4/packages/acs-templating/tcl/test/util-procs.tcl
9:10 am

trenner

improve validation

Options
    • -3
    • +4
    /openacs-4/packages/file-storage/www/simple-add.tcl
    • -1
    • +3
    /openacs-4/packages/file-storage/www/simple-edit.tcl
9:05 am

trenner

provide missing value for inform widget

Options
    • -2
    • +2
    /openacs-4/packages/file-storage/www/simple-add.tcl
8:44 am

trenner

improve validation

Options
    • -2
    • +2
    /openacs-4/packages/file-storage/www/folder-create.tcl
    • -1
    • +2
    /openacs-4/packages/file-storage/www/folder-edit.tcl
Wednesday 30 Mar 2022
6:40 pm

gernst

Gradually improve usability and security of the calendar item new/edit form by adding additonal input validations. Prefer built-in input validation over custom validation. Also make sure all needed Javascript is in place.

Options
    • -23
    • +29
    /openacs-4/packages/calendar/www/cal-item-new.tcl
3:45 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
10:34 am

trenner

not necessary to check if format is a list

Options
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/richtext-procs.tcl
9:59 am

trenner

move the check for the provided format on richtext level

Options
    • -0
    • +4
    /openacs-4/packages/acs-templating/tcl/richtext-procs.tcl
    • -4
    • +2
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
Tuesday 29 Mar 2022
6:12 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
6:07 pm

antoniop

Make ::xo::db::require package a shorthand for ::xo::library require, which will remember the dependency

This will also make sure that dependent files are reloaded when a dependency is reloaded

Options
    • -11
    • +6
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
6:03 pm

antoniop

Depend specifically on the form-field-procs from xowiki

Options
    • -0
    • +2
    /openacs-4/packages/xowf/tcl/xowf-form-field-procs.tcl
5:42 pm

trenner

tighten page contract

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/deregister-self-confirm.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/deregister.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/register.tcl
5:39 pm

antoniop

Depend specifically from the form-field-procs file to support the case of reloads

Options
    • -0
    • +1
    /openacs-4/packages/xowf-monaco-plugin/tcl/form-field-procs.tcl
4:58 pm

antoniop

Don't require the whole xowiki, as it is already a dependency

Options
    • -1
    • +0
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -2
    • +0
    /openacs-4/packages/xowf/tcl/xowf-form-field-procs.tcl
    • -1
    • +0
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
4:53 pm

antoniop

Make xowf an explicit dependency, so that we don't need to require xowf and xowiki in the tcl files

Options
    • -2
    • +3
    /openacs-4/packages/xowf-monaco-plugin/xowf-monaco-plugin.info
    • -2
    • +0
    /openacs-4/packages/xowf-monaco-plugin/tcl/form-field-procs.tcl
    • -1
    • +0
    /openacs-4/packages/xowf-monaco-plugin/tcl/test-item-procs.tcl
1:01 pm

trenner

increase robustness

Options
    • -2
    • +4
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
11:25 am

gustafn

New feature: cookie namespaces

So far, all OpenACS versions used "ad_" as a prefix for cookies (such

as ad_login, ad_session_id, ...). In certain situations this can lead

to confusion, since cookies are managed by browsers via domain names,

and running multiple OpenACS instances in the same domain will cause

overwriting of such cookies by these instances. The can happen e.g.

when running multiple instances on the same machine, or using

port-forwarding to virtual machines/containers, using reverse proxies,

etc. Note that the cookie overwriting problem does not exist for

host-node-mapped subsites, since host-node-mapping depends on domain

names.

One could consider using the port in the cookie name (as

sometimes noted as an option), but this would not work, in case the

same server should be reachable over multiple ports.

Therefore, one can now specify a "CookieNamespace" in the OpenACS

configuration file, which is per default "ad_", which is sufficient

for the majority of installations. In cases, where it is needed, a

different CookieNamespace can now be configured.

To manage the cookie names internally, OpenACS provides a new API call

security::cookie_name to derive the namespaced cookie name from a stem.

Snippet of the OpenACS configuration file for setting the CookieNamespace

#---------------------------------------------------------------------

# OpenACS specific settings (per server)

#---------------------------------------------------------------------

ns_section ns/server/${server}/acs {

ns_param CookieNamespace "ad_"

...

}

Options
    • -8
    • +0
    /openacs-4/packages/acs-tcl/tcl/security-procs-oracle.xql
    • -6
    • +0
    /openacs-4/packages/acs-tcl/tcl/security-procs-postgresql.xql
    • -29
    • +52
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
10:53 am

gustafn

cleanup: the updated version of the site-note code is appartently stable enough also for bootstrap situations

Options
    • -16
    • +9
    /openacs-4/packages/acs-tcl/tcl/cluster-init.tcl
10:50 am

gustafn

remove commented out coude

Options
    • -2
    • +1
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
10:49 am

gustafn

Provide better debug info in case "ns_parseurl" fails inside util::split_location

Factor our private function "util::ns_set_pretty_print" which might be

used also on other occasions.

Options
    • -6
    • +41
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Monday 28 Mar 2022
6:04 pm

gustafn

use bootstrap button classes for print button in the exam protocol (many thanks to Monika Andergassen for the suggestion)

Options
    • -6
    • +6
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
5:51 pm

gustafn

replace non-existing class "btn-small" (for bootstrap3) by non-existing class "btn-secondary", which shows in the right color and is future proof (introduced by bootstrap 4).

Options
    • -1
    • +1
    /openacs-4/packages/xowf/resources/prototypes/select-topics.form.page
    • -3
    • +3
    /openacs-4/packages/xowf/resources/prototypes/select_question.form.page
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Friday 25 Mar 2022
9:24 pm

gustafn

prevent double-sorting

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/last-requests.tcl
9:19 pm

gustafn

some more fine-tuning

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl
    • -3
    • +19
    /openacs-4/packages/xotcl-request-monitor/www/whos-online-today.tcl
8:49 pm

gustafn

Make use of extended functionality of OrderedComposite->orderby with -type argument

bumped version number to 0.64

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/xotcl-request-monitor.info
    • -2
    • +5
    /openacs-4/packages/xotcl-request-monitor/www/active-communities.tcl
    • -1
    • +7
    /openacs-4/packages/xotcl-request-monitor/www/last-requests.tcl
    • -2
    • +5
    /openacs-4/packages/xotcl-request-monitor/www/last100.tcl
    • -2
    • +5
    /openacs-4/packages/xotcl-request-monitor/www/last101.tcl
    • -13
    • +7
    /openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl
    • -18
    • +6
    /openacs-4/packages/xotcl-request-monitor/www/whos-online-today.tcl
    • -17
    • +9
    /openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl
8:28 pm

gustafn

Perform stricter checking of parent_ids

bump version number of xowf to 5.10.1d34

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -1
    • +1
    /openacs-4/packages/xowf/lib/answer-single-question.wf
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl