• last updated 33 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- fixed bug (backport of fix in rev 1.74 of postgresql/apm-create.sql)

- bump version number to 5.6.1

    • -3
    • +3
    ./acs-kernel/sql/postgresql/apm-create.sql
add missing message key

    • -0
    • +1
    ./acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
In display mode, minute and second fragments should be the same size as the hidden widget value (usually 2).

fix typo

    • -2
    • +2
    ./acs-subsite/www/members/user-new.tcl
calendar popup widget fixes

add application_data_links::get_links_to proc (there was only get_links_from)

    • -0
    • +26
    ./acs-tcl/tcl/application-data-link-procs.tcl
    • -0
    • +31
    ./acs-tcl/tcl/application-data-link-procs.xql
remove conflicts in html docs

    • -9
    • +3
    ./acs-core-docs/www/acs-package-dev.html
    • -23
    • +1
    ./acs-core-docs/www/aolserver4.html
    • -20
    • +2
    ./acs-core-docs/www/apm-design.html
    • -6
    • +1
    ./acs-core-docs/www/apm-requirements.html
    • -4
    • +4
    ./acs-core-docs/www/automated-backup.html
    • -11
    • +2
    ./acs-core-docs/www/automated-testing-best-practices.html
    • -10
    • +4
    ./acs-core-docs/www/backup-recovery.html
    • -12
    • +12
    ./acs-core-docs/www/backups-with-cvs.html
    • -11
    • +2
    ./acs-core-docs/www/bootstrap-acs.html
    • -5
    • +0
    ./acs-core-docs/www/complete-install.html
    • -5
    • +1
    ./acs-core-docs/www/configuring-configuring-packages.html
    • -5
    • +1
    ./acs-core-docs/www/configuring-configuring-permissions.html
  1. … 120 more files in changeset.
fix broken image paths

    • -0
    • +8
    ./acs-core-docs/www/acs-package-dev.html
    • -9
    • +9
    ./acs-core-docs/www/analog-install.html
    • -15
    • +15
    ./acs-core-docs/www/analog-setup.html
    • -61
    • +84
    ./acs-core-docs/www/aolserver.html
    • -48
    • +70
    ./acs-core-docs/www/aolserver4.html
    • -91
    • +109
    ./acs-core-docs/www/apm-design.html
    • -126
    • +131
    ./acs-core-docs/www/apm-requirements.html
    • -12
    • +21
    ./acs-core-docs/www/automated-testing-best-practices.html
    • -1
    • +7
    ./acs-core-docs/www/backup-recovery.html
    • -40
    • +49
    ./acs-core-docs/www/bootstrap-acs.html
    • -0
    • +5
    ./acs-core-docs/www/complete-install.html
    • -2
    • +6
    ./acs-core-docs/www/configuring-configuring-packages.html
    • -2
    • +6
    ./acs-core-docs/www/configuring-configuring-permissions.html
  1. … 159 more files in changeset.
- fixed severe vulnerability with path traversal attack

    • -1
    • +6
    ./acs-api-browser/www/content-page-view.tcl
- Fix for Tcl 8.5: OpenACS did overwrite the Tcl built-in command

"::apply" and broke therefore all scripts/libraries using it.

Changed the name of the OpenACS function to "ad_apply" and altered

the few occurances. The fix works as well with Tcl 8.4. The proper

fix for 8.5 would be to use instead of the function the expand

operator {*}

    • -3
    • +3
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -2
    • +2
    ./acs-service-contract/tcl/acs-service-contract-procs.tcl
    • -2
    • +2
    ./rss-support/tcl/rss-generation-service-procs.tcl
disable old integer limit that forbids objects with more than 8 digits via regexp

Made the index page work even if the new "scope" column doesn't exist in

"apm_parameters" (for instance, as when one is updating to openacs 5.6.

Fix test which in one part assumed live revision and the rest of the test looked for latest revision. Second pass, all tests pass now.

    • -1
    • +3
    ./acs-content-repository/tcl/test/content-item-test-procs.tcl
OpenACS 5.6.0 docs.

    • -4
    • +2
    ./acs-core-docs/www/acs-package-dev.html
    • -1
    • +1
    ./acs-core-docs/www/apm-requirements.html
    • -4
    • +4
    ./acs-core-docs/www/automated-backup.html
    • -2
    • +2
    ./acs-core-docs/www/automated-testing-best-practices.html
    • -4
    • +4
    ./acs-core-docs/www/backup-recovery.html
    • -12
    • +12
    ./acs-core-docs/www/backups-with-cvs.html
    • -2
    • +2
    ./acs-core-docs/www/bootstrap-acs.html
    • -1
    • +1
    ./acs-core-docs/www/complete-install.html
    • -1
    • +1
    ./acs-core-docs/www/configuring-configuring-packages.html
    • -1
    • +1
    ./acs-core-docs/www/configuring-configuring-permissions.html
  1. … 119 more files in changeset.
Bumped to 5.6.0.

    • -4
    • +4
    ./acs-api-browser/acs-api-browser.info
    • -6
    • +6
    ./acs-authentication/acs-authentication.info
    • -4
    • +4
    ./acs-automated-testing/acs-automated-testing.info
    • -4
    • +4
    ./acs-bootstrap-installer/acs-bootstrap-installer.info
    • -6
    • +6
    ./acs-content-repository/acs-content-repository.info
    • -4
    • +4
    ./acs-service-contract/acs-service-contract.info
  1. … 10 more files in changeset.
Added a disabled subclass for button. Grays out the hyperlink and disables

it.

When instantiating and object of type object_type, make sure the object

we create is of type object_type.

Make content::item::new is live parameter default to f instead of empty string to match content::revision::new

    • -2
    • +2
    ./acs-content-repository/tcl/content-item-procs.tcl
Bumped to beta 3 so I could put in this important upgrade script, fixing

a problem with using package_instantiate_object to instantiate a base

(acs_object) object. Never done in core or .lrn code apparently because typically

you instantiate subtypes, but it is important to get right.

    • -3
    • +3
    ./acs-api-browser/acs-api-browser.info
    • -5
    • +5
    ./acs-authentication/acs-authentication.info
    • -3
    • +3
    ./acs-automated-testing/acs-automated-testing.info
    • -3
    • +3
    ./acs-bootstrap-installer/acs-bootstrap-installer.info
    • -5
    • +5
    ./acs-content-repository/acs-content-repository.info
    • -3
    • +3
    ./acs-service-contract/acs-service-contract.info
  1. … 12 more files in changeset.
Somebody hosed this (probably me). Never caught because no one creates a

base object directly, just subtypes of acs_object with their own (correct)

definition of a new() function.

Added Malte's patch which removes the use of /o/ when editing the css file.

I think it's cleaner this way.

    • -7
    • +11
    ./acs-developer-support/www/css-edit.tcl
Added sql_timestamp as an alias for sql_date (no code)

Replace single quote in tcl string with double quotes

    • -1
    • +1
    ./acs-content-repository/tcl/item-procs.tcl
I somehow managed to avoid commiting the "is_child" addition to apm-create

and also the upgrade script.

    • -1
    • +34
    ./acs-kernel/sql/oracle/apm-create.sql
- fix test files__tcl_file_common_errors

- report errors as such in aa-test (wrote warnings into error log, this was ignored since ages)

- fixed naming in acs-tcl, acs-mail-lite and acs-subsite

    • -8
    • +8
    ./acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -2
    • +2
    ./acs-mail-lite/tcl/incoming-mail-procs.tcl
    • -7
    • +9
    ./acs-tcl/tcl/test/file-test-procs.tcl
- complete change to acs_objects_package_idx for new creates (see http://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-6%3Agustafn%3A20100509112929)

Bumped remaining packages to 5.6.0b2

    • -4
    • +4
    ./acs-api-browser/acs-api-browser.info
    • -6
    • +6
    ./acs-authentication/acs-authentication.info
    • -4
    • +4
    ./acs-automated-testing/acs-automated-testing.info
    • -4
    • +4
    ./acs-bootstrap-installer/acs-bootstrap-installer.info
    • -6
    • +6
    ./acs-content-repository/acs-content-repository.info
    • -4
    • +4
    ./acs-service-contract/acs-service-contract.info
  1. … 10 more files in changeset.
Removed troublesome unique constraint

    • -3
    • +1
    ./ref-language/sql/oracle/ref-language-create.sql
    • -0
    • +3
    ./ref-language/tcl/apm-callback-procs.tcl
    • -0
    • +11
    ./ref-language/tcl/apm-callback-procs.xql
Needed to drop bio_mime_type attribute values, too ... this is removed

as it was never actually used so no need to copy it into the persons

table.

Had to remove the drop/create of cc_users because some obscure views make

use of it. No existing code expects cc_users to contain "bio" anyway, so

recreating the view was a matter of tidiness, not need. Drop ... cascade

would work but would break ecommerce and dotlrn-ecommerce, and likely some

other packages, so this seems the lesser of two evils.