OpenACS / openacs-4 / packages / acs-authentication / tcl

local-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 27 Dec
Commits this week: 0
Total Lines of Code (LoC): -4
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 19 Sep 2022
3:24 pm

antoniop

Rework parameter check:

the way the if was construed would allow e.g.:

1. a value for EmailRegistrationConfirmationToUserP = 'nottrue' to pass the first if, but fail the second.

2. a value EmailRegistrationConfirmationToUserP = 'false' to be "true" in the first if, but not in the second

In fact, if EmailRegistrationConfirmationToUserP should be a boolean, there is no need to further check the other parameters and variables in the second if. This change is not 100% equivalent to the previous code, but makes it clear that EmailRegistrationConfirmationToUserP should be interpreted as a boolean and fixes these inconsistencies.

Options
    • -26
    • +18
    ./local-procs.tcl
2:57 pm

antoniop

Make clear that parameters come from the same subsite

Options
    • -7
    • +12
    ./local-procs.tcl
Friday 16 Sep 2022
5:16 pm

antoniop

Fix signature of service contract implementation, that is defined with 3 and not 4 arguments, complete coverage of the auth_password contract local implementation

Options
    • -7
    • +2
    ./local-procs.tcl
  2. … 1 more file in changeset.
Friday 30 Apr 2021
6:06 pm

gernst

Bring the implementation of the "Search" operation of the "auth_search" service contract in line with the operation's definition by correcting the returned value ("username" instead of "user_id") and restricting the search to the local authority.

Options
    • -8
    • +10
    ./local-procs.tcl
Thursday 29 Apr 2021
9:14 am

antoniop

Streamline idiom: we are only interested in the user ids

Options
    • -9
    • +11
    ./local-procs.tcl
  2. … 1 more file in changeset.
Monday 22 Feb 2021
8:00 pm

antoniop

- Rework acs-api-browser.callgraph__bad_calls automated test so that acs-service-contract calling contract implementation is considered OK

- Reinstate authentication service contracts as private

- Move test authority implementation to acs-authentication to remove intra-package dependency

acs-api-browser.callgraph__bad_call still fails because proc acs-tcl.install::xml::action::create-user calls private acs-authentication.auth::local::registration::Register... to be continued

Options
    • -6
    • +6
    ./local-procs.tcl
  2. … 3 more files in changeset.
3:35 pm

antoniop

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -4
    • +4
    ./local-procs.tcl
  2. … 2 more files in changeset.
3:04 pm

antoniop

Make service contract implementation public

Complies with acs-api-browser.callgraph__bad_calls

Options
    • -3
    • +3
    ./local-procs.tcl