nsf

generic

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 14 Oct
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 02 Dec 2016
6:00 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

* nsf.c (GetObjectFromObj, TclDeletesObject): Remove two earlier fixes to deal with ::nsf::object::alloc failing under cmd deletion/recreation. The issue has been tackled more generally by a Tcl-side fix. Background: Since 2005 (commit fcb9ab1df3a9b2d1), in Tcl the cmdEpoch state in delete traces and delete callbacks (deleteProcs, destructors) has been compromised. Bumping the epoch of the cmd under deletion before executing the traces and callbacks had the potential of caching the cmd under in Tcl_Objs beyond its deletion (at least in our code path). In July 2017 (8.7a, commit 54fac92610d3bdd9), this potential realised by removing a guard expression (CMD_IS_DELETED) in the Tcl_Obj cache invalidation logic, which had protected from such invalid caches (as a side effect). As of today (8.7a, commit 71fa1f9c91), the underlying timing problem of epoch bumping has been resolved.

Options
    • -25
    • +1
    ./nsf.c
Thursday 01 Dec 2016
12:08 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

* nsf.c (TclDeletesObject): Provide an alternative fix to reflect the changed cache invalidation policy for Tcl_Obj cmd intrep in 8.7.

Options
    • -2
    • +12
    ./nsf.c
11:35 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

Save code instrumentation to demonstrate the problem

Options
    • -13
    • +21
    ./nsf.c
  2. … 1 more file in changeset.
Sunday 27 Nov 2016
1:08 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

move the logic if Tcl_GetCommandFromObj() is returning an epoched obj to a more central place (GetObjectFromObj()) such it might kick in on other potential occasions as well.

Options
    • -30
    • +39
    ./nsf.c
Thursday 24 Nov 2016
8:52 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- use TclFreeIntRep() instead of direct function calls - perform TclFreeIntRep() for Class and Object creation under Tcl 8.7

Options
    • -14
    • +16
    ./nsf.c
Wednesday 23 Nov 2016
9:47 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

fix for Tcl 8.7: - when recreating an nsf object in in tcl 8.7, we seem to have to invalidate the intrep, otherwise the new command is not picked up by a later Tcl_GetCommandFromObj()

Options
    • -15
    • +46
    ./nsf.c
4:10 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

* nsf.c (NsfMethodAliasCmd): Tcl 8.7 is more picky about typePtr and intrep being in line. We need to NULL the typePtr explicitly. TclFreeIntRep does so for us as good Tcl citizens, rather than setting bodyObj->typePtr == NULL directly.

Options
    • -1
    • +1
    ./nsf.c
Friday 04 Nov 2016
12:05 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

* Updated copyright dates and copyright notices

Options
    • -1
    • +1
    ./nsf.c
    • -2
    • +2
    ./nsf.h
    • -1
    • +1
    ./nsfInt.h
    • -2
    • +3
    ./nsfObj.c
    • -1
    • +1
    ./nsfStack.c
  6. … 13 more files in changeset.
12:05 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

* Updated copyright dates and copyright notices

Options
    • -1
    • +1
    ./nsf.c
    • -2
    • +2
    ./nsf.h
    • -1
    • +1
    ./nsfInt.h
    • -2
    • +3
    ./nsfObj.c
    • -1
    • +1
    ./nsfStack.c
  6. … 13 more files in changeset.
Thursday 03 Nov 2016
11:37 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- address potential crash when a filter calls a filter which calls unknown

Options
    • -2
    • +8
    ./nsf.c
11:37 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- prefer lower case "U" suffix to improve readability

Options
    • -31
    • +31
    ./nsfInt.h
9:23 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

ObjectDispatchFinalize: First attempt to tackle filtered-unknowns issue

Options
    • -0
    • +6
    ./nsf.c
Wednesday 26 Oct 2016
10:30 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

ExitHandler(): Re-locate clearing history from finalize to ExitHandler

Options
    • -19
    • +18
    ./nsf.c
Saturday 22 Oct 2016
9:40 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

NsfFinalizeCmd(): Clear Tcl's history list explicitly before finalizing NSF (see als ticket 1ae12987cb).

Options
    • -0
    • +19
    ./nsf.c
Sunday 16 Oct 2016
11:10 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

nsfStack.c: Unify writing style

Options
    • -15
    • +15
    ./nsfStack.c
11:01 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

nsfProfile.c: Fix typos in code comments

Options
    • -10
    • +10
    ./nsfProfile.c
10:51 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

nsfFunPtrHashTable.c: Fix typos in code comments

Options
    • -4
    • +4
    ./nsfFunPtrHashTable.c
Saturday 15 Oct 2016
7:31 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- remove spurious blank in error message - fix typo in print string

Options
    • -1
    • +1
    ./nsfError.c
  2. … 3 more files in changeset.
11:32 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- improve comment and signature of NsfNoCurrentObjectError - improve wording of other commends, keep cmments within the limits of the header/trailer line

Options
    • -1
    • +1
    ./nsf.h
    • -59
    • +67
    ./nsfError.c
Friday 14 Oct 2016
11:27 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

nsfError.c: Fixed typos and unified writing style in code comments

Options
    • -12
    • +12
    ./nsfError.c
6:48 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

nsfObj.c: Fix some typos and align writing style

Options
    • -18
    • +18
    ./nsfObj.c
10:43 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- fix typos in comments - align commenting style

Options
    • -5
    • +15
    ./nsf.c
Thursday 13 Oct 2016
1:25 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

ObjectSystemsCleanup(): Remove interp resolvers explicitly before the physical cleanup round

Options
    • -1
    • +2
    ./nsf.c
12:56 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

DeleteProcsAndVars(): Silence compiler warning and reduce variable scope (spotted with memtracking on)

Options
    • -1
    • +1
    ./nsf.c
Wednesday 12 Oct 2016
3:27 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- don't call tcl eval operations from NsfLog() in phyical destroy round - extend regression test for shell with tests in [info nameofexecutable] rather than in nxhs

Options
    • -8
    • +19
    ./nsf.c
  2. … 2 more files in changeset.
Monday 10 Oct 2016
1:52 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- improve sanity test in ISOBJ(): obj->bytes might only be NULL when type is given.

Options
    • -4
    • +11
    ./nsf.c
    • -2
    • +2
    ./nsfInt.h
  3. … 1 more file in changeset.
Saturday 08 Oct 2016
3:45 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- cleanup of strnstr() (when the clib function is not available)

Options
    • -15
    • +19
    ./nsfUtil.c
3:34 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- white space changes (mostly strip trailing spaces, remove a few tabs)

Options
    • -22
    • +22
    ./nsf.c
    • -4
    • +4
    ./nsf.h
    • -36
    • +36
    ./nsfInt.h
    • -6
    • +6
    ./nsfObj.c
    • -4
    • +3
    ./nsfStack.c
    • -5
    • +13
    ./nsfUtil.c
3:29 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- reduce variable scpoes

Options
    • -8
    • +15
    ./nsf.c
3:24 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- cleanup of type conversions

Options
    • -48
    • +59
    ./nsf.c
    • -20
    • +28
    ./nsfError.c
    • -9
    • +9
    ./nsfInt.h
    • -1
    • +1
    ./nsfObj.c
    • -10
    • +10
    ./nsfProfile.c
    • -10
    • +16
    ./nsfShadow.c
    • -6
    • +7
    ./nsfUtil.c