nsf

generic

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 05 Mar
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 20 Jan
8:50 am

Gustaf Neumann <neumann@wu-wien.ac.at>

improved comment

Options
    • -2
    • +4
    ./nsf.c
Tuesday 16 Jan
4:59 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

improved spelling

Options
    • -1
    • +1
    ./nsf.c
  2. … 2 more files in changeset.
3:04 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Bug fix: potential crash and swallowed error

The change fixes 2 bugs:

- When a non-existing method was called in a situation where

* a filter with guards is registered, and

* all guards are failing, and

* the method to be called after the filter does not exist

nsf was crashing

- There was no code to produce the proper error message in such situations

Options
    • -13
    • +48
    ./nsf.c
  2. … 1 more file in changeset.
Tuesday 05 Dec 2023
1:52 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

improved spelling

Options
    • -3
    • +3
    ./nsf.c
  2. … 18 more files in changeset.
Thursday 30 Nov 2023
7:01 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nsf:parseargs: honor "required" settings

The previous version was accepting e.g.

nsf::parseargs -asdict {

{-state:wordchar,required}

{-revision_id:integer,required}

{-return_url:localurl "."}

} {}

i.e. passing empty argument list where the first two arguments are required.

Now, the error is flagged properly

Options
    • -1
    • +4
    ./nsf.c
Friday 17 Nov 2023
1:02 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

provide clean compilation for current Tcl9

Options
    • -3
    • +3
    ./nsf.c
    • -3
    • +5
    ./nsfProfile.c
Tuesday 14 Nov 2023
8:36 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

maintenance: reflect type change of Tcl TIP 666 (use Tcl_Size for object count in TIP 627)

Options
    • -1
    • +1
    ./nsf.h
Saturday 10 Jun 2023
7:35 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Provided a Tcl_DupInternalRepProc() function for Tcl_ObjType "nsfParam"

Recent versions of Tcl9 call Tcl_DupInternalRepProc() for Tcl_ObjType

"nsfParam", which was a placeholder function before, leading to a

Tcl_Abort(). The provided implementation provides now a basic logic

for "duplicating" internal representations of parameter lists based on

refcounts (somewhat similar to ProcBodyDup), but it has to be tested

further, with a proper test case.

The call of the Tcl_DupInternalRepProc function happens so far during

the startup of NaviServer compiled with Tcl9. It might be necessary to

overthink the competing logics of the "canDelete" member and the

reference count. For now, the intention is to get the NaviServer +

Tcl9 regression test stop from aborting.

Options
    • -9
    • +54
    ./nsf.c
Wednesday 19 Apr 2023
9:15 am

Gustaf Neumann <neumann@wu-wien.ac.at>

cleanup after TIP 660

Options
    • -1
    • +1
    ./nsf.c
    • -1
    • +1
    ./nsf.h
    • -7
    • +2
    ./nsfInt.h
Sunday 16 Apr 2023
7:23 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Fixed warnings detected with branch "disabletcl8api"

The Tcl9 native interface is based on "Tcl_Size" instead of "int", but

the default mode hides these differences via some macro-magic. Typical

such cases are API calls like:

Tcl_ListObjLength(interp, methodObj, &length);

Tcl_ListObjGetElements(interp, methodObj, &oc, &ov)

The macro-magic queries the size of the provided parameters and uses

the old or new interface depending on it (while hiding some more

potential problems, a compiler can detect). The branch

"disabletcl8api" removes the macro-magic and reveals the potential

problem areas, where the code is still depending on the old 32bit

interface.

This commit fixes such cases and the collateral damage.

Options
    • -91
    • +110
    ./nsf.c
    • -2
    • +32
    ./nsfCmdPtr.c
    • -4
    • +7
    ./nsfObj.c
    • -2
    • +2
    ./nsfShadow.c
    • -2
    • +3
    ./nsfStack.c
7:10 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Deactivate support of TIP 629 for the time being

When NS_TCL_HAVE_TIP629 (TIP supporting > 2^31 elements in object

vectors) is activated, Tcl defines different objProcs (Tcl_ObjCmdProc

and Tcl_ObjCmdProc2) for the old and new API, where the usage of these

depends on a cmdWrapperProc. Unfortunately, the resolving of these API

calls is performed through the wrapper via CmdWrapperInfo, which is

not exported. We have to think how to resolve these to make this

working as with prior Tcl versions.

Options
    • -0
    • +2
    ./nsf.h
12:47 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Provide support for TIP 627 (Tcl 8.7a6+ and Tcl 9)

TIP 627 introduces support for > 2^31 elements in object vectors

(e.g., number of words in a single Tcl command). For details, see

https://core.tcl-lang.org/tips/doc/trunk/tip/627.md

To provide also backwards compatibility, this change uses the macros

TCL_COMMAND_OBJPROC, TCL_CREATEOBJCOMMAND, TCL_NRCALLOBJPROC,

TCL_NRCREATECOMMAND, TCL_OBJCMDPROC_T, and TCL_OBJC_T.

Options
    • -5
    • +5
    ./gentclAPI.tcl
    • -297
    • +326
    ./nsf.c
    • -6
    • +6
    ./nsf.decls
    • -52
    • +87
    ./nsf.h
    • -255
    • +255
    ./nsfAPI.h
    • -0
    • +1
    ./nsfAccessInt.h
    • -1
    • +1
    ./nsfCmdDefinitions.c
    • -3
    • +3
    ./nsfCmdPtr.c
    • -2
    • +2
    ./nsfDebug.c
    • -2
    • +3
    ./nsfError.c
    • -12
    • +14
    ./nsfInt.h
    • -2
    • +2
    ./nsfObj.c
    • -3
    • +3
    ./nsfProfile.c
    • -22
    • +22
    ./nsfShadow.c
    • -6
    • +6
    ./nsfStack.c
  16. … 7 more files in changeset.
Saturday 15 Apr 2023
6:16 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

updated copyright notice

Options
    • -7
    • +7
    ./nsf.c
Monday 19 Dec 2022
6:59 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

improve spelling

Options
    • -1
    • +1
    ./asm/asmAssembleTemplate.c
    • -1
    • +1
    ./asm/nsfAsmAssemble.c
    • -2
    • +2
    ./nsf.c
  4. … 8 more files in changeset.
6:49 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

New feature: added support for return value checker for nsf::proc

One can now specify "-returns ...." in nsf::proc commands the same way

as in nx/XOTcl2 methods.

nsf::proc ... /procName/ /arguments/ ?-returns /valueconstraint/? /body/

When return value checkers are defined, these are returned by the

usual introspection interface.

% nsf::proc ::foo {-a:integer} -returns integer {return 1}

% nsf::cmd::info definition ::foo

::nsf::proc ::foo -a:integer -returns integer {return 1}

% nsf::cmd::info returns ::foo

integer

The regression test was extended to cover these cases.

Options
    • -42
    • +118
    ./nsf.c
    • -0
    • +1
    ./nsfAPI.decls
    • -5
    • +7
    ./nsfAPI.h
  4. … 3 more files in changeset.
Saturday 17 Dec 2022
7:55 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

extend Tcl9 compatibility

Options
    • -3
    • +3
    ./asm/asmAssembleTemplate.c
    • -6
    • +6
    ./asm/nsfAsmAssemble.c
    • -2
    • +2
    ./asm/nsfAssemble.c
    • -1
    • +1
    ./nsfCompile.c
7:54 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Fix bug, where Tcl's "string is" checker modified result, when used as a return value checker

The new code saves and restores the original result value.

The regression test was extended.

Many thanks to Antonio Pisano for pointing out this issue.

Options
    • -5
    • +21
    ./nsf.c
  2. … 1 more file in changeset.
Tuesday 22 Nov 2022
3:37 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

generalize handling of isTYPE calls by defining CHARTTYPE

The macro was developed earlier on NaviServer, and is used

in nsf for "upper", "space" and "alpha" character checkers

Options
    • -8
    • +11
    ./nsf.c
    • -1
    • +5
    ./nsfInt.h
12:48 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Provide an initializer for the new size_t field of Tcl_ObjType (Tcl 9)

Options
    • -0
    • +3
    ./nsf.c
    • -0
    • +15
    ./nsfObj.c
12:27 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

removed TCL_OUT_LINE_COMPILE, which is removed in Tcl 9.0 (many thanks to Jan Nijtmans)

Options
    • -3
    • +3
    ./nsfCompile.c
Saturday 13 Aug 2022
1:21 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

reduce warnings for other compilers

Options
    • -17
    • +17
    ./nsf.c
1:09 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

reduce warnings for clang

clang has no "-Wmaybe-uninitialized" flag

Options
    • -18
    • +52
    ./nsf.c
Thursday 11 Aug 2022
8:11 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

address the maybe-uninitialized warnings

I do not really like the approach based on pragmas, but i do even

less like the warnings, when compiled with -pedantic

Options
    • -3
    • +68
    ./nsf.c
Wednesday 10 Aug 2022
2:40 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

reduced compiler warnings when compiling against Tcl 8.6* with TIDY settings

Options
    • -21
    • +21
    ./nsf.c
    • -3
    • +3
    ./nsfStack.c
1:54 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Deactive block for double-checking chached data for Tcl commands

Leave the code for potential future debugging purposes

Options
    • -1
    • +1
    ./nsf.c
Sunday 31 Jul 2022
11:10 am

Gustaf Neumann <neumann@wu-wien.ac.at>

minor polishing

Options
    • -1
    • +1
    ./nsfDebug.c
    • -2
    • +2
    ./nsfPointer.c
Friday 29 Jul 2022
3:12 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

fix comment

Options
    • -1
    • +1
    ./nsfAccessInt.h
1:34 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

fix compilation hickups for Tcl 8.5

Options
    • -3
    • +0
    ./nsf.h
    • -4
    • +11
    ./nsfStubLib.c
Wednesday 27 Jul 2022
8:49 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

reduce warnings from redefined constants

Options
    • -1
    • +8
    ./nsf.h
    • -3
    • +0
    ./nsfInt.h
Wednesday 06 Jul 2022
1:29 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

fix typo

Options
    • -1
    • +1
    ./nsfAccessInt.h