OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 18
Total Committers: 146
Last Commit: 09:27
Commits this week: 18
Total Lines of Code (LoC): 7,560,948
Net change in LoC this week: 127

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 18 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 20 Feb 2022
6:24 pm

gustafn

Fixes for Oracle 19c: boolean and timestamp handling, *lobs

- fix boolean permission query

- function "now()" does not exist, use "CURRENT_TIMESTAMP" instead

- revived blob and clob handling in "xo::dc dml" since this is needed

for updating

- modernize Oracle offset/limit handling

- added missing "-dbn" attributes for Oracle xo::dc calls

Options
    • -14
    • +14
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
    • -11
    • +12
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
6:09 pm

gustafn

Modernize code

- use dict instead of Tcl array

- prefer char operations instead of match operations

Options
    • -6
    • +8
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
6:06 pm

gustafn

Fixes for Oracle 19c: boolean and timestamp handling

- a clause "true" is invalid in Oracle SQL (using "1=1" is fine).

- function "now()" does not exist, use "CURRENT_TIMESTAMP" instead

- addressing all attributes in a join via "*" is not allowed, when other

attributes are used as well. Using e.g., "bt.*" is OK.

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -7
    • +7
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
2:18 pm

gustafn

minor cleanup to make code more consistent

Options
    • -17
    • +7
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
2:16 pm

gustafn

avoid deprecated commands

Options
    • -1
    • +1
    /openacs-4/packages/acs-bootstrap-installer/installer.tcl
2:14 pm

gustafn

Fixes for Oracle 19c: boolean and blob handling

The original SQL query contained boolean values, and did not handle

blobs, which are used int the Oracle data model for the content

fields.

Options
    • -11
    • +11
    /openacs-4/packages/general-comments/tcl/general-comments-procs.tcl
2:09 pm

gustafn

differentiate between directly and indirectly covered API calls to make output pages easier to interprete

Options
    • -2
    • +3
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -2
    • +6
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.adp
    • -2
    • +19
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
    • -1
    • +1
    /openacs-4/packages/acs-automated-testing/www/resources/tests.css
Friday 18 Feb 2022
7:32 pm

gustafn

added file content checker for zip, gzip and dump imports

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -11
    • +20
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
    • -3
    • +13
    /openacs-4/packages/xowiki/www/admin/import.tcl
4:19 pm

antoniop

The reorder_box must always be treated as a multiple field

Options
    • -1
    • +9
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
3:11 pm

antoniop

Enforce boolean expressions, rather than specific values such as "t" or "1"

Options
    • -19
    • +24
    /openacs-4/packages/acs-developer-support/tcl/test/acs-developer-support-procs.tcl
2:30 pm

antoniop

Improve keyboard usability: focus the comment textarea when the modal opens and focus back on the comment button when the modal closes

Options
    • -1
    • +4
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
2:25 pm

antoniop

Account for the scrollbar when enlarging the image

Options
    • -0
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
2:17 pm

antoniop

Enlarge images to fullscreen when one clicks on them

Options
    • -0
    • +34
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
2:05 pm

gustafn

remove one more case where assumption was that permission returns int

Options
    • -2
    • +3
    /openacs-4/packages/acs-developer-support/tcl/test/acs-developer-support-procs.tcl
1:56 pm

gustafn

Make use of util::file_content_check and check also in other cases

This change also covers the case, where the checkmark for uploading

zip files was added marked in "upload file". It will also report

errors which were silently swalled before.

Bumped version number to 5.10.1d1

Options
    • -3
    • +3
    /openacs-4/packages/file-storage/file-storage.info
    • -3
    • +17
    /openacs-4/packages/file-storage/www/file-add.tcl
    • -5
    • +3
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
1:37 pm

gustafn

util::file_content_check: new utility for checking content of a file

Check whether the provided file is of the requested type.

This function is more robust and protable than relying on

external programs and their output, but it does not work on

all possible file types. It checks a few common cases that

could lead to problems otherwise, like when uploading archives.

Bump version to 5.10.1d9

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -2
    • +40
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -0
    • +24
    /openacs-4/packages/acs-tcl/tcl/test/utilities-procs.tcl
1:34 pm

gustafn

minor changes: don't complain about postgres internal constraint names, provide hints for oversizing

Options
    • -11
    • +33
    /openacs-4/packages/acs-tcl/tcl/test/datamodel-test-procs.tcl
1:30 pm

antoniop

Don't set height explicitly

Options
    • -1
    • +0
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
1:21 pm

antoniop

Fix filtering condition, improve doc

Options
    • -1
    • +8
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
1:14 pm

antoniop

Explicitly set the :plugin <variable>

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
12:50 pm

gustafn

more cases, use same testing idiom for permissions everywhere, break overlong lines

Options
    • -10
    • +16
    /openacs-4/packages/acs-tcl/tcl/test/test-permissions-procs.tcl
12:45 pm

gustafn

fix test cases

Options
    • -14
    • +14
    /openacs-4/packages/acs-tcl/tcl/test/test-permissions-procs.tcl
12:36 pm

gustafn

revert last change of Antonio, since this kills Oracle again

It is not clear, which code needs integer as results for Boolean results.

If there is such code, it should handle this requirement locally.

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-procs.tcl
11:16 am

antoniop

Include the supplied text_id among the fields we should replace

Options
    • -3
    • +3
    /openacs-4/packages/richtext-xinha/tcl/richtext-procs.tcl
11:14 am

antoniop

Support the extraPlugins attribute the same as the CKEditor4 richtext formfield, as some places in xowiki assume it

Options
    • -2
    • +5
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
10:58 am

trenner

provide value attribute

Options
    • -2
    • +2
    /openacs-4/packages/file-storage/www/version-delete.tcl
10:42 am

antoniop

Reintroduce cast to integer using a portable idiom

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-procs.tcl
10:29 am

antoniop

Prefer cached API

Options
    • -6
    • +5
    /openacs-4/packages/tsearch2-driver/tcl/tsearch2-driver-procs.tcl
Thursday 17 Feb 2022
9:28 pm

gustafn

improve input validation

Options
    • -1
    • +3
    /openacs-4/packages/notifications/www/request-new.tcl
9:19 pm

gustafn

added validator for zip files

Options
    • -2
    • +25
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl