OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 07 May
8:59 am

antoniop

Fallback to the editor from parameter in the generic api, rather than the widget, so fallback will work also outside of ad_form

Options
    • -6
    • +13
    /openacs-4/packages/acs-templating/tcl/richtext-procs.tcl
Monday 06 May
4:47 pm

antoniop

Introduce for richtext editors the concept of "preset"

A preset is an abstract set configurations designed to address a specific use case.

An example could be a preset for a "minimal" richtext editor, used in those forms where we want to limit the features a user should have access to. Other presets could address specific usages or applications.

Downstream developers can provide a set of ::richtext::$editor::preset::$preset procs, returning an options dict. This set of options will be merged other local configurations.

The same approach works in ad_forms and xowiki forms.

This also enables the use-case of switching to a different editor maintaining the existing application-specific configurations consistent.

Options
    • -0
    • +21
    /openacs-4/packages/acs-templating/tcl/richtext-procs.tcl
    • -2
    • +34
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
2:27 pm

antoniop

Drop the old approacs based on ::acs_blank_master__htmlareas and use explicit id configuration

Options
    • -7
    • +3
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
Thursday 02 May
4:06 pm

antoniop

TinyMCE XoWiki formfield integration

We introduce a new richtext mixin richtext::tinymce, requiring the richtext-tinymce package, currently integrating TinyMCE editor 7.0.1.

This implementation has been tested with regular, repeat, compound and repeatedcompound fields.

Downstream implementations based on this formfield can customize the editor configuration further, e.g. provide custom plugins via the api parameters.

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -1
    • +207
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
3:29 pm

antoniop

Move hardcoded configuration out of the default (can be overridden by parameter in case), add image and code plugins in the default, set branding to false by default

Options
    • -7
    • +5
    /openacs-4/packages/richtext-tinymce/richtext-tinymce.info
    • -1
    • +2
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
3:13 pm

antoniop

Add a richtext to the test formfields specifications

Options
    • -0
    • +2
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
2:47 pm

antoniop

Move back richtext formfield implementations in form-field-procs

Moving to a different file may affect dependencies defined on form-field-procs that also expect the richtext editor to be loaded. As breaking changes are not desirable now, we revert this reform.

Options
    • -1
    • +527
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -546
    • +0
    /openacs-4/packages/xowiki/tcl/richtext-procs.tcl
1:54 pm

antoniop

Add minimal styling to inline editors

Options
    • -1
    • +5
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
    • -0
    • +7
    /openacs-4/packages/richtext-tinymce/www/resources/css/style.css
1:54 pm

antoniop

file style.css was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/css/style.css
Tuesday 30 Apr
5:08 pm

antoniop

Allow to serialize also object options, allow to only include the header stuff

Options
    • -3
    • +14
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
9:14 am

antoniop

Cleanup leftover code from successful reform in December 2016

Since then, we have been long using dynamic repeat fields on production

Options
    • -15
    • +5
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -59
    • +0
    /openacs-4/packages/xowiki/www/resources/repeat.js
Monday 29 Apr
6:05 pm

antoniop

Move the specific richtext-editor implementations into an own file

Options
    • -527
    • +1
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -0
    • +546
    /openacs-4/packages/xowiki/tcl/richtext-procs.tcl
6:05 pm

antoniop

file richtext-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowiki/tcl/richtext-procs.tcl
5:38 pm

antoniop

Rework the add_editor api so that it won't rely on global templating variables and fix both configuration from defaults and local

Options
    • -3
    • +3
    /openacs-4/packages/richtext-tinymce/richtext-tinymce.info
    • -53
    • +71
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
4:00 pm

antoniop

Harden the page contract and ensure that:

- for chat rooms in the chat package, only the chat class enforcing permissions is used

- for other chat ids, either the id is an object the user can read, or the user can at least read on the current connection package

Options
    • -31
    • +58
    /openacs-4/packages/acs-subsite/www/shared/ajax/chat.tcl
2:26 pm

antoniop

Cleanup old parameter on upgraded installations

Options
    • -2
    • +3
    /openacs-4/packages/richtext-tinymce/richtext-tinymce.info
    • -0
    • +49
    /openacs-4/packages/richtext-tinymce/tcl/apm-callback-procs.tcl
2:26 pm

antoniop

file apm-callback-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/richtext-tinymce/tcl/apm-callback-procs.tcl
2:08 pm

antoniop

file download.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/richtext-tinymce/www/sitewide-admin/download.tcl
2:08 pm

antoniop

file index.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/richtext-tinymce/www/sitewide-admin/index.tcl
2:08 pm

antoniop

file index.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/richtext-tinymce/www/sitewide-admin/index.adp
2:08 pm

antoniop

TinyMCE 7.0.1 integration

We reboot TinyMCE richtext-editor integration to support newest version 7.0.1.

Editor can be served from CDN (requires an API key) or locally, by downloading a distribution via the site-wide admin page of the package.

Editor can be configured either per-website or per-usage, as we do with other editors.

At present, no OpenACS specific features, such as image upload, are provided. Custom plugins from previous versions of this package have also been discontinued.

Notable differences with similar integrations:

- editor configuration is specified as a dict, rather than a list of lists

- current package parameters are global, rather than de-facto global instance parameters

- deprecated configuration from acs-templating is not supported anymore

Options
    • -30
    • +13
    /openacs-4/packages/richtext-tinymce/richtext-tinymce.info
    • -140
    • +266
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
    • -1116
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/tinymce/changelog.txt
    • -111
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/tinymce/examples/custom_formats.html
    • -101
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/tinymce/examples/full.html
    • -10
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/tinymce/examples/index.html
    • -17
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/tinymce/examples/menu.html
    • -47
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/tinymce/examples/simple.html
    • -216
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/tinymce/examples/skins.html
    • -84
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/tinymce/examples/translate.html
    • -71
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/tinymce/examples/word.html
    • -105
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/tinymce/examples/css/content.css
    • -53
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/tinymce/examples/css/word.css
    • -9
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/tinymce/examples/lists/image_list.js
    • -10
    • +0
    /openacs-4/packages/richtext-tinymce/www/resources/tinymce/examples/lists/link_list.js
  16. … 1804 more files in changeset.
Friday 26 Apr
3:18 pm

trenner

harden page_contract

Options
    • -2
    • +2
    /openacs-4/packages/chat/www/room-exit.tcl
Thursday 25 Apr
3:50 pm

antoniop

Make test more robust in setups where we cache permissions

Options
    • -2
    • +39
    /openacs-4/packages/acs-tcl/tcl/test/test-permissions-procs.tcl
3:11 pm

antoniop

Cleanup commented code

Options
    • -5
    • +1
    /openacs-4/packages/acs-subsite/tcl/group-procs.tcl
Wednesday 24 Apr
4:32 pm

antoniop

Only allow valid privileges in the privs parameter

Options
    • -0
    • +17
    /openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl
4:06 pm

trenner

restrict substitution in string

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl
12:40 pm

antoniop

Implement a package-specific page contract filter to collect current (and future) security fixes

Options
    • -1
    • +39
    /openacs-4/packages/general-comments/tcl/general-comments-procs.tcl
    • -29
    • +2
    /openacs-4/packages/general-comments/www/comment-add-2.tcl
    • -19
    • +2
    /openacs-4/packages/general-comments/www/comment-edit-2.tcl
12:25 pm

antoniop

Reject frames and iframes in the content

Options
    • -2
    • +12
    /openacs-4/packages/general-comments/www/comment-add-2.tcl
Tuesday 23 Apr
6:21 pm

antoniop

Prevent sneaking symlinks in the content repository

Many thanks to Thomas Rennner and Günter Ernst for analyzing the issue

Options
    • -1
    • +11
    /openacs-4/packages/acs-content-repository/tcl/content-procs.tcl
4:43 pm

antoniop

cr_write_content reform

when serving files, do not trust the content information, as the absolute path to the file can be determined programmatically in this case.

This also reduce divergency between Oracle and Postgres

Options
    • -8
    • +0
    /openacs-4/packages/acs-content-repository/tcl/revision-procs-oracle.xql
    • -8
    • +0
    /openacs-4/packages/acs-content-repository/tcl/revision-procs-postgresql.xql
    • -14
    • +9
    /openacs-4/packages/acs-content-repository/tcl/revision-procs.tcl