Activity OpenACS/

5:47 pm

antoniop

Reduce divergency between Oracle and Postgres codebase

- -47
- +0
/openacs-4/packages/chat-portlet/www/chat-portlet-oracle.xql
- History
- Source
- Diff
/openacs-4/.../chat-portlet-oracle.xql
- -47
- +0
/openacs-4/packages/chat-portlet/www/chat-portlet-postgresql.xql
- History
- Source
- Diff
/openacs-4/.../chat-portlet-postgresql.xql
- -6
- +27
/openacs-4/packages/chat-portlet/www/chat-portlet.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/chat-portlet.tcl

5:33 pm

antoniop

Cleanup the vestigial moderated_p flag

- -3
- +3
/openacs-4/packages/chat/chat.info
- History
- Source
- Diff
/openacs-4/packages/chat/chat.info
- -0
- +5
/openacs-4/packages/chat/tcl/apm-callback-procs.tcl
- History
- Source
- Diff
/openacs-4/.../apm-callback-procs.tcl
- -5
- +5
/openacs-4/packages/chat/tcl/chat-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/chat-procs.tcl
- -2
- +0
/openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xotcl-chat-procs.tcl
- -1
- +0
/openacs-4/packages/chat/tcl/test/chat-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../chat-test-procs.tcl
- -2
- +1
/openacs-4/packages/chat/www/index.tcl
- History
- Source
- Diff
/openacs-4/packages/chat/www/index.tcl
- -6
- +0
/openacs-4/packages/chat/www/room-edit.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/room-edit.tcl
- -4
- +1
/openacs-4/packages/chat/www/room.tcl
- History
- Source
- Diff
/openacs-4/packages/chat/www/room.tcl
- -2
- +0
/openacs-4/packages/chat-portlet/www/chat-portlet-oracle.xql
- History
- Source
- Diff
/openacs-4/.../chat-portlet-oracle.xql
- -2
- +0
/openacs-4/packages/chat-portlet/www/chat-portlet-postgresql.xql
- History
- Source
- Diff
/openacs-4/.../chat-portlet-postgresql.xql

5:15 pm

antoniop

Get rid of the intermediate "room-enter" page and enforce all of the relevant permission in place in the "chat" page, cleanup variables and update automated tests

- -1
- +0
/openacs-4/packages/chat/tcl/test/chat-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../chat-test-procs.tcl
- -9
- +2
/openacs-4/packages/chat/tcl/test/webtest-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../webtest-procs.tcl
- -24
- +9
/openacs-4/packages/chat/www/chat.tcl
- History
- Source
- Diff
/openacs-4/packages/chat/www/chat.tcl
- -2
- +2
/openacs-4/packages/chat/www/index.tcl
- History
- Source
- Diff
/openacs-4/packages/chat/www/index.tcl
- -36
- +0
/openacs-4/packages/chat/www/room-enter.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/room-enter.tcl
- -1
- +1
/openacs-4/packages/chat-portlet/www/chat-portlet.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/chat-portlet.tcl

4:12 pm

antoniop

Update api

- -7
- +5
/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xowiki-www-procs.tcl

3:55 pm

antoniop

Modernize api

- -6
- +4
/openacs-4/packages/richtext-ckeditor4/tcl/ckfinder-init.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/ckfinder-init.tcl

3:50 pm

antoniop

Modernize idiom

- -10
- +5
/openacs-4/packages/calendar/www/view-list-display.tcl
- History
- Source
- Diff
/openacs-4/packages/.../view-list-display.tcl

3:35 pm

antoniop

Use modern api

- -12
- +7
/openacs-4/packages/acs-templating/tcl/table-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/table-procs.tcl

3:23 pm

antoniop

Update api to streamline idiom

- -15
- +4
/openacs-4/packages/acs-templating/tcl/form-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/form-procs.tcl

2:38 pm

antoniop

Update api

- -3
- +2
/openacs-4/packages/acs-templating/tcl/list-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/list-procs.tcl
- -5
- +1
/openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
- History
- Source
- Diff
/openacs-4/.../form-processing-procs.tcl

2:33 pm

antoniop

No need to access the form directly here

- -2
- +1
/openacs-4/packages/acs-bootstrap-installer/installer.tcl
- History
- Source
- Diff
/openacs-4/packages/.../installer.tcl

2:27 pm

antoniop

ns_getform will return the empty string only when invoked outside of a connection thread, which is a non-issue at installation time

- -26
- +17
/openacs-4/packages/acs-bootstrap-installer/installer.tcl
- History
- Source
- Diff
/openacs-4/packages/.../installer.tcl

4:04 pm

antoniop

Deprecate trivial wrappers to the NaviServer API

Modern ns_getform will not return the empty string for empty requests, but only when we are operating outside of a connection. In such circumstances is arguably useful to manipulate the request parameters.

- -6
- +27
/openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
- History
- Source
- Diff
/openacs-4/.../request-processor-procs.tcl
- -3
- +2
/openacs-4/packages/acs-templating/www/doc/tagref/include.adp
- History
- Source
- Diff
/openacs-4/packages/.../tagref/include.adp
- -4
- +4
/openacs-4/packages/acs-templating/www/doc/tagref/include.html
- History
- Source
- Diff
/openacs-4/packages/.../tagref/include.html

4:02 pm

antoniop

Commit missing change to the users api

- -2
- +1
/openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
- History
- Source
- Diff
/openacs-4/.../community-core-procs.tcl

4:01 pm

antoniop

Prefer Naviserver API directly

- -2
- +1
/openacs-4/packages/acs-admin/www/apm/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../apm/index.tcl

3:55 pm

antoniop

Prefer NaviServer API directly

- -2
- +2
/openacs-4/packages/acs-api-browser/www/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/index.tcl

3:49 pm

antoniop

More
MAIN:antoniop:20230328134946
changed 1 file
MAIN

Rework idiom

- -2
- +5
/openacs-4/packages/news-aggregator/www/opml.vuh
- History
- Source
- Diff
/openacs-4/packages/.../www/opml.vuh

3:47 pm

antoniop

Rework idiom

- -5
- +8
/openacs-4/packages/faq/www/index.vuh
- History
- Source
- Diff
/openacs-4/packages/faq/www/index.vuh

3:45 pm

antoniop

Exploit page contract, rework idioms

- -8
- +8
/openacs-4/packages/dotlrn/www/members.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/members.tcl

3:34 pm

antoniop

Don't run the spiel when we are not connected

- -7
- +9
/openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../01-debug-procs.tcl

3:22 pm

antoniop

More
MAIN:antoniop:20230328132229
changed 1 file
MAIN

Streamline idiom

- -3
- +2
/openacs-4/packages/news-aggregator/www/index.vuh
- History
- Source
- Diff
/openacs-4/packages/.../www/index.vuh

3:12 pm

antoniop

Streamline idiom

- -4
- +3
/openacs-4/packages/news/www/item.vuh
- History
- Source
- Diff
/openacs-4/packages/news/www/item.vuh

2:58 pm

antoniop

Whitespace cleanup

- -5
- +5
/openacs-4/packages/acs-admin/www/apm/version-edit-2.tcl
- History
- Source
- Diff
/openacs-4/packages/.../version-edit-2.tcl

2:58 pm

antoniop

Modernize api

- -2
- +2
/openacs-4/packages/acs-admin/www/apm/version-edit-2.tcl
- History
- Source
- Diff
/openacs-4/packages/.../version-edit-2.tcl

2:46 pm

antoniop

Inline rp_getform usage

- -3
- +5
/openacs-4/packages/assessment/www/asm-admin/sessions.tcl
- History
- Source
- Diff
/openacs-4/packages/.../sessions.tcl

2:43 pm

antoniop

rp_getform will never return the empty string, small cleanup

- -10
- +6
/openacs-4/packages/assessment/tcl/as-list-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/as-list-procs.tcl

1:20 pm

antoniop

Remove no_alarms_until column

Rationale: the column or the related api is never used in upstream code to check whether notifications should be sent or not or not. The UI to manage the column's value was not linked anywhere. On the instances accessible by me downstream, no tuple was found where this column had a value.