OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 14
Total Committers: 146
Last Commit: 17:24
Commits this week: 14
Total Lines of Code (LoC): 7,560,967
Net change in LoC this week: 146

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 06 Sep 2022
1:43 pm

antoniop

Deprecate util_get_current_url, superseded by ad_return_url

Options
    • -2
    • +7
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
1:17 pm

antoniop

Deprecate export_entire_form_as_url_vars and replace occurrences, add a new -formvars flag to export vars to implement the behavior of the proc, that is, export a subset of the variables coming from the current request

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/complex-search.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/search.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
    • -4
    • +31
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +1
    /openacs-4/packages/chat/www/search-2.tcl
11:44 am

antoniop

Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/complex-search.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/search.tcl
    • -2
    • +2
    /openacs-4/packages/acs-developer-support/www/request-info.tcl
    • -2
    • +2
    /openacs-4/packages/acs-lang/www/admin/message-list.tcl
    • -3
    • +3
    /openacs-4/packages/acs-subsite/www/shared/confirm.tcl
    • -7
    • +19
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/dimensional-procs.tcl
    • -1
    • +1
    /openacs-4/packages/chat/www/search-2.tcl
    • -2
    • +2
    /openacs-4/packages/general-comments/www/index.tcl
    • -2
    • +2
    /openacs-4/packages/general-comments/www/view-comment.tcl
    • -2
    • +2
    /openacs-4/packages/general-comments/www/admin/index.tcl
    • -2
    • +2
    /openacs-4/packages/new-portal/tcl/portal-procs.tcl
10:15 am

antoniop

Reimplement util_subset_p

Options
    • -39
    • +25
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
9:42 am

antoniop

Deprecate util_report_successful_library_load

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
9:40 am

antoniop

Deprecate util_commify_number, replace occurrences and translate automated tests

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/index.tcl
    • -3
    • +3
    /openacs-4/packages/acs-subsite/www/admin/group-types/delete.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/rel-segments/one.tcl
    • -2
    • +14
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -20
    • +20
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -2
    • +2
    /openacs-4/packages/attachments/www/file-add-2.tcl
    • -1
    • +1
    /openacs-4/packages/chat/www/search.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/community-edit-2.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn-homework/www/file-add.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn-homework/www/version-add.tcl
8:50 am

antoniop

Whitespace cleanup

Options
    • -8
    • +8
    /openacs-4/packages/acs-admin/www/users/index.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/rel-segments/one.tcl
7:48 am

antoniop

Deprecate export_entire_form

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
7:21 am

antoniop

Deprecate util_AnsiDatetoPrettyDate

Options
    • -2
    • +7
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -2
    • +2
    /openacs-4/packages/assessment/www/asm-admin/one-a.tcl
    • -2
    • +2
    /openacs-4/packages/survey/www/admin/one.tcl
7:09 am

antoniop

Deprecate util_report_library_entry

Options
    • -2
    • +9
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
6:55 am

antoniop

Formatting changes

Options
    • -14
    • +30
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Monday 05 Sep 2022
6:43 pm

antoniop

Deprecate util::string_check_urlsafe

Options
    • -2
    • +6
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
6:32 pm

antoniop

Simplify implementation

Options
    • -54
    • +6
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
5:57 pm

antoniop

After some experiments, reinstate the faster version of util_sets_equal_p: this wins (~20% faster) in particular when the sets to be compared are larger

Options
    • -15
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
5:19 pm

antoniop

Cleanup duplicated and slower proc definition

Options
    • -13
    • +1
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
5:07 pm

antoniop

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/pvt/alerts.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -11
    • +8
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
    • -2
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
4:48 pm

antoniop

Use faster idiom to tell if a string is only space

Options
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
4:10 pm

antoniop

Fall back to en_US also when a value for nls_language is there, but empty

Options
    • -2
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
1:31 pm

antoniop

Use api to determine whether a field is disabled, as the "disabled" variable will always be set now

Options
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
Friday 02 Sep 2022
4:15 pm

antoniop

Claim additional coverage

Options
    • -1
    • +4
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
4:14 pm

antoniop

Count already exisring handlers before introducing new ones

Options
    • -4
    • +11
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
3:18 pm

antoniop

Improve acs::test::form_reply so that when the attributes of a file upload (*.tmpfile or *.content-type) are part of the update argument, it will switch automatically to a multipart request and implement a "real" file upload

This is important on newer NaviServer versions that will reject any *.tmpfile parameter in a request that was not produced internally after a file upload

Options
    • -14
    • +45
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -31
    • +0
    /openacs-4/packages/acs-templating/tcl/test/file-procs.tcl
1:15 pm

trenner

add the amount of questions from the exam in the title

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
10:46 am

antoniop

Test also nonce rendering

Options
    • -1
    • +7
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
10:31 am

antoniop

Make test more precise

Options
    • -9
    • +12
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
Thursday 01 Sep 2022
6:56 pm

antoniop

Test a bunch more api

Options
    • -1
    • +146
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
6:19 pm

antoniop

Test template::adp_level, fix test coverage declaration

Options
    • -3
    • +36
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
6:10 pm

antoniop

Test template::adp_parse_string

Options
    • -1
    • +16
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
6:04 pm

antoniop

Deprecate template::adp_levels, found nowhere in the upstream codebase and superseded by template::adp_level

Options
    • -2
    • +3
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
5:52 pm

antoniop

Increase proc coverage

Options
    • -39
    • +62
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl