OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 18
Total Committers: 146
Last Commit: 28 Nov
Commits this week: 18
Total Lines of Code (LoC): 7,560,946
Net change in LoC this week: 3

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 05 Sep 2022
5:07 pm

antoniop

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/pvt/alerts.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -11
    • +8
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
    • -2
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
4:48 pm

antoniop

Use faster idiom to tell if a string is only space

Options
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
4:10 pm

antoniop

Fall back to en_US also when a value for nls_language is there, but empty

Options
    • -2
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
1:31 pm

antoniop

Use api to determine whether a field is disabled, as the "disabled" variable will always be set now

Options
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
Friday 02 Sep 2022
4:15 pm

antoniop

Claim additional coverage

Options
    • -1
    • +4
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
4:14 pm

antoniop

Count already exisring handlers before introducing new ones

Options
    • -4
    • +11
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
3:18 pm

antoniop

Improve acs::test::form_reply so that when the attributes of a file upload (*.tmpfile or *.content-type) are part of the update argument, it will switch automatically to a multipart request and implement a "real" file upload

This is important on newer NaviServer versions that will reject any *.tmpfile parameter in a request that was not produced internally after a file upload

Options
    • -14
    • +45
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -31
    • +0
    /openacs-4/packages/acs-templating/tcl/test/file-procs.tcl
1:15 pm

trenner

add the amount of questions from the exam in the title

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
10:46 am

antoniop

Test also nonce rendering

Options
    • -1
    • +7
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
10:31 am

antoniop

Make test more precise

Options
    • -9
    • +12
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
Thursday 01 Sep 2022
6:56 pm

antoniop

Test a bunch more api

Options
    • -1
    • +146
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
6:19 pm

antoniop

Test template::adp_level, fix test coverage declaration

Options
    • -3
    • +36
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
6:10 pm

antoniop

Test template::adp_parse_string

Options
    • -1
    • +16
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
6:04 pm

antoniop

Deprecate template::adp_levels, found nowhere in the upstream codebase and superseded by template::adp_level

Options
    • -2
    • +3
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
5:52 pm

antoniop

Increase proc coverage

Options
    • -39
    • +62
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
5:32 pm

antoniop

State additional proc coverage, improve documentation

Options
    • -2
    • +4
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
    • -0
    • +1
    /openacs-4/packages/acs-templating/tcl/test/file-procs.tcl
    • -1
    • +2
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
5:03 pm

antoniop

Make template::head::prepare_multirows a private interface: its stated purpose is to be used inside of the blank-master and it has no practical use otherwise

Options
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/head-procs.tcl
4:50 pm

antoniop

Make adp_parse_ad_conn_file a private interface: its stated purpose is to be registered via rp_register_extension_handler in acs-templating/tcl/acs-integration-init.tcl and it has no practical use otherwise

Options
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/acs-integration-procs.tcl
2:58 pm

antoniop

Test ad_return_template

Options
    • -5
    • +76
    /openacs-4/packages/acs-templating/tcl/test/acs-integration-procs.tcl
2:33 pm

antoniop

Reuse computation

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/user/portrait/index.tcl
2:31 pm

antoniop

Avoid catch where a more appropriate idiom exists

Options
    • -8
    • +10
    /openacs-4/packages/acs-subsite/www/user/portrait/index.tcl
2:28 pm

antoniop

Improve documentation

Options
    • -1
    • +6
    /openacs-4/packages/acs-subsite/www/user/portrait/index.tcl
2:21 pm

antoniop

Cleanup case

Options
    • -4
    • +0
    /openacs-4/packages/acs-subsite/www/user/portrait/index.adp
2:17 pm

antoniop

Whitespace cleanup

Options
    • -3
    • +3
    /openacs-4/packages/acs-subsite/www/user/portrait/index.tcl
2:17 pm

antoniop

Harden page contract

Options
    • -10
    • +2
    /openacs-4/packages/acs-subsite/www/user/portrait/index.tcl
11:50 am

antoniop

Extend regression test

Options
    • -5
    • +64
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
9:21 am

trenner

if truncate_len is provided we have to call util_close_html_tags for truncating the string

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
12:41 am

antoniop

Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

Options
    • -17
    • +21
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
    • -0
    • +59
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
    • -1
    • +1
    /openacs-4/packages/file-storage/tcl/test/webtest-procs.tcl
Wednesday 31 Aug 2022
2:55 pm

antoniop

Reimplement upload automated test using a real multipart request, as newer naviserver will reject handcrafted .tmpfile parameters

Options
    • -9
    • +19
    /openacs-4/packages/file-storage/tcl/test/webtest-procs.tcl
2:51 pm

antoniop

Extend util::http::post_payload and util::http::post to receive form varaibles also in dict form, update documentation

Options
    • -22
    • +58
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl