• last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reduce divergency between oracle and postgres codebase

Use tcl to do date calculations instead of db, reduce postgres/oracle divergencies

Reduce divergence between oracle and postgres codebase, optimize queries

    • -48
    • +0
    /openacs-4/packages/news/www/index-oracle.xql
    • -3
    • +3
    /openacs-4/packages/news/www/index.tcl
    • -1
    • +41
    /openacs-4/packages/news/www/index.xql
Do date calculations in tcl rather than in db, reduce oracle and postgres divergency

    • -2
    • +4
    /openacs-4/packages/news/www/item-create.tcl
Reduce divergence between oracle and postgres code

    • -4
    • +2
    /openacs-4/packages/news/lib/latest-news.tcl
    • -0
    • +10
    /openacs-4/packages/news/lib/latest-news.xql
Reduce oracle/postgres divergence

Uniform sql codebase

Use cached api instead of query to retrieve node id from community and community_type

Remove unused query from xql (no usage was found upstream and on Learn@WU)

Get rid of dual idiom

Oracle doesn't support limit :-|

Streamline and optimize idiom

Declare explicitly the only column we need in a way that DBMS can create a better query plan

Tolerate the same request variable specified multiple times

We use export_vars as arbiter to decide how this will be treated.

Also remove some postgres/oracle divergence

Replace db date conversion with tcl one, remove unneded statements (sort_by is already defined in page contract, ad_return_template is implicit)

Fix typo

Port downstream only usage of reading info api

Also fix such api so that root message is retrieved for every given source message

    • -2
    • +2
    /openacs-4/packages/forums/forums.info
Converge downstream reading_info feature with upstream

Port downstream only idiom to update reading_info table

Make more use of api when retrieving forum and message information

Optimize message existance query

Fix sql update to populate new forum_id column in existing data

Maintenance of forum reading count feature

- removal of forums_reading_info_user (1Mio rows on Learn@WU).

This materialized view had to be constantly synced with

forums_reading_info table. Reimplemented as view.

- simplify logics in stored procedure due to new datamodel

- fix inconsistencies between oracle and postgres function definition

- re-enabled parameter to decide whether use these stats or not in

administration

TODO: consider further reform of this feature as stats grow very

large on busy sites for probably little value added

    • -2
    • +2
    /openacs-4/packages/forums/forums.info
    • -5
    • +2
    /openacs-4/packages/forums/tcl/forums-procs.tcl
Remove deprecated idioms and unneded queries

Persist sanitized timestamp into data object before saving (Many thanks to Markus Moser)

Implement post anonymously through explicit forum attribute in table

Now moderators can explicitly decide whether a forum will enable posting anonymously or not.

Forum must be in a policy different from closed and the anonymous flag must be set accordingly for this to happen.

Also:

- normalize api in a way it can accomodate all current attributes. In particular,

now edit api will now leave every unspecified attribute unchanged, instead of

setting it to some default.

- fix some usability issues when managing forum parameters (e.g. values not

retrieved in form when editing existing forum)

- introduce missing Oracle upgrade script for the whole forum reform

- fix oracle creation script

    • -2
    • +2
    /openacs-4/packages/forums/forums.info
    • -18
    • +18
    /openacs-4/packages/forums/lib/forums/new.tcl
    • -7
    • +27
    /openacs-4/packages/forums/tcl/forums-procs.tcl
    • -8
    • +12
    /openacs-4/packages/forums/tcl/forums-procs.xql
Update docs: remove broken links and remove/update obsolete section

  1. … 285 more files in changeset.
further cleanup for XOTcl2

    • -99
    • +101
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
    • -24
    • +0
    /openacs-4/packages/xowiki/www/edit.adp
Simplify idiom

Since PostgreSQL 10 does not support the tsearch2 backword compatibility package anymore, make sure that OpenACS does not use the old names requiring this package.

Revert db_exec_plsql or Oracle will break, remove leftover xql files

restrict detail statistics to swa

Optimize query by using multi-object permission checking and trying to filter the most tuples before joining cr_items with cr_revisions