• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- protect against certain characters in return_url (the real solution is probably a fix in ad_form, which could cause some collateral damage)

  1. … 1 more file in changeset.
- prefer "localurl" over "return_url" of name of page filter

    • -2
    • +2
    ./admin/applications/application-add.tcl
  1. … 76 more files in changeset.
- improve checking of return_urls in page_contracts

    • -2
    • +2
    ./admin/applications/application-add.tcl
    • -2
    • +2
    ./admin/group-types/change-join-policy.tcl
  1. … 73 more files in changeset.
- improve checking for return_url handling in page_contracts

CVS: ----------------------------------------------------------------------

  1. … 1 more file in changeset.
- don't produce errors on too-large or invalid object_ids

- hardening validator

- add missing title property

- fix quoting in SQL

- make code more robust

- remove unused files. parameter-set.tcl was deleted already some time ago

    • -36
    • +0
    ./admin/site-map/parameter-set-2.tcl
    • -14
    • +0
    ./admin/site-map/parameter-set-2.xql
    • -34
    • +0
    ./admin/site-map/parameter-set-oracle.xql
- handle case where item has no live_revision

- fix lob interface (especially for portraits)

  1. … 5 more files in changeset.
- write sql statements between curly braces

    • -11
    • +17
    ./shared/portrait-thumbnail-bits.tcl
  1. … 3 more files in changeset.
.xql-file reform of acs-subsite:

- remove queries from .tcl files that can't work

from PostgreSQL (e.g. containing "connect by" or "nvl")

- remove obsolete file www/admin/site-map/parameter-set.tcl

    • -8
    • +2
    ./admin/group-types/change-join-policy.tcl
    • -106
    • +0
    ./admin/site-map/parameter-set.tcl
  1. … 3 more files in changeset.
.xql-file reform of acs-subsite:

- remove obsolete queries

email_image::new_item.new_lob_size

email_image::new_item.new_lob_size

group::member_p.group_id_from_name

subsite::default::create_app_group.group_exists

package_mounted_p

- add missing Oracle queries

acs-subsite/tcl/rel-types-procs-oracle.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

rel_types::additional_rel_types_group_type_p.group_rel_type_exists

www/admin/group-types/new-oracle.xql

select_group_supertypes

- add missing PostgreSQL queries

acs-subsite/tcl/rel-types-procs-postgresql.xql.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

- remove obsolete files

www/admin/index-oracle.xql

www/admin/index-postgresql.xql

www/admin/index.xql

www/admin/rel-types/roles/new-oracle.xql

www/admin/rel-types/roles/new-postgresql.xql

www/permissions/one.xql

www/pvt/unsubscribe-2-oracle.xql

www/pvt/unsubscribe-2-postgresql.xql

www/pvt/unsubscribe-oracle.xql

www/pvt/unsubscribe-postgresql.xql

www/pvt/unsubscribe.xql

www/register/user-new.xql

www/shared/portrait-bits-oracle.xql

www/shared/portrait-bits-postgresql.xql

www/shared/portrait-bits.xql

    • -9
    • +5
    ./admin/group-types/new-postgresql.xql
    • -15
    • +0
    ./admin/rel-types/roles/new-oracle.xql
    • -13
    • +0
    ./admin/rel-types/roles/new-postgresql.xql
  1. … 12 more files in changeset.
- improve portrait bits to provide cached scaling and caching

- fix old security hole, that allowed to download arbitrary files given a known item_id

- prepare documentation for release

    • -1
    • +1
    ./doc/group-admin-pages-acceptance-test.adp
    • -1
    • +1
    ./doc/group-admin-pages-requirements.adp
  1. … 219 more files in changeset.
.xql overhaul:

- removed misleading sql-statements from db_* calls, which were

ignored due .xql files

- removed bug where same query name was used in a single proc

with different intended sql queries, but the same was picked

up from the .xql file due to the name

- removed multiple entries of same query name from .xql files

(e.g. the entry "package_create_attribute_list.select_type_info" was

7 (!!!) times in a single .xql file)

- removed redundant queries for unsupported versions of the dbms

- added missing xql entries for db-backends, where other db-specific

queries exists (e.g. added an entry to -oracle.xql, where an entry

existed in -postgres.xql)

    • -24
    • +0
    ./admin/groups/elements-by-group-type-oracle.xql
    • -24
    • +0
    ./admin/groups/elements-by-group-type-postgresql.xql
    • -2
    • +2
    ./admin/groups/elements-by-group-type.tcl
    • -22
    • +0
    ./admin/groups/elements-by-group-type.xql
    • -10
    • +1
    ./admin/groups/elements-display-list.tcl
  1. … 56 more files in changeset.
- strip unused and unneeded sql statements

    • -15
    • +1
    ./admin/group-types/groups-list.tcl
    • -8
    • +2
    ./admin/group-types/rel-type-add-2.tcl
    • -16
    • +2
    ./admin/group-types/rel-type-add.tcl
- no need to use backslash for continuation between curly brackets

- improve readability of code

- modernize tcl

    • -10
    • +12
    ./admin/site-map/allow-for-view.tcl
  1. … 12 more files in changeset.
- no need to quote strings in context manually

- prefer passing &doc as property over doc(title) alone

- fix broken oracle.xql file

- pass values via reference

- prefer ns_quotehtml over ad_quotehtml

    • -3
    • +3
    ./admin/group-types/change-join-policy.tcl
  1. … 27 more files in changeset.
- set return_url for parameter page

- clean up "install" pages

  1. … 5 more files in changeset.
- add dimensional classes to the master used be dotlrn

- fix further action links

- fix unmount url

- white-space changes (follow closer to engineering guidelines)

    • -171
    • +175
    ./admin/site-map/index.tcl