• last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
tightening up regexp for create and drop scripts even more than Don did previously. Adding apm_package_supports_rdbms_p that examines db type of files in file system to determine support. Tightening up regexp for apm_guess_db_type so that only sql, xql, and tcl files have a db type.

Fixed regexp that caused forums-forums-create.sql to be labelled a

datamodel create script for the forums package.

Upgrade to 4.6.2

  1. … 27 more files in changeset.
adding the apm_get_package_files proc for fetching files of certain types of a package. The idea is to rely on the filesystem rather than the info files/db for file listings. Made the install more verbose again for packages as I wanted to see why my installation didn't work. We could use the apm_dummy_callback if we make sure that as soon as there is an error inoformation is presented to the user. It is also good to show progress during installation

  1. … 1 more file in changeset.
allowing for 3 character ISO 639-2 language codes

  1. … 7 more files in changeset.
prevent functions from failing in the event that the url does not parse

Making apm_source update the apm_library_mtime variable (just like the analogous proc for xql files does). Making installation log much less information to the browser (changing from apm_ns_write_callback to apm_dummy_callback). Moving initialization of util_memoize cache to happen before first package is installed (fixes bug 242).

  1. … 2 more files in changeset.
issuing a debug level warning when deprecated procs with the warn flag are invoked

when an xql query is not loaded because of too high version number in the xql file - issue an error message in the log file

Merging changes from oacs-4-6

- With the help of Michael Cleverly, fixed the namespace code so procs

declared like ::foo::bar would work, by only trimming the first ::

- Moved the uplevel'd call to namespace current to the if statement,

to avoid it being called unnecessarily.

- Merge ad_proc documentation improvements to HEAD.

- Added Michael Cleverly's example of use of arguments for boolean

parameters (found in http://openacs.org/forums/message-view?message_id=50519)

to ad_proc's documentation. Thanks for the pointer Jeff! Made boolean

and named parameters explanation clearer.

making sure the acs-tcl test procs are source after the Tcl libraries of acs-automated-testing are sourced

  1. … 1 more file in changeset.
- Add lots more documentation to ad_proc. Even old-time #openacs'ers

(myself included) didn't know how the (formerly undocumented) :boolean

attribute for name parameters worked (thanks Til!).

- Added example to ad_proc's docstring.

Merge of all changes from oacs-4-6 to HEAD. All changes up to tag jcd-merge-2

on oacs-4-6 are included.

  1. … 33 more files in changeset.
adding the Message Catalog APM file type to the TCL API

if there is no full query for a db statement and the default query in the tcl file is empty, raise an error and inform the developer about this (crash early)

merge from oacs-4-6

  1. … 109 more files in changeset.
When query dispatcher lookup fails and the default SQL is empty, bomb.

tone down QD messages bug 1772/patch 473 Bart Teeuwisse

ad_find_all_files was broken for files with spaces

make some procs -public (like empty_string_p)

- Patch by Michael Cleverly for the APM to throw warnings if it's skipping

files in the .tcl directory of packages because they are not -procs or

-init

documentation cleanup

  1. … 1 more file in changeset.
fix calls with literals instead of variables

  1. … 3 more files in changeset.
added ad_proc docs to procs and an ad_proc stub for if ad_proc absent

    • -80
    • +171
    ./40-db-query-dispatcher-procs.tcl
cleanup javadoc tags (eg @cvs_id @cvs @cvs-id: instead if @cvs-id)

  1. … 692 more files in changeset.
reduced debug output by setting db_qd_log level to QDDebug in most log stmts

    • -45
    • +56
    ./40-db-query-dispatcher-procs.tcl
don't make assumptions about what namespace we are upleveling to, when upleveling we must fully qualify the procs we are calling, for example we should say "set foo [uplevel {::set bar greble}]"