OpenACS / openacs-4 / packages

acs-admin

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 49
Last Commit: 14 Nov
Commits this week: 0
Total Lines of Code (LoC): 15,690
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 26 Oct 2013
11:35 am

gustafn

- remove needless quotes from numeric comparisons

Options
    • -2
    • +2
    ./www/apm/version-i18n.tcl
  2. … 1 more file in changeset.
Thursday 17 Oct 2013
10:37 am

gustafn

- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

Options
    • -5
    • +5
    ./tcl/apm-admin-procs.tcl
    • -3
    • +3
    ./www/developer.adp
    • -3
    • +1
    ./www/developer.tcl
    • -1
    • +1
    ./www/apm/package-load.adp
    • -2
    • +2
    ./www/apm/package-load.tcl
    • -2
    • +2
    ./www/apm/packages-install.tcl
    • -2
    • +2
    ./www/apm/version-i18n-process-2.tcl
    • -3
    • +3
    ./www/apm/version-i18n-process.tcl
    • -1
    • +1
    ./www/install/install-3.tcl
  10. … 4 more files in changeset.
Saturday 12 Oct 2013
4:23 pm

gustafn

- reduce number of remaining "string equal" operations

Options
    • -1
    • +1
    ./www/monitor.tcl
    • -1
    • +1
    ./www/install/install.tcl
  3. … 2 more files in changeset.
Friday 11 Oct 2013
1:43 pm

gustafn

- flatten nested "lindex" structures

- use numeric comparison operator for truth value comparisons

Options
    • -3
    • +3
    ./tcl/apm-admin-procs.tcl
    • -2
    • +2
    ./www/send-email.tcl
    • -4
    • +4
    ./www/apm/index.tcl
    • -2
    • +2
    ./www/apm/package-delete.tcl
    • -2
    • +2
    ./www/apm/packages-install-2.tcl
    • -2
    • +2
    ./www/apm/parameter-add-2.tcl
    • -2
    • +2
    ./www/apm/parameter-delete.tcl
    • -2
    • +2
    ./www/apm/parameter-edit-2.tcl
    • -2
    • +2
    ./www/apm/version-dependencies.tcl
    • -6
    • +6
    ./www/apm/version-files.tcl
    • -2
    • +2
    ./www/apm/version-parameters.tcl
    • -5
    • +5
    ./www/apm/version-view.tcl
    • -1
    • +1
    ./www/auth/authority-set-enabled-p.tcl
Wednesday 09 Oct 2013
8:47 am

gustafn

- no need to write ad_quoted to error.log

Options
    • -2
    • +2
    ./tcl/apm-admin-procs.tcl
8:45 am

gustafn

- remove temp files from apm generator

Options
    • -1
    • +2
    ./tcl/apm-admin-procs.tcl
Monday 07 Oct 2013
6:48 pm

gustafn

- fix call to ad_return_complaint

Options
    • -2
    • +2
    ./www/apm/version-dependency-remove.tcl
3:31 pm

victorg

Adding german catalog file for acs-admin.

Options
    • -0
    • +6
    ./catalog/acs-admin.de_DE.ISO-8859-1.xml
Wednesday 02 Oct 2013
12:11 pm

gustafn

- bump version numbers

Options
    • -2
    • +2
    ./acs-admin.info
  2. … 11 more files in changeset.
10:56 am

gustafn

- brace expressions to allow for tcl compilation

- use "in" or not in (ni) operator instead of lsearch (for readability and performance)

Options
    • -2
    • +2
    ./www/apm/packages-install-2.tcl
    • -2
    • +2
    ./www/apm/packages-install-4.tcl
    • -1
    • +1
    ./www/auth/authority-parameters.tcl
    • -1
    • +1
    ./www/install/install-2.tcl
  5. … 7 more files in changeset.
9:44 am

gustafn

- use "in" operator instead of lsearch (for readability and performance)

Options
    • -2
    • +2
    ./www/apm/packages-install.tcl
    • -1
    • +1
    ./www/auth/authority.tcl
  3. … 4 more files in changeset.
9:23 am

gustafn

- move ad_user_class_query and ad_user_class_query_count_only from

packages/acs-tcl/tcl/admin-procs.{tcl,xql} to acs-outdated/tcl/

since these functions are non-functional (based on non-existing

tables)

- move related code from acs-admin/www/users/one.{tcl,xql} to acs-outdated/www/

Options
    • -71
    • +1
    ./www/users/one.tcl
    • -10
    • +0
    ./www/users/one.xql
  3. … 2 more files in changeset.
Tuesday 01 Oct 2013
10:47 am

gustafn

- no need to use "expr" in a condition of a "for" loop

Options
    • -3
    • +3
    ./www/apm/packages-install.tcl
  2. … 3 more files in changeset.
10:16 am

gustafn

- not need to check for existence of variables with defaults: email, first_names, limit_to_users_in_group_id authority_id last_name_starts_with

Options
    • -14
    • +15
    ./www/users/complex-search.tcl
10:09 am

gustafn

- fix spelling limit_users_in_group_id -> limit_to_users_in_group_id

Options
    • -2
    • +2
    ./www/users/complex-search.tcl
    • -6
    • +8
    ./www/users/search.tcl
10:02 am

gustafn

- "email" and "limit_to_user_id" have defaults, no need to check for existence

Options
    • -4
    • +4
    ./www/users/search.tcl
9:54 am

gustafn

- "email" and "last_name" have defaults, no need to check for existence

Options
    • -5
    • +3
    ./www/users/search.tcl
Monday 30 Sep 2013
1:12 pm

gustafn

- use tcl 8.5 extended index format for "string range"

Options
    • -2
    • +2
    ./www/users/user-batch-add-2.tcl
Sunday 29 Sep 2013
8:26 pm

gustafn

- get rid of eval

Options
    • -2
    • +2
    ./www/apm/version-reload.tcl
8:26 pm

gustafn

- nicer linebreaking

Options
    • -2
    • +3
    ./www/apm/index-postgresql.xql
1:10 pm

gustafn

- remove obsolete .xql file

Options
    • -8
    • +0
    ./www/apm/index.xql
    • -13
    • +0
    ./www/apm/package-add.xql
1:10 pm

gustafn

- improve spacing

Options
    • -2
    • +2
    ./www/apm/index.tcl
Saturday 28 Sep 2013
9:14 pm

gustafn

- remove deprecated calls

Options
    • -2
    • +2
    ./www/apm/package-load-2.tcl
  2. … 2 more files in changeset.
8:17 pm

gustafn

- use streaming header for install and install-4

- all usages of apm_header are removed

Options
    • -21
    • +28
    ./www/apm/packages-install-4.tcl
    • -41
    • +29
    ./www/apm/packages-install.tcl
7:53 pm

gustafn

- use the the streaming html template

- get rid of deprecated calls

Options
    • -37
    • +23
    ./www/apm/package-load-2.tcl
    • -10
    • +12
    ./www/apm/write-all-specs.tcl
7:48 pm

gustafn

- mark apm_header as deprecated since it depends on deprecated calls

Options
    • -2
    • +2
    ./tcl/apm-admin-procs.tcl
5:40 pm

gustafn

- remove obsolete test case

Options
    • -13
    • +1
    ./tcl/test/acs-admin-procs.tcl
4:44 pm

gustafn

- fix regression test for cookies (was executed only, when tclwebtest is available, for no reason)

- extend regression test for cookies

- added regression test for client properties

- remove obsolete files

Options
    • -21
    • +0
    ./www/test/security-test.tcl
    • -124
    • +0
    ./www/test/signed-cookies-test-2.tcl
    • -14
    • +0
    ./www/test/signed-cookies-test-2.xql
    • -23
    • +0
    ./www/test/signed-cookies-test.tcl
  5. … 1 more file in changeset.
2:09 pm

gustafn

- cleanup of apm management (reduce redundancy, consistent headers, cleanup HTML, reduce deprecated code, remove obsolete files)

- the only remaining calls to apm_headers are now in combination with ad_return_top_of_page

Options
    • -0
    • +5
    ./www/apm/apm.adp
    • -95
    • +0
    ./www/apm/bulk-intall.tcl
    • -15
    • +0
    ./www/apm/bulk-intall.xql
    • -1
    • +1
    ./www/apm/index.adp
    • -2
    • +1
    ./www/apm/package-add-2.tcl
    • -5
    • +0
    ./www/apm/package-add.adp
    • -7
    • +5
    ./www/apm/package-add.tcl
    • -5
    • +0
    ./www/apm/package-deinstall.adp
    • -6
    • +10
    ./www/apm/package-deinstall.tcl
    • -5
    • +0
    ./www/apm/package-delete-2.adp
    • -2
    • +7
    ./www/apm/package-delete-2.tcl
    • -5
    • +0
    ./www/apm/package-delete.adp
    • -1
    • +2
    ./www/apm/package-delete.tcl
    • -5
    • +0
    ./www/apm/packages-install-2.adp
    • -1
    • +3
    ./www/apm/packages-install-2.tcl
  16. … 28 more files in changeset.
2:09 pm

gustafn

file apm.adp was initially added on branch oacs-5-8.

Options
    • -0
    • +0
    ./www/apm/apm.adp